[Digikam-devel] extragear/graphics/digikam/digikam

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] extragear/graphics/digikam/digikam

Bugzilla from ach@mpe.mpg.de
SVN commit 625944 by ach:

digikam trunk: remove Display Adjustment ... menu item.
        It simply called kcmshell display.  With older KDE use kcmshell
        kgamma should be used.  With new systemsettings kcmshell displayconfig
        need to the called and when kde is installed in Gnome desktop, none
        of the above are usually available.  other distros even have other
        tools for it.  The importance of this menu item is not worth the trouble.

        Gerhard, can you remove it from docs?

CCMAIL: [hidden email], [hidden email]


 M  +0 -22     digikamapp.cpp  
 M  +0 -2      digikamapp.h  
 M  +1 -2      digikamui.rc  


--- trunk/extragear/graphics/digikam/digikam/digikamapp.cpp #625943:625944
@@ -760,14 +760,6 @@
                                    actionCollection(),
                                    "help_donatemoney");
 
-    mGammaAdjustmentAction = new KAction(i18n("Display Adjustment..."),
-                                   "kgamma",
-                                   0,
-                                   this,
-                                   SLOT(slotDisplayAdjustment()),
-                                   actionCollection(),
-                                   "display_adjustment");
-
     // -- Rating actions ---------------------------------------------------------------
 
     m_0Star = new KAction(i18n("Assign Rating \"No Star\""), CTRL+Key_0,
@@ -1063,20 +1055,6 @@
     mImageExifOrientationActionMenu->setEnabled(val);
 }
 
-void DigikamApp::slotDisplayAdjustment()
-{
-   QStringList args;
-   QString *perror = 0;
-   int *ppid = 0;
-
-   args << "display";
-   int ValRet = KApplication::kdeinitExec(QString::fromLatin1("kcmshell"), args, perror, ppid);
-
-   if ( ValRet != 0 )
-      KMessageBox::error(this, i18n("Cannot start \"Display\" configuration panel from KDE control center;\n"
-                                    "please check your installation."));
-}
-
 void DigikamApp::slot_exit()
 {
     close();
--- trunk/extragear/graphics/digikam/digikam/digikamapp.h #625943:625944
@@ -136,7 +136,6 @@
     void slotShowTip();
     void slotShowKipiHelp();
     void slotDonateMoney();
-    void slotDisplayAdjustment();
 
     void slotAboutToShowForwardMenu();
     void slotAboutToShowBackwardMenu();
@@ -255,7 +254,6 @@
     KAction               *mTipAction;
     KAction               *mKipiHelpAction;
     KAction               *mDonateMoneyAction;
-    KAction               *mGammaAdjustmentAction;
     
     AlbumSettings         *mAlbumSettings;
     SplashScreen          *mSplash;
--- trunk/extragear/graphics/digikam/digikam/digikamui.rc #625943:625944
@@ -1,5 +1,5 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="13" name="digikam" >
+<kpartgui version="14" name="digikam" >
 
  <MenuBar>
 
@@ -74,7 +74,6 @@
       <Separator/>
         <ActionList name="album_actions"/>
       <Separator/>
-        <Action name="display_adjustment" />
         <ActionList name="tool_actions"/>
       <Menu name="BatchProcesses"><text>&amp;Batch Processes</text>
         <ActionList name="batch_actions"/>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel