[Digikam-devel] extragear/graphics/digikam/digikam

[Gilles Caulier]

SVN commit 514471 by cgilles:

digikam from trunk : BugFix : Refresh properly current album icon view when Navigate buttons from image properties sidebar are used. The problem isn't really a problem with the current selection : the item selection is right, but the current album items aren't properlly refresh.

Mikolaj, you have reported this problem any time in devel mailing list, please give me a feedback. I'm not sure if you have open a file about in B.K.O. If yes and if this patch work fine for you, please close it.

CCMAIL: [hidden email],  Mikolaj Machowski <[hidden email]>

 M  +13 -15    digikamview.cpp  


--- trunk/extragear/graphics/digikam/digikam/digikamview.cpp #514470:514471
@@ -221,37 +221,35 @@
 void DigikamView::slotFirstItem(void)
 {
     AlbumIconItem *currItem = dynamic_cast<AlbumIconItem*>(mIconView->firstItem());
+    mIconView->clearSelection();
+    mIconView->updateContents();
     if (currItem)
        mIconView->setCurrentItem(currItem);
 }
 
 void DigikamView::slotPrevItem(void)
 {
-    IconItem* prevItem = 0;
-    AlbumIconItem *currItem = mIconView->firstSelectedItem();
-    if (currItem)
-    {
-       prevItem = currItem->prevItem();
-       if (prevItem)
-           mIconView->setCurrentItem(prevItem);
-    }
+    AlbumIconItem *currItem = dynamic_cast<AlbumIconItem*>(mIconView->currentItem());
+    mIconView->clearSelection();
+    mIconView->updateContents();
+    if (currItem)
+       mIconView->setCurrentItem(currItem->prevItem());
 }
 
 void DigikamView::slotNextItem(void)
 {
-    IconItem* nextItem = 0;
-    AlbumIconItem *currItem = mIconView->firstSelectedItem();
+    AlbumIconItem *currItem = dynamic_cast<AlbumIconItem*>(mIconView->currentItem());
+    mIconView->clearSelection();
+    mIconView->updateContents();
     if (currItem)
-    {
-       nextItem = currItem->nextItem();
-       if (nextItem)
-           mIconView->setCurrentItem(nextItem);
-    }
+       mIconView->setCurrentItem(currItem->nextItem());
 }
 
 void DigikamView::slotLastItem(void)
 {
     AlbumIconItem *currItem = dynamic_cast<AlbumIconItem*>(mIconView->lastItem());
+    mIconView->clearSelection();
+    mIconView->updateContents();
     if (currItem)
        mIconView->setCurrentItem(currItem);
 }
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia wtorek, 28 lutego 2006 15:55, Gilles Caulier napisał:
> SVN commit 514471 by cgilles:
>
> digikam from trunk : BugFix : Refresh properly current album icon view
> when Navigate buttons from image properties sidebar are used. The
> problem isn't really a problem with the current selection : the item
> selection is right, but the current album items aren't properlly
> refresh.

Hello,

Wanted to test it but have strange error:

then mv -f ".deps/pngloader.Tpo" ".deps/pngloader.Plo"; else rm -f
".deps/pngloader.Tpo"; exit 1; fi
In file included from pngloader.h:26,
                 from pngloader.cpp:54:
/usr/include/png.h:2524: error: stray '`' in program
/usr/include/png.h:2524: error: expected `,' or `...' before "x"
/usr/include/png.h:2528: error: expected init-declarator before '^' token
/usr/include/png.h:2528: error: expected `,' or `;' before '^' token
In file included from pngloader.h:26,
                 from pngloader.cpp:54:
/usr/include/png.h:2534:2: invalid preprocessing directive #hfdef
/usr/include/png.h:3419:2: #endif without #if
pngloader.cpp: In member function `long int
Digikam::PNGLoader::formatStringList(char*, size_t, const char*, char*)':
pngloader.cpp:1026: warning: function might be possible candidate for
`printf' format attribute

In libs/dimg/loaders directory.

But never previously had this problem and haven't change png-dev
library.

TIA

m.

ps. gcc3.4.3



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mardi 28 Février 2006 19:30, Mikolaj Machowski a écrit :

> Dnia wtorek, 28 lutego 2006 15:55, Gilles Caulier napisał:
> > SVN commit 514471 by cgilles:
> >
> > digikam from trunk : BugFix : Refresh properly current album icon view
> > when Navigate buttons from image properties sidebar are used. The
> > problem isn't really a problem with the current selection : the item
> > selection is right, but the current album items aren't properlly
> > refresh.
>
> Hello,
>
> Wanted to test it but have strange error:
>
> then mv -f ".deps/pngloader.Tpo" ".deps/pngloader.Plo"; else rm -f
> ".deps/pngloader.Tpo"; exit 1; fi
> In file included from pngloader.h:26,
>                  from pngloader.cpp:54:
> /usr/include/png.h:2524: error: stray '`' in program
> /usr/include/png.h:2524: error: expected `,' or `...' before "x"
> /usr/include/png.h:2528: error: expected init-declarator before '^' token
> /usr/include/png.h:2528: error: expected `,' or `;' before '^' token
> In file included from pngloader.h:26,
>                  from pngloader.cpp:54:
> /usr/include/png.h:2534:2: invalid preprocessing directive #hfdef
> /usr/include/png.h:3419:2: #endif without #if
> pngloader.cpp: In member function `long int
> Digikam::PNGLoader::formatStringList(char*, size_t, const char*, char*)':
> pngloader.cpp:1026: warning: function might be possible candidate for
> `printf' format attribute
>
> In libs/dimg/loaders directory.
>
> But never previously had this problem and haven't change png-dev
> library.
>
> TIA
>
> m.
>
> ps. gcc3.4.3

I can't reproduce it. Trying to use a fresh svn checkout.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia środa, 1 marca 2006 09:29, Caulier Gilles napisał:
>
> I can't reproduce it. Trying to use a fresh svn checkout.

Fresh checkout fixed this. Navigating from sidebar looks OK.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mercredi 1 Mars 2006 14:55, Mikolaj Machowski a écrit :
> Dnia środa, 1 marca 2006 09:29, Caulier Gilles napisał:
> > I can't reproduce it. Trying to use a fresh svn checkout.
>
> Fresh checkout fixed this. Navigating from sidebar looks OK.
>

Good sound. Have you open a file in B.K.O about ? I haven't found it today...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> Good sound. Have you open a file in B.K.O about ? I haven't found it
> today...

I didn't open bug entry. IFAIR only confirmed behaviour - only on list.

----------------------------------------------------
Interaktywna wystawa HI-TECH z Tokio ODKRYWANIE CZASU
nauka, eksperyment, zabawa -> Warszawa, Pałac Kultury i Nauki
do 29.11.2006 wspaniała rozrywka dla całej rodziny!
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fczas.html&sid=677


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel