[Digikam-devel] advanced search calendar widget

Hello,

v 0.9svn

Was looking for some pictures and noticed one thing in calendar widget:

below calendar are some predefined entries: Today, Tomorrow, Friday,
Sunday, Next Week, Next Month. They are hardly useful when looking for
images. Searching is directed toward past. That terms are directed into
future. I suppose widget was imported directly from some scheduling KDE
app - and scheduling is directed into future.

Suggestion:

If possible change predefined terms into: Today, Yesterday, Last Week,
Last Month. Eventually leave Friday, Sunday but make them to look into
the past to find photos from last weekend, beginning of current week.

or

Remove them. In current form they are all but Today useless - all
photos will be Before Tomorrow, or none After Tomorrow (or Equal to
Tomorrow). And going to Today can be executed with button on the left
from input field.

m.

ps. I see kdatepicker stuff is in digiKam directory so changes are
    possible.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Lundi 03 Avril 2006 10:08 PM, Mikolaj Machowski a écrit :

> Hello,
>
> v 0.9svn
>
> Was looking for some pictures and noticed one thing in calendar widget:
>
> below calendar are some predefined entries: Today, Tomorrow, Friday,
> Sunday, Next Week, Next Month. They are hardly useful when looking for
> images. Searching is directed toward past. That terms are directed into
> future. I suppose widget was imported directly from some scheduling KDE
> app - and scheduling is directed into future.
>
> Suggestion:
>
> If possible change predefined terms into: Today, Yesterday, Last Week,
> Last Month. Eventually leave Friday, Sunday but make them to look into
> the past to find photos from last weekend, beginning of current week.
>
> or
>
> Remove them. In current form they are all but Today useless - all
> photos will be Before Tomorrow, or none After Tomorrow (or Equal to
> Tomorrow). And going to Today can be executed with button on the left
> from input field.
>
> m.
>
> ps. I see kdatepicker stuff is in digiKam directory so changes are
>     possible.

This widget have been backported from kmail during 0.8.0 release. Take a look
if current implementation of kmail have been improved in this way...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia poniedziałek, 3 kwietnia 2006 22:46, Caulier Gilles napisał:
>
> This widget have been backported from kmail during 0.8.0 release. Take a
> look if current implementation of kmail have been improved in this
> way...

kdepim implementation hasn't changed because they don't need to: they
are still looking into the future while Digikam should look in the other
way :)

Attaching patch against kdatepickerpopup.cpp and kdatepickerpopup.h from
digikam/digikam level.

m.


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Friday 16 June 2006 11:40, Mikolaj Machowski wrote:

> Dnia poniedziałek, 3 kwietnia 2006 22:46, Caulier Gilles napisał:
> > This widget have been backported from kmail during 0.8.0 release. Take a
> > look if current implementation of kmail have been improved in this
> > way...
>
> kdepim implementation hasn't changed because they don't need to: they
> are still looking into the future while Digikam should look in the other
> way :)
>
> Attaching patch against kdatepickerpopup.cpp and kdatepickerpopup.h from
> digikam/digikam level.
>
> m.

Please remember me what your patch must done exactly...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia piątek, 16 czerwca 2006 11:49, Gilles Caulier napisał:
>
> Please remember me what your patch must done exactly...

Current implementation selects dates in future which are useless for
Digikam. My patch selects: Yesterday, Last Week, Last Friday, Last
Monday, Last Month.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 16 Juin 2006 20:56, Mikolaj Machowski a écrit :
> Dnia piątek, 16 czerwca 2006 11:49, Gilles Caulier napisał:
> > Please remember me what your patch must done exactly...
>
> Current implementation selects dates in future which are useless for
> Digikam. My patch selects: Yesterday, Last Week, Last Friday, Last
> Monday, Last Month.
>

Totally agree with this patch. A picture is always taken in the past, never in
the future... Commited ! Thanks Mikolaj...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia sobota, 17 czerwca 2006 21:51, Caulier Gilles napisał:

> Le Vendredi 16 Juin 2006 20:56, Mikolaj Machowski a écrit :
> > Dnia piątek, 16 czerwca 2006 11:49, Gilles Caulier napisał:
> > > Please remember me what your patch must done exactly...
> >
> > Current implementation selects dates in future which are useless for
> > Digikam. My patch selects: Yesterday, Last Week, Last Friday, Last
> > Monday, Last Month.
>
> Totally agree with this patch. A picture is always taken in the past,
> never in the future... Commited ! Thanks Mikolaj...

Continuing (without patch, yet - I hope)...

Current implementation only allows for selecting time "Before" or
"After" selected date. With that in mind I used "Last Friday", "Last
Monday" to quick finding of photos taken during last weekend - as
Digikam is primarily for amateur photographers. But it is possible to
use with semi-prof or higher profile users. For them it could be useful
to select photos from last working week. It would mean adding
combination eg. "After"+"Last Sunday" but multiplication of kdatepicker
entries IMO isn't best solution - better would be expansion of date
conditions for "Day and after" (or "After (inclusive)") and "Day and
before (or "Before (inclusive)").

I started messing with this, added two entries into description table
(and increased RuleOptTableCound) in digikam/searchwidgets.cpp:

    { I18N_NOOP("Day and after"),      "GE",          
SearchAdvancedRule::DATE },
    { I18N_NOOP("Day and before"),     "LE",          
SearchAdvancedRule::DATE },

(1st field: label, 2nd: SQL keyword, 3rd: internal Digikam setting).

It comes out with sqlite error:

sqlite_compile error: near ")": syntax error on query: SELECT
Albums.url||'/'||Images.name FROM Images, Albums LEFT JOIN
ImageProperties on Images.id = ImageProperties.imageid WHERE ( ) AND
(Albums.id=Images.dirid) LIMIT 500;

SQLite doesn't like GE/LE (greater or equal, lesser or equal) on DATE
objects or something was missed?

BTW - small bug/inconsistency surfaced when testing some options:
I've made search for images "After" 23.05.2006 "As Well As" "Before"
25.05.2006. According to logic it should return images only from
24.05.2006, but it lists images from 23rd and 24th of May! After is
inclusive (GT) and Before is exclusive (LT). Don't know where is fault
Digikam code, Qt glitch when transferring dates or SQL(ite) specific
thing. At least it should be "fixed" by renaming option from "After" to
"After (inclusive)".

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> It comes out with sqlite error:
>
> sqlite_compile error: near ")": syntax error on query: SELECT
> Albums.url||'/'||Images.name FROM Images, Albums LEFT JOIN
> ImageProperties on Images.id = ImageProperties.imageid WHERE ( ) AND
> (Albums.id=Images.dirid) LIMIT 500;
>
> SQLite doesn't like GE/LE (greater or equal, lesser or equal) on DATE
> objects or something was missed?

The sqlite3 tool is very fast and effective to test database queries.
In the above query, sqlite does not like the empty "( ) AND" part, where
something seems to be missing while constructing the query.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel