[Digikam-devel] Possibly dangerous bug in 0.9.0-beta1

[Marcel Wiesweg]

Hi,

I am referring to bug 131277,
http://bugs.kde.org/show_bug.cgi?id=131277

Short summary:
The preview ioslave of 0.9.0-beta1 does not free its Shared Memory segments.
For every image that is selected or viewed, a 4MB memory segment is reserved.
These segments are not freed after the process has terminated!!! (Linux moves
them to swap, though).
A longer usage of digikam will thus fill up swap and memory.
This is fixed in SVN.

Can anyone (except Rainer and me) verify this?
Use "ipcs -m" to display Shared memory segments.

As an intermediate solution, lost memory can be removed by ipcrm:
for i in `ipcs -m|grep 4194304|awk '{print $2}'`; do ipcrm -m $i; done

Assuming the problem can be verified:
It will be >4 weeks till beta2, with Gilles on holidays. I cannot with good
conscience say "go on and test beta1, it has great new features" to users,
"but it will eat your memory".

I am wondering if we should release a beta1-r1 or whatever which is
beta1 + the fix for the problem.
I need your viewpoints!

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rainer Krienke-2]

Am Samstag, 29. Juli 2006 15:25 schrieb Marcel Wiesweg:
>
> Can anyone (except Rainer and me) verify this?
> Use "ipcs -m" to display Shared memory segments.

Your bug fix in svn works for me. There are no more 4MB shared memory segments
after digikam has terminated.
 

>
> As an intermediate solution, lost memory can be removed by ipcrm:
> for i in `ipcs -m|grep 4194304|awk '{print $2}'`; do ipcrm -m $i; done
>
> Assuming the problem can be verified:
> It will be >4 weeks till beta2, with Gilles on holidays. I cannot with good
> conscience say "go on and test beta1, it has great new features" to users,
> "but it will eat your memory".
>
> I am wondering if we should release a beta1-r1 or whatever which is
> beta1 + the fix for the problem.
> I need your viewpoints!

If more people can confirm this problem:
From my point of view it would be good to release another beta version since
this bug is really bad and might leave a bad taste for some people which have
only little meomory in their systems. This memory could get occupied
completely by digikam and could lead to a system freeze which might after all
lead to a loss of other unsaved data.  

Rainer

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

Am Samstag, 29. Juli 2006 16:56 schrieb Rainer Krienke:

> Am Samstag, 29. Juli 2006 15:25 schrieb Marcel Wiesweg:
> > Can anyone (except Rainer and me) verify this?
> > Use "ipcs -m" to display Shared memory segments.
>
> Your bug fix in svn works for me. There are no more 4MB shared memory
> segments after digikam has terminated.
>
> > As an intermediate solution, lost memory can be removed by ipcrm:
> > for i in `ipcs -m|grep 4194304|awk '{print $2}'`; do ipcrm -m $i; done
> >
> > Assuming the problem can be verified:
> > It will be >4 weeks till beta2, with Gilles on holidays. I cannot with
> > good conscience say "go on and test beta1, it has great new features" to
> > users, "but it will eat your memory".
> >
> > I am wondering if we should release a beta1-r1 or whatever which is
> > beta1 + the fix for the problem.
> > I need your viewpoints!
>
> If more people can confirm this problem:
> From my point of view it would be good to release another beta version
> since this bug is really bad and might leave a bad taste for some people
> which have only little meomory in their systems. This memory could get
> occupied completely by digikam and could lead to a system freeze which
> might after all lead to a loss of other unsaved data.
>
> Rainer

I can confirm this problem, it bugged me for quite a while, and after the fix
from Marcel it's gone. Another beta release is much wished for I'd say.
Gerhard
--
http://www.gerhard.fr
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

Hi,

I have now created a 0.9.0-beta1-r1 which is the code from beta1 and the fix
for the memory leak. So this is not a new release, this is not beta2.
I am still unsure if I should delete the old 0.9.0-beta1 tarball from sf.net.
For now I have moved it to another release, we can delete it or we can move it
back to the release, but users will not know which one to download.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hello,

> Can anyone (except Rainer and me) verify this?
> Use "ipcs -m" to display Shared memory segments.
>
> As an intermediate solution, lost memory can be removed by ipcrm:
> for i in `ipcs -m|grep 4194304|awk '{print $2}'`; do ipcrm -m $i; done

I think there still exists a problem with this, but not for every picture, but
for every time you launch Digikam. After I used Digikam for a while and
downloaded some pictures and run ipcs -m I have these new entries:
0x00000000 8585218    klaus     600        262144     0
0x00000000 1736707    klaus     666        461280     0
I started Digikam again and after viewing some pics and closing it there is
this new entry after the others:
0x00000000 9895941    klaus     600        262144     0
and once more starting Digikam viewing pictures and closing again there is one
more entry in ipcs -m:
0x00000000 10878982   klaus     600        262144     0
Not sure if this is related I have unfortunately not so much clue about this
kind of things. :(


But I also realized a problem today with downloaded pictures that get
autorotated. The preview picture in the albums is correct. Do I open the
autorotated picture I only see the first few lines, the rest is just
gray. "Open with..." kuickshow, gimp, showFoto shows the pictures correct.
After I close Digikam and start it again also in Digikam the pictures are
shown correct. Seems that there is somewhere a cache that is not refreshed
after the autorotate?

Regards,
Klaus

--
take care!

xo,klaus

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I think there still exists a problem with this, but not for every picture,
> but for every time you launch Digikam. After I used Digikam for a while and
> downloaded some pictures and run ipcs -m I have these new entries:
> 0x00000000 8585218    klaus     600        262144     0
> 0x00000000 1736707    klaus     666        461280     0
> I started Digikam again and after viewing some pics and closing it there is
> this new entry after the others:
> 0x00000000 9895941    klaus     600        262144     0
> and once more starting Digikam viewing pictures and closing again there is
> one more entry in ipcs -m:
> 0x00000000 10878982   klaus     600        262144     0
> Not sure if this is related I have unfortunately not so much clue about
> this kind of things. :(

Yes, this comes from the thumbnail loader ioslave. It is fixed on my local
machine and in beta1-r1 but not yet in svn because I have some other changes
in that file.

>
>
> But I also realized a problem today with downloaded pictures that get
> autorotated. The preview picture in the albums is correct. Do I open the
> autorotated picture I only see the first few lines, the rest is just
> gray. "Open with..." kuickshow, gimp, showFoto shows the pictures correct.
> After I close Digikam and start it again also in Digikam the pictures are
> shown correct. Seems that there is somewhere a cache that is not refreshed
> after the autorotate?

That is strange.
Please create a new report in b.k.o. for this.

Marcel

>
> Regards,
> Klaus
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel