[Digikam-devel] [PATCH] (well patchlet actually) : get rid of the resize() workaround in ImageWindow ctor

[Guillaume Laurent]

May be it solved itself, but AFAICT, the ImageWindow opens itself with the
expected size :

Index: utilities/imageeditor/editor/imagewindow.cpp
===================================================================
--- utilities/imageeditor/editor/imagewindow.cpp        (revision 534742)
+++ utilities/imageeditor/editor/imagewindow.cpp        (working copy)
@@ -139,10 +139,6 @@

     //-------------------------------------------------------------

-    // This is just a bloody workaround until we have found the problem
-    // which leads the imagewindow to open in a wrong size
-    resize(640, 480);
-
     m_rightSidebar->loadViewState();
     m_rightSidebar->populateTags();
 }

--
Guillaume.
http://www.telegraph-road.org
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Samedi 29 Avril 2006 05:11 PM, Guillaume Laurent a écrit :

> May be it solved itself, but AFAICT, the ImageWindow opens itself with the
> expected size :
>
> Index: utilities/imageeditor/editor/imagewindow.cpp
> ===================================================================
> --- utilities/imageeditor/editor/imagewindow.cpp        (revision 534742)
> +++ utilities/imageeditor/editor/imagewindow.cpp        (working copy)
> @@ -139,10 +139,6 @@
>
>      //-------------------------------------------------------------
>
> -    // This is just a bloody workaround until we have found the problem
> -    // which leads the imagewindow to open in a wrong size
> -    resize(640, 480);
> -
>      m_rightSidebar->loadViewState();
>      m_rightSidebar->populateTags();
>  }

This code is necessary in 0.8.X serie for obscurs reasons... Perhaps it's not
solved in trunk since image editor / showfoto GUI code have been re-written
and is now common...

Have you tested indeep in trunk with removing this lines ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Guillaume Laurent]

On Monday 01 May 2006 11:19, Caulier Gilles wrote:
>
> This code is necessary in 0.8.X serie for obscurs reasons... Perhaps it's
> not solved in trunk since image editor / showfoto GUI code have been
> re-written and is now common...
>
> Have you tested indeep in trunk with removing this lines ?

I've spend the last three days doing photo retouchings with digikam, processed
about 300 pics using trunk : no size problem found.

--
Guillaume.
http://www.telegraph-road.org
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mardi 02 Mai 2006 12:24 AM, Guillaume Laurent a écrit :
> On Monday 01 May 2006 11:19, Caulier Gilles wrote:
> > This code is necessary in 0.8.X serie for obscurs reasons... Perhaps it's
> > not solved in trunk since image editor / showfoto GUI code have been
> > re-written and is now common...
> >
> > Have you tested indeep in trunk with removing this lines ?
>
> I've spend the last three days doing photo retouchings with digikam,
> processed about 300 pics using trunk : no size problem found.

Ok. code removed to have a feedback from user. The problem is know. If it's
back we know the story

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel