[Digikam-devel] [PATCH] use a QListBox rather than a set of radio buttons for b&w plugin

[Gilles Caulier-2]

Le Mercredi 10 Mai 2006 06:49 AM, Gerhard Kulzer a écrit :

> On Tuesday 9 May 2006 11:14, Guillaume Laurent wrote:
> > On Tuesday 09 May 2006 10:36, Caulier Gilles wrote:
> > > I have completed some optimizations in svn. Please take a look before
> > > to update Auto Color correction (if you want to do)...
> >
> > OK, much simpler indeed. However I'd set the smoothScale to 256,256 for
> > the thumbnail, 128,128 looks a bit too small here (it may depend on the
> > resolution though, I have 1600x1200... perhaps make it configurable ?)
>
> Gilles and Guillaume,
> I'd like to inject again my wish here for separating the filters
> (neutral...yellow) from the coloring (sepia...platinum) so as the coloring
> can be applied as a second action on top of the filtering. Then we would
> need two of those boxes. If looked at the code myself, but I feel not quite
> up to that.
>
> Can also wait for later release.

Yes, i will do it later, but for that i would execute filter in a separate
thread too. In fact all standard color image plugins don't use a separate
thead yet...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mercredi 10 Mai 2006 06:49 AM, Gerhard Kulzer a écrit :

> On Tuesday 9 May 2006 11:14, Guillaume Laurent wrote:
> > On Tuesday 09 May 2006 10:36, Caulier Gilles wrote:
> > > I have completed some optimizations in svn. Please take a look before
> > > to update Auto Color correction (if you want to do)...
> >
> > OK, much simpler indeed. However I'd set the smoothScale to 256,256 for
> > the thumbnail, 128,128 looks a bit too small here (it may depend on the
> > resolution though, I have 1600x1200... perhaps make it configurable ?)
>
> Gilles and Guillaume,
> I'd like to inject again my wish here for separating the filters
> (neutral...yellow) from the coloring (sepia...platinum) so as the coloring
> can be applied as a second action on top of the filtering. Then we would
> need two of those boxes. If looked at the code myself, but I feel not quite
> up to that.

Well, Gerhard, like i'm in a good day, well... done in svn

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

On Wednesday 10 May 2006 16:00, Caulier Gilles wrote:

> Le Mercredi 10 Mai 2006 06:49 AM, Gerhard Kulzer a écrit :
> > On Tuesday 9 May 2006 11:14, Guillaume Laurent wrote:
> > > On Tuesday 09 May 2006 10:36, Caulier Gilles wrote:
> > > > I have completed some optimizations in svn. Please take a look before
> > > > to update Auto Color correction (if you want to do)...
> > >
> > > OK, much simpler indeed. However I'd set the smoothScale to 256,256 for
> > > the thumbnail, 128,128 looks a bit too small here (it may depend on the
> > > resolution though, I have 1600x1200... perhaps make it configurable ?)
> >
> > Gilles and Guillaume,
> > I'd like to inject again my wish here for separating the filters
> > (neutral...yellow) from the coloring (sepia...platinum) so as the
> > coloring can be applied as a second action on top of the filtering. Then
> > we would need two of those boxes. If looked at the code myself, but I
> > feel not quite up to that.
>
> Well, Gerhard, like i'm in a good day, well... done in svn
>
> Gilles

Oh it's a really nice day (also on the island), Gilles you are becoming the
digikam hero, I'm sure that's not only my opinion. Thank you so much! (:-))

Gerhard
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Wednesday 10 May 2006 21:14, Gerhard Kulzer wrote:

> On Wednesday 10 May 2006 16:00, Caulier Gilles wrote:
> > Le Mercredi 10 Mai 2006 06:49 AM, Gerhard Kulzer a écrit :
> > > On Tuesday 9 May 2006 11:14, Guillaume Laurent wrote:
> > > > On Tuesday 09 May 2006 10:36, Caulier Gilles wrote:
> > > > > I have completed some optimizations in svn. Please take a look before
> > > > > to update Auto Color correction (if you want to do)...
> > > >
> > > > OK, much simpler indeed. However I'd set the smoothScale to 256,256 for
> > > > the thumbnail, 128,128 looks a bit too small here (it may depend on the
> > > > resolution though, I have 1600x1200... perhaps make it configurable ?)
> > >
> > > Gilles and Guillaume,
> > > I'd like to inject again my wish here for separating the filters
> > > (neutral...yellow) from the coloring (sepia...platinum) so as the
> > > coloring can be applied as a second action on top of the filtering. Then
> > > we would need two of those boxes. If looked at the code myself, but I
> > > feel not quite up to that.
> >
> > Well, Gerhard, like i'm in a good day, well... done in svn
> >
> > Gilles
>
> Oh it's a really nice day (also on the island), Gilles you are becoming the
> digikam hero, I'm sure that's not only my opinion. Thank you so much! (:-))

I fully agree!

Achim
>
> Gerhard
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

--
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- [hidden email]
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mercredi 10 Mai 2006 09:46 PM, Achim Bohnet a écrit :

> On Wednesday 10 May 2006 21:14, Gerhard Kulzer wrote:
> > On Wednesday 10 May 2006 16:00, Caulier Gilles wrote:
> > > Le Mercredi 10 Mai 2006 06:49 AM, Gerhard Kulzer a écrit :
> > > > On Tuesday 9 May 2006 11:14, Guillaume Laurent wrote:
> > > > > On Tuesday 09 May 2006 10:36, Caulier Gilles wrote:
> > > > > > I have completed some optimizations in svn. Please take a look
> > > > > > before to update Auto Color correction (if you want to do)...
> > > > >
> > > > > OK, much simpler indeed. However I'd set the smoothScale to 256,256
> > > > > for the thumbnail, 128,128 looks a bit too small here (it may
> > > > > depend on the resolution though, I have 1600x1200... perhaps make
> > > > > it configurable ?)
> > > >
> > > > Gilles and Guillaume,
> > > > I'd like to inject again my wish here for separating the filters
> > > > (neutral...yellow) from the coloring (sepia...platinum) so as the
> > > > coloring can be applied as a second action on top of the filtering.
> > > > Then we would need two of those boxes. If looked at the code myself,
> > > > but I feel not quite up to that.
> > >
> > > Well, Gerhard, like i'm in a good day, well... done in svn
> > >
> > > Gilles
> >
> > Oh it's a really nice day (also on the island), Gilles you are becoming
> > the digikam hero, I'm sure that's not only my opinion. Thank you so much!
> > (:-))
>
> I fully agree!
>
> Achim

Thanks to all (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Guillaume Laurent]

On Tuesday 09 May 2006 22:44, Caulier Gilles wrote:
> Le Mardi 09 Mai 2006 09:37 PM, Mikolaj Machowski a écrit :
>
> > Apart from that: great feature and it would be fantastic to see it in
> > similar plugins.
>
> Yes, but let's Guillaume finalize the code. After we can create a shared
> widget for that in digikam/libs/widgets/imageplugins...

The attached patch moves the listbox related bits to seperate classes in
utilities/imageeditor/editor, so the autocorrection plugin can use them. It
also make the thumbnails in the bw plugin to reflect changes in contrast and
curves.

Can I commit ?

--
Guillaume.
http://www.telegraph-road.org

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Thursday 11 May 2006 11:41 am, Guillaume Laurent wrote:

> On Tuesday 09 May 2006 22:44, Caulier Gilles wrote:
> > Le Mardi 09 Mai 2006 09:37 PM, Mikolaj Machowski a écrit :
> > > Apart from that: great feature and it would be fantastic to see it in
> > > similar plugins.
> >
> > Yes, but let's Guillaume finalize the code. After we can create a shared
> > widget for that in digikam/libs/widgets/imageplugins...
>
> The attached patch moves the listbox related bits to seperate classes in
> utilities/imageeditor/editor, so the autocorrection plugin can use them. It
> also make the thumbnails in the bw plugin to reflect changes in contrast
> and curves.
>
> Can I commit ?

Yes, but you must move 'listboxpreviewitem.h/.cpp' into
digikam/libs/widgets/imageplugins :

- all widgets for image plugins are stored at this place.
- we can use it in DigikamImagePlugins, these widgets will be shared into
libdigikam.la

Thanks in advance

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Thursday 11 May 2006 11:41 am, Guillaume Laurent wrote:

> On Tuesday 09 May 2006 22:44, Caulier Gilles wrote:
> > Le Mardi 09 Mai 2006 09:37 PM, Mikolaj Machowski a écrit :
> > > Apart from that: great feature and it would be fantastic to see it in
> > > similar plugins.
> >
> > Yes, but let's Guillaume finalize the code. After we can create a shared
> > widget for that in digikam/libs/widgets/imageplugins...
>
> The attached patch moves the listbox related bits to seperate classes in
> utilities/imageeditor/editor, so the autocorrection plugin can use them. It
> also make the thumbnails in the bw plugin to reflect changes in contrast
> and curves.
>
> Can I commit ?

Ah forget to said that listboxwhatsthis.cpp/.h must be moved into
digikam/libs/widgets/imageplugins too...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Thursday 11 May 2006 11:41 am, Guillaume Laurent wrote:

> On Tuesday 09 May 2006 22:44, Caulier Gilles wrote:
> > Le Mardi 09 Mai 2006 09:37 PM, Mikolaj Machowski a écrit :
> > > Apart from that: great feature and it would be fantastic to see it in
> > > similar plugins.
> >
> > Yes, but let's Guillaume finalize the code. After we can create a shared
> > widget for that in digikam/libs/widgets/imageplugins...
>
> The attached patch moves the listbox related bits to seperate classes in
> utilities/imageeditor/editor, so the autocorrection plugin can use them. It
> also make the thumbnails in the bw plugin to reflect changes in contrast
> and curves.
>
> Can I commit ?

Unforget to CCMAIL into [hidden email] when you commit too (:=))))...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Guillaume Laurent]

On Thursday 11 May 2006 11:48, Gilles Caulier wrote:
> On Thursday 11 May 2006 11:41 am, Guillaume Laurent wrote:
> >
> > Can I commit ?
>
> Yes, but you must move 'listboxpreviewitem.h/.cpp' into
> digikam/libs/widgets/imageplugins :

It's in.

--
Guillaume.
http://www.telegraph-road.org
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel