[Digikam-devel] Order of setting pages

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] Order of setting pages

Gerhard Kulzer
Hi Gilles,
since you worked on the settings I'd like to ask for a (easy) wish: The
ordering of setting pages should be regrouped from this order

d->dcrawPage = new SetupDcraw(d->page_dcraw);
d->iofilesPage = new SetupIOFiles(d->page_iofiles);
d->imgpluginsPage = new SetupImgPlugins(d->page_imgplugins);
d->slideshowPage = new SetupSlideShow(d->page_slideshow);
d->iccPage = new SetupICC(d->page_icc, this);
   
to this order:
d->dcrawPage = new SetupDcraw(d->page_dcraw);
d->iccPage = new SetupICC(d->page_icc, this);
d->iofilesPage = new SetupIOFiles(d->page_iofiles);
d->imgpluginsPage = new SetupImgPlugins(d->page_imgplugins);
d->slideshowPage = new SetupSlideShow(d->page_slideshow);

This makes sense because those themes and their settings belong together. I
don't like to navigate in the left frame for the logically next step.
I can commit the change myself if you agree.

Gerhard

--
Hakuna matata
http://www.gerhard.fr
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] Order of setting pages

Gilles Caulier-2
Le mardi 6 février 2007 15:04, Gerhard Kulzer a écrit :

> Hi Gilles,
> since you worked on the settings I'd like to ask for a (easy) wish: The
> ordering of setting pages should be regrouped from this order
>
> d->dcrawPage = new SetupDcraw(d->page_dcraw);
> d->iofilesPage = new SetupIOFiles(d->page_iofiles);
> d->imgpluginsPage = new SetupImgPlugins(d->page_imgplugins);
> d->slideshowPage = new SetupSlideShow(d->page_slideshow);
> d->iccPage = new SetupICC(d->page_icc, this);
>
> to this order:
> d->dcrawPage = new SetupDcraw(d->page_dcraw);
> d->iccPage = new SetupICC(d->page_icc, this);
> d->iofilesPage = new SetupIOFiles(d->page_iofiles);
> d->imgpluginsPage = new SetupImgPlugins(d->page_imgplugins);
> d->slideshowPage = new SetupSlideShow(d->page_slideshow);
>
> This makes sense because those themes and their settings belong together. I
> don't like to navigate in the left frame for the logically next step.
> I can commit the change myself if you agree.

no problem. unforget to fix the settings page order from showfoto too
(digikam/showfoto/setup/setup.cpp). It's a simplified implementation version
witch use the same logic than digikam setup.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel