[Digikam-devel] Image Metadata extraction : implementation progress...

[Gilles Caulier-2]

Le Mardi 28 Février 2006 16:51, Andreas Huggel a écrit :

> In DMetaLoader::loadWithExiv2()
>
> +        Exiv2::ExifData& exifData = image->exifData();
>               ----------^
> Reference to prevent copying (and similar for Iptc).
>
> +    catch( Exiv2::AnyError &e )
>          ----------^^^ Baseclass in case future versions have more error
> classes
> +    {
> +        kdDebug() << "Cannot load metadata using Exiv2 (" << e << ")" <<
> endl;
>  If you wanted the error message instead of just a code ------^
> +        return false;
> +    }

Ok. Implementation fixed. I wil provide a new diff against svn trunk...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier wrote:

>Ok, we have improved the "tag values" output. Now, still the problem to do an
>user friendly output of "tag names" like :
>
>DateTimeOriginal ==> Image timestamp.
>  
>
I missed that one out. Try Exiv2::ExifTags::tagTitle(), I think this is
what you are looking for, although these labels may need tweaking.
Suggestions welcome.

>In ExifWidget::decodeMetadata() my implementation is  :
>
>...
>
>for (Exiv2::ExifData::iterator md = exifData.begin(); md != exifData.end();
>++md)
>        {
>            QString key   = QString::fromLocal8Bit(md->key().c_str());
>
>            // Decode the tag value with a user friendly output.
>            std::ostringstream os;
>            os << *md;
>            QString value = QString::fromLocal8Bit(os.str().c_str());
>
>            // We apply a filter to get only standard Exif tags, not maker
>notes.
>            if (stdExifFilter.contains(key.section(".", 1, 1)))
>                metaDataMap.insert(key, value);
>        }
>
>There is a way to make it automaticly using Exiv2 ?
>  
>

Not sure which part you'd like to have automated, but I can't see
anything that Exiv2 could do for you here.
If anything, I suggest to decode the value only inside the if, i.e.,
only if you actually need it.

-ahu.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Hi all,

The version 2 of the metadata diff patch against 'trunk' svn is done.

You can donwload it at this url :

http://digikam3rdparty.free.fr/misc.tarballs/metadata2.diff

The patch can be applied from a fresh svn checkout like this :

[gilles@lserv3 digikam]$ pwd
/home/gilles/Documents/Devel/SVN/trunk/graphics.full/digikam
[gilles@lserv3 digikam]$ patch -p0 < metadata2.diff
patching file libs/dimg/dimg.cpp
patching file libs/dimg/dimg.h
patching file libs/dimg/dimgloader.cpp
patching file libs/dimg/loaders/pngloader.cpp
patching file libs/dimg/loaders/jpegloader.cpp
patching file libs/dimg/loaders/rawloader.cpp
patching file libs/dimg/Makefile.am
patching file libs/dimg/dimgloader.h
patching file libs/dmetadata/dmetadata.cpp
patching file libs/dmetadata/loaders/dmetaloader.cpp
patching file libs/dmetadata/loaders/pngmetaloader.cpp
patching file libs/dmetadata/loaders/jpegmetaloader.cpp
patching file libs/dmetadata/loaders/dmetaloader.h
patching file libs/dmetadata/loaders/tiffmetaloader.cpp
patching file libs/dmetadata/loaders/pngmetaloader.h
patching file libs/dmetadata/loaders/rawmetaloader.cpp
patching file libs/dmetadata/loaders/jpegmetaloader.h
patching file libs/dmetadata/loaders/Makefile.am
patching file libs/dmetadata/loaders/tiffmetaloader.h
patching file libs/dmetadata/loaders/rawmetaloader.h
patching file libs/dmetadata/Makefile.am
patching file libs/dmetadata/dmetadata.h
patching file libs/imageproperties/imagepropertiessidebar.h
patching file libs/imageproperties/imagepropertiessidebardb.cpp
patching file libs/imageproperties/imagepropertiesexiftab.cpp
patching file libs/imageproperties/imagepropertiesexiftab.h
patching file libs/imageproperties/imagepropertiessidebarcamgui.cpp
patching file libs/imageproperties/imagepropertiessidebarcamgui.h
patching file libs/imageproperties/Makefile.am
patching file libs/imageproperties/imagepropertiessidebar.cpp
patching file libs/widgets/metadata/makernotewidget.h
patching file libs/widgets/metadata/exifwidget.cpp
patching file libs/widgets/metadata/iptcwidget.cpp
patching file libs/widgets/metadata/exifwidget.h
patching file libs/widgets/metadata/metadatalistview.cpp
patching file libs/widgets/metadata/iptcwidget.h
patching file libs/widgets/metadata/metadatalistview.h
patching file libs/widgets/metadata/mdkeylistviewitem.cpp
patching file libs/widgets/metadata/mdkeylistviewitem.h
patching file libs/widgets/metadata/metadatawidget.cpp
patching file libs/widgets/metadata/metadatalistviewitem.cpp
patching file libs/widgets/metadata/Makefile.am
patching file libs/widgets/metadata/makernotewidget.cpp
patching file libs/widgets/metadata/metadatawidget.h
patching file libs/widgets/metadata/metadatalistviewitem.h
patching file libs/widgets/Makefile.am
patching file libs/Makefile.am
patching file utilities/cameragui/cameraui.cpp
[gilles@lserv3 digikam]$    

What news :

- Shorting automaticly Exif metadata groups by prefered photograph order :
"Photograph Informations" and "Image Inforlations" are always on the top of
the list (Request by Rainer)

- Using user friendly tags values (Request by Rainer and Paco - thanks to
Andreas)

- Tags descriptions is implemented. If you select a tag and you use What's
this menu, you will have a tooltip view appear. (thanks to Andreas)

- New button to copy to clipboard all current metadata.

- New button to print all current metadata.

- Any widget optimizations and bugfix.

There is a screenshot here :

http://digikam3rdparty.free.fr/Screenshots/digikam0.9.0-alpha7.png

TODO : trying to use user friendly tags name instead internal Exiv2 tags name.
Andreas, how i can do it (if it's possible) ?

All comments welcome...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Jeudi 2 Mars 2006 12:09, vous avez écrit :
> Gilles Caulier wrote:
> >Ok, we have improved the "tag values" output. Now, still the problem to do
> > an user friendly output of "tag names" like :
> >
> >DateTimeOriginal ==> Image timestamp.
>
> I missed that one out. Try Exiv2::ExifTags::tagTitle(), I think this is
> what you are looking for, although these labels may need tweaking.
> Suggestions welcome.

Ok. Implemented. work fine. Any tags title need to be improved. I will provide
a full list. My second diff patch have been updated...

>
> >In ExifWidget::decodeMetadata() my implementation is  :
> >
> >...
> >
> >for (Exiv2::ExifData::iterator md = exifData.begin(); md !=
> > exifData.end(); ++md)
> >        {
> >            QString key   = QString::fromLocal8Bit(md->key().c_str());
> >
> >            // Decode the tag value with a user friendly output.
> >            std::ostringstream os;
> >            os << *md;
> >            QString value = QString::fromLocal8Bit(os.str().c_str());
> >
> >            // We apply a filter to get only standard Exif tags, not maker
> >notes.
> >            if (stdExifFilter.contains(key.section(".", 1, 1)))
> >                metaDataMap.insert(key, value);
> >        }
> >
> >There is a way to make it automaticly using Exiv2 ?
>
> Not sure which part you'd like to have automated, but I can't see
> anything that Exiv2 could do for you here.
> If anything, I suggest to decode the value only inside the if, i.e.,
> only if you actually need it.

I will take a look.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Jeudi 2 Mars 2006 14:48, Gilles Caulier a écrit :
> TODO : trying to use user friendly tags name instead internal Exiv2 tags
> name. Andreas, how i can do it (if it's possible) ?

Done. The diff file have been update on free.fr space.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rainer Krienke-2]

Am Donnerstag, 2. März 2006 16:36 schrieb Gilles Caulier:
> Le Jeudi 2 Mars 2006 14:48, Gilles Caulier a écrit :
> > TODO : trying to use user friendly tags name instead internal Exiv2 tags
> > name. Andreas, how i can do it (if it's possible) ?
>
> Done. The diff file have been update on free.fr space.
>
> Gilles

Things have become much better now. It seems that at least for my Nikon some
Version strings are still not converted into an ascii representation:
ExifVersion
FlashPixVersion
InteroperabilityVersion

and in the Makernotes:
ColorBalance2
Version

These tags are still like "48 49 48 ..."

The rest is really fine. I can now get much more information about a photo
compared to the old exif support in digikam.

In the simple EXIF display I found at least for Nikon the Aperture value is
missing. This should be included in this view. I remember that Nikon is
special here. They encode this value non standard in the "Aperture" tag and
not in the  "Aperture Value" tag like other manufacturaers like Canon do.

Great work.

Thanks
Rainer

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Jeudi 2 Mars 2006 18:44, Rainer Krienke a écrit :

> Am Donnerstag, 2. März 2006 16:36 schrieb Gilles Caulier:
> > Le Jeudi 2 Mars 2006 14:48, Gilles Caulier a écrit :
> > > TODO : trying to use user friendly tags name instead internal Exiv2
> > > tags name. Andreas, how i can do it (if it's possible) ?
> >
> > Done. The diff file have been update on free.fr space.
> >
> > Gilles
>
> Things have become much better now. It seems that at least for my Nikon
> some Version strings are still not converted into an ascii representation:
> ExifVersion
> FlashPixVersion
> InteroperabilityVersion
>
> and in the Makernotes:
> ColorBalance2
> Version
>
> These tags are still like "48 49 48 ..."
>
> The rest is really fine. I can now get much more information about a photo
> compared to the old exif support in digikam.
>
> In the simple EXIF display I found at least for Nikon the Aperture value is
> missing. This should be included in this view. I remember that Nikon is
> special here. They encode this value non standard in the "Aperture" tag and
> not in the  "Aperture Value" tag like other manufacturaers like Canon do.

Well, this tag is certainly un-recognized in marker note area by Exiv2. I just
get the info from Exiv2. I don't parse anything in digiKam.

The better way is to report this problem to Exiv2 team.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rainer Krienke-2]

Am Donnerstag, 2. März 2006 20:37 schrieb Gilles Caulier:

> > In the simple EXIF display I found at least for Nikon the Aperture value
> > is missing. This should be included in this view. I remember that Nikon
> > is special here. They encode this value non standard in the "Aperture"
> > tag and not in the  "Aperture Value" tag like other manufacturaers like
> > Canon do.
>
> Well, this tag is certainly un-recognized in marker note area by Exiv2. I
> just get the info from Exiv2. I don't parse anything in digiKam.
>
> The better way is to report this problem to Exiv2 team.

Well the Tag is echoed if I simply call exiv2 on a Nikon camera photo:

$ exiv2 dsc_1376.jp
Filename        : dsc_1376.jpg
Filesize        : 1288537 Bytes
Camera make     : NIKON CORPORATION
Camera model    : NIKON D70
Image timestamp : 2006:03:02 19:33:37
Image number    :
Exposure time   : 1/1500 s
Aperture        : F4.8
Exposure bias   : +1/2
....

So the Tag Aperture is there. Its also shown in the "Full" EXIF view but there
its called FNumber (don't know why).  Or do I miss something? On what does
the difference depend what tags are shown in "Simple" and what are shown in
"Full"?  Is this a property of exiv2 or of digikam?

Thanks
Rainer

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Jeudi 02 Mars 2006 08:52 PM, Rainer Krienke a écrit :

> Am Donnerstag, 2. März 2006 20:37 schrieb Gilles Caulier:
> > > In the simple EXIF display I found at least for Nikon the Aperture
> > > value is missing. This should be included in this view. I remember that
> > > Nikon is special here. They encode this value non standard in the
> > > "Aperture" tag and not in the  "Aperture Value" tag like other
> > > manufacturaers like Canon do.
> >
> > Well, this tag is certainly un-recognized in marker note area by Exiv2. I
> > just get the info from Exiv2. I don't parse anything in digiKam.
> >
> > The better way is to report this problem to Exiv2 team.
>
> Well the Tag is echoed if I simply call exiv2 on a Nikon camera photo:
>
> $ exiv2 dsc_1376.jp
> Filename        : dsc_1376.jpg
> Filesize        : 1288537 Bytes
> Camera make     : NIKON CORPORATION
> Camera model    : NIKON D70
> Image timestamp : 2006:03:02 19:33:37
> Image number    :
> Exposure time   : 1/1500 s
> Aperture        : F4.8
> Exposure bias   : +1/2
> ....
>
> So the Tag Aperture is there. Its also shown in the "Full" EXIF view but
> there its called FNumber (don't know why).  Or do I miss something? On what
> does the difference depend what tags are shown in "Simple" and what are
> shown in "Full"?  Is this a property of exiv2 or of digikam?

There is no difference between Full and Simple mode. Any tags are just removed
from the list.

The tag title are transformed to a more user friendly string by Exiv2. I
suspect a problem into this transformation. I will investigate anymore.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel