[Digikam-devel] GPS Sync: 2 small bugs

[Fabien-5]

Hi,

I reported on B.K.o 2 small bugs about GPS Sync, but in kipiplugins
product, I hope it's ok :) (assigned by default to [hidden email]).

Here they are :
http://bugs.kde.org/show_bug.cgi?id=134747
http://bugs.kde.org/show_bug.cgi?id=134749

GPS features in digikam are becoming really great !
Thanks Gilles.

BTW, what is the best way to update GPS Sync plugin with svn ?
Do I have to recompile everything, just kipiplugins, just GPS Sync ?

Thanks.

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Wednesday 27 September 2006 16:18, Fabien wrote:
> Hi,
>
> I reported on B.K.o 2 small bugs about GPS Sync, but in kipiplugins
> product, I hope it's ok :) (assigned by default to [hidden email]).

fine.

>
> Here they are :
> http://bugs.kde.org/show_bug.cgi?id=134747

If you can give me a patch for this one, i will be happy.

I don't have a GPS device to test indeep here. It's a little bit complicated
to debug using all conditions.

> http://bugs.kde.org/show_bug.cgi?id=134749
>

For this one, i will take a look.

> GPS features in digikam are becoming really great !
> Thanks Gilles.
>
> BTW, what is the best way to update GPS Sync plugin with svn ?
> Do I have to recompile everything, just kipiplugins, just GPS Sync ?

You just need to re-compile and install only the plugin. That all.

Gilles

PS: fresh plugin screenshot :

http://digikam3rdparty.free.fr/Screenshots/newkipigpssyncplugin.png

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Wednesday 27 September 2006 16:25, Gilles Caulier(UNTRUSTED, sender is
<digikam-devel-bounces-+caulier.gilles=[hidden email]>) wrote:
> > http://bugs.kde.org/show_bug.cgi?id=134749
>
> For this one, i will take a look.

Fixed in svn...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Gilles Caulier wrote:
> On Wednesday 27 September 2006 16:18, Fabien wrote:
>
>>Here they are :
>>http://bugs.kde.org/show_bug.cgi?id=134747
>
> If you can give me a patch for this one, i will be happy.
>
> I don't have a GPS device to test indeep here. It's a little bit complicated
> to debug using all conditions.

Well, I don't know C++, so this is a really dirty patch :)
It's not optimum because the whole file is parsed before getting the
best value. But, it seems to work.
It should be possible to stop before by checking when the nbSecs is
increasing instead of decreasing (when trackpoint time > picture time),
but it would mean we assume trackpoints are time ordered (is it always
the case). And parsing seems to be very fast :)

To check the differences: before the patch, gpssync doesn't return the
same values if you change the max gap time.

I added a picture and gpx track file to test the sync.

Hope this helps !

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mercredi 27 Septembre 2006 16:25, Gilles Caulier(UNTRUSTED, sender is
<digikam-devel-bounces-+caulier.gilles=[hidden email]>) a écrit :
> > BTW, what is the best way to update GPS Sync plugin with svn ?
> > Do I have to recompile everything, just kipiplugins, just GPS Sync ?
>
> You just need to re-compile and install only the plugin. That all.

Oups ! Sorry : You need to compile all but only install the plugin.

In fact, we have a shared Exiv2 interface witch is outside the plugin. You
need to re-compile this one also !

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Caulier Gilles wrote:

> Le Mercredi 27 Septembre 2006 16:25, Gilles Caulier(UNTRUSTED, sender is
> <digikam-devel-bounces-+caulier.gilles@t±ëK&8w>) a écrit :
>
>>>BTW, what is the best way to update GPS Sync plugin with svn ?
>>>Do I have to recompile everything, just kipiplugins, just GPS Sync ?
>>
>>You just need to re-compile and install only the plugin. That all.
>
>
> Oups ! Sorry : You need to compile all but only install the plugin.
>
> In fact, we have a shared Exiv2 interface witch is outside the plugin. You
> need to re-compile this one also !

Ah, ok !
For my small changes (see dirty patch on
http://bugs.kde.org/show_bug.cgi?id=134747), I tested them just by
recompiling gpssync (make in gpssync directory) and it worked fine. But
I guess for other changes, I will have to do that.

Thanks a lot for this hint !

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel