Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From mikmach wp pl 2007-04-12 12:04 ------- > If you know a standard shorcut to toogle on 100% zoom factor, let's me > hear... GIMP uses 1 for 1:1 Shift-Ctrl-E dla 'fit to window' ---------------------------------------------------- Ka�dy ma jakie� tajemnice. Ale co by�by� w stanie zrobi�, by ukry� prawd�? Bruce Willis, Halle Berry w thrillerze KTO� CA�KIEM OBCY - w kinach od 13 kwietnia! http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fktos.html&sid=1099 _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by Alan Flisch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From caulier.gilles gmail com 2007-04-12 16:47 ------- SVN commit 653028 by cgilles: digiKam from trunk : new option to reset zoom factor to fit preview on window size. CCBUGS: 140131 M +5 -0 digikam/albumwidgetstack.cpp M +1 -0 digikam/albumwidgetstack.h M +13 -4 digikam/digikamapp.cpp M +6 -4 digikam/digikamappprivate.h M +1 -0 digikam/digikamui.rc M +8 -0 digikam/digikamview.cpp M +1 -0 digikam/digikamview.h M +9 -2 libs/widgets/common/previewwidget.cpp M +3 -2 libs/widgets/common/previewwidget.h --- trunk/extragear/graphics/digikam/digikam/albumwidgetstack.cpp #653027:653028 @ -217,6 +217,11 @ d->imagePreviewView->slotDecreaseZoom(); } +void AlbumWidgetStack::fitToWindow() +{ + d->imagePreviewView->fitToWindow(); +} + bool AlbumWidgetStack::maxZoom() { return d->imagePreviewView->maxZoom(); --- trunk/extragear/graphics/digikam/digikam/albumwidgetstack.h #653027:653028 @ -71,6 +71,7 @ void increaseZoom(); void decreaseZoom(); + void fitToWindow(); bool maxZoom(); bool minZoom(); void setZoomFactor(double z); --- trunk/extragear/graphics/digikam/digikam/digikamapp.cpp #653027:653028 @ -784,7 +784,7 @ // ----------------------------------------------------------- - d->thumbSizePlusAction = new KAction(i18n("Zoom in"), + d->zoomPlusAction = new KAction(i18n("Zoom in"), "viewmag+", CTRL+Key_Plus, d->view, @ -792,7 +792,7 @ actionCollection(), "album_zoomin"); - d->thumbSizeMinusAction = new KAction(i18n("Zoom out"), + d->zoomMinusAction = new KAction(i18n("Zoom out"), "viewmag-", CTRL+Key_Minus, d->view, @ -800,6 +800,14 @ actionCollection(), "album_zoomout"); + d->zoomFitToWindowAction = new KAction(i18n("Fit to &Window"), + "view_fit_window", + CTRL+SHIFT+Key_A, + d->view, + SLOT(slotFitToWindow()), + actionCollection(), + "album_zoomfit2window"); + #if KDE_IS_VERSION(3,2,0) d->fullScreenAction = KStdAction::fullScreen(this, SLOT(slotToggleFullScreen()), actionCollection(), this, "full_screen"); @ -950,13 +958,13 @ void DigikamApp::enableZoomPlusAction(bool val) { - d->thumbSizePlusAction->setEnabled(val); + d->zoomPlusAction->setEnabled(val); d->zoomPlusButton->setEnabled(val); } void DigikamApp::enableZoomMinusAction(bool val) { - d->thumbSizeMinusAction->setEnabled(val); + d->zoomMinusAction->setEnabled(val); d->zoomMinusButton->setEnabled(val); } @ -1865,6 +1873,7 @ // View menu d->albumSortAction->setEnabled(!t); d->imageSortAction->setEnabled(!t); + d->zoomFitToWindowAction->setEnabled(t); } } // namespace Digikam --- trunk/extragear/graphics/digikam/digikam/digikamappprivate.h #653027:653028 @ -100,8 +100,6 @ selectAllAction = 0; selectNoneAction = 0; selectInvertAction = 0; - thumbSizePlusAction = 0; - thumbSizeMinusAction = 0; fullScreenAction = 0; slideShowAction = 0; slideShowAllAction = 0; @ -134,6 +132,9 @ zoomTracker = 0; zoomMinusButton = 0; zoomPlusButton = 0; + zoomFitToWindowAction = 0; + zoomPlusAction = 0; + zoomMinusAction = 0; } bool fullScreen; @ -209,10 +210,11 @ KAction *slideShowAllAction; KAction *slideShowSelectionAction; KAction *slideShowRecursiveAction; - KAction *thumbSizePlusAction; - KAction *thumbSizeMinusAction; KSelectAction *imageSortAction; KSelectAction *albumSortAction; + KAction *zoomPlusAction; + KAction *zoomMinusAction; + KAction *zoomFitToWindowAction; KAction *rating0Star; KAction *rating1Star; --- trunk/extragear/graphics/digikam/digikam/digikamui.rc #653027:653028 @ -64,6 +64,7 @ <Separator/> <Action name="album_zoomin" /> <Action name="album_zoomout" /> + <Action name="album_zoomfit2window" /> <Separator /> <Action name="album_sort" /> <Action name="image_sort" /> --- trunk/extragear/graphics/digikam/digikam/digikamview.cpp #653027:653028 @ -817,6 +817,14 @ } } +void DigikamView::slotFitToWindow() +{ + if (d->albumWidgetStack->previewMode() == AlbumWidgetStack::PreviewImageMode) + { + d->albumWidgetStack->fitToWindow(); + } +} + void DigikamView::slotZoomFactorChanged(double zoom) { toogleZoomActions(); --- trunk/extragear/graphics/digikam/digikam/digikamview.h #653027:653028 @ -81,6 +81,7 @ // View Action slots void slotZoomIn(); void slotZoomOut(); + void slotFitToWindow(); void slotSlideShowAll(); void slotSlideShowSelection(); void slotSlideShowRecursive(); --- trunk/extragear/graphics/digikam/libs/widgets/common/previewwidget.cpp #653027:653028 @ -479,13 +479,20 @ return d->zoom; } -bool PreviewWidget::fitToWindow() +bool PreviewWidget::isFitToWindow() { return d->autoZoom; } -void PreviewWidget::toggleFitToWindow() +void PreviewWidget::fitToWindow() { + updateAutoZoom(); + updateContentsSize(); + viewport()->update(); +} + +void PreviewWidget::lockFitToWindow() +{ d->autoZoom = !d->autoZoom; if (d->autoZoom) --- trunk/extragear/graphics/digikam/libs/widgets/common/previewwidget.h #653027:653028 @ -50,8 +50,9 @ void setImage(const QImage& image); void setZoomFactor(double z); void setBackgroundColor(const QColor& color); - bool fitToWindow(); - void toggleFitToWindow(); + void fitToWindow(); + bool isFitToWindow(); + void lockFitToWindow(); bool maxZoom(); bool minZoom(); _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by Alan Flisch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From caulier.gilles gmail com 2007-04-12 16:52 ------- SVN commit 653032 by cgilles: digiKam from trunk : Zoom In/Out buttons are now in statusbar, around the zoom slider. CCBUGS: 140131 M +1 -1 previewwidget.cpp M +1 -1 previewwidget.h --- trunk/extragear/graphics/digikam/libs/widgets/common/previewwidget.cpp #653031:653032 @ -491,7 +491,7 @ viewport()->update(); } -void PreviewWidget::lockFitToWindow() +void PreviewWidget::toggleFitToWindow() { d->autoZoom = !d->autoZoom; --- trunk/extragear/graphics/digikam/libs/widgets/common/previewwidget.h #653031:653032 @ -52,7 +52,7 @ void setBackgroundColor(const QColor& color); void fitToWindow(); bool isFitToWindow(); - void lockFitToWindow(); + void toggleFitToWindow(); bool maxZoom(); bool minZoom(); _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by Alan Flisch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From fabien.ubuntu gmail com 2007-04-12 17:21 ------- Hi Gilles, I just compiled and tried it. That's great. Just some comments : - like somebody said earlier (can't find it anymore), Ctrl+Mousewheel-UP is usually affected to zoom in and Mousewheel-Down to zoom out (it's the case in gwenview, gqview) - Ctrl+Shif+A for "fit to window" is not very convenient to use and to remember. Somebody said 1 is used in gimp to zoom 100%. It also works in gqview. Here's my proposal : 0 for "fit to window" 1 for 100% 2 for 200% 3 for 300% etc. - I have a bug (at least on my computer) about the zoom value. For a 5MP picture, fit to window gives me "115%". If I go to 100%, it's not the right size (should be bigger than my 17" screen :) ). _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by Alan Flisch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From mikmach wp pl 2007-04-12 19:18 ------- > - Ctrl+Shif+A for "fit to window" is not very convenient to use and to > remember. Somebody said 1 is used in gimp to zoom 100%. It also works in > gqview. Here's my proposal : > 0 for "fit to window" > 1 for 100% > 2 for 200% > 3 for 300% Since we are working on bitmaps there is little use for 200% or 300% shortcuts. Fit to window and 1:1 shortcuts are necessary but the rest... IMO no. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by Alan Flisch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From caulier.gilles gmail com 2007-04-12 22:43 ------- SVN commit 653197 by cgilles: digiKam from trunk : new action to set zoom factor to 100% in Preview mode. CCBUGS: 140131 M +5 -0 albumwidgetstack.cpp M +1 -0 albumwidgetstack.h M +9 -0 digikamapp.cpp M +2 -0 digikamappprivate.h M +2 -1 digikamui.rc M +8 -0 digikamview.cpp M +1 -0 digikamview.h --- trunk/extragear/graphics/digikam/digikam/albumwidgetstack.cpp #653196:653197 @ -217,6 +217,11 @ d->imagePreviewView->slotDecreaseZoom(); } +void AlbumWidgetStack::zoomTo100Percents() +{ + d->imagePreviewView->setZoomFactor(1.0); +} + void AlbumWidgetStack::fitToWindow() { d->imagePreviewView->fitToWindow(); --- trunk/extragear/graphics/digikam/digikam/albumwidgetstack.h #653196:653197 @ -72,6 +72,7 @ void increaseZoom(); void decreaseZoom(); void fitToWindow(); + void zoomTo100Percents(); bool maxZoom(); bool minZoom(); void setZoomFactor(double z); --- trunk/extragear/graphics/digikam/digikam/digikamapp.cpp #653196:653197 @ -800,6 +800,14 @ actionCollection(), "album_zoomout"); + d->zoomTo100percents = new KAction(i18n("Zoom to 1:1"), + "viewmag1", + CTRL+SHIFT+Key_Z, + d->view, + SLOT(slotZoomTo100Percents()), + actionCollection(), + "album_zoomto100percents"); + d->zoomFitToWindowAction = new KAction(i18n("Fit to &Window"), "view_fit_window", CTRL+SHIFT+Key_A, @ -1873,6 +1881,7 @ // View menu d->albumSortAction->setEnabled(!t); d->imageSortAction->setEnabled(!t); + d->zoomTo100percents->setEnabled(t); d->zoomFitToWindowAction->setEnabled(t); } --- trunk/extragear/graphics/digikam/digikam/digikamappprivate.h #653196:653197 @ -132,6 +132,7 @ zoomTracker = 0; zoomMinusButton = 0; zoomPlusButton = 0; + zoomTo100percents = 0; zoomFitToWindowAction = 0; zoomPlusAction = 0; zoomMinusAction = 0; @ -215,6 +216,7 @ KAction *zoomPlusAction; KAction *zoomMinusAction; KAction *zoomFitToWindowAction; + KAction *zoomTo100percents; KAction *rating0Star; KAction *rating1Star; --- trunk/extragear/graphics/digikam/digikam/digikamui.rc #653196:653197 @ -1,5 +1,5 @ <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd"> -<kpartgui version="24" name="digikam" > +<kpartgui version="25" name="digikam" > <MenuBar> @ -64,6 +64,7 @ <Separator/> <Action name="album_zoomin" /> <Action name="album_zoomout" /> + <Action name="album_zoomto100percents" /> <Action name="album_zoomfit2window" /> <Separator /> <Action name="album_sort" /> --- trunk/extragear/graphics/digikam/digikam/digikamview.cpp #653196:653197 @ -817,6 +817,14 @ } } +void DigikamView::slotZoomTo100Percents() +{ + if (d->albumWidgetStack->previewMode() == AlbumWidgetStack::PreviewImageMode) + { + d->albumWidgetStack->zoomTo100Percents(); + } +} + void DigikamView::slotFitToWindow() { if (d->albumWidgetStack->previewMode() == AlbumWidgetStack::PreviewImageMode) --- trunk/extragear/graphics/digikam/digikam/digikamview.h #653196:653197 @ -81,6 +81,7 @ // View Action slots void slotZoomIn(); void slotZoomOut(); + void slotZoomTo100Percents(); void slotFitToWindow(); void slotSlideShowAll(); void slotSlideShowSelection(); _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
The new Zoom to 1:1 and fit to window are very nice!
The 1:1 zoom, however, makes me think that the image shown in the middle of the light-table is a reduced version of the original, i.e. a 3456 x 2304 image does almost fit on a 1024x768 screen. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by Alan Flisch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From arnd.baecker web de 2007-04-13 00:31 ------- The new Zoom to 1:1 and fit to window are very nice! The 1:1 zoom, however, makes me think that the image shown in the middle of the light-table is a reduced version of the original, i.e. a 3456 x 2304 image does almost fit on a 1024x768 screen. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by Alan Flisch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From caulier.gilles gmail com 2007-04-13 06:26 ------- >The 1:1 zoom, however, makes me think that >the image shown in the middle of the light-table >is a reduced version of the original, i.e. a 3456 x 2304 >image does almost fit on a 1024x768 screen. yes, it is... For performance reason, a Preview is not the full image. this is why the zoom factor value is a non sence to be show with Preview. Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by Alan Flisch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=140131 ------- Additional Comments From arnd.baecker web de 2007-04-13 08:37 ------- Sorry, I wanted to post this remark in this thread http://bugs.kde.org/show_bug.cgi?id=135048 about the light-table. (maybe Frank's idea, see #16 above, would be the solution in both cases?) _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Disable Popup Ads | Edit this page |