[Digikam-devel] [Bug 136855] New: Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

classic Classic list List threaded Threaded
71 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Gilles Caulier-2
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From caulier.gilles kdemail net  2006-11-06 07:55 -------
Caspar,

Other questions :

- Witch CPU type you use : Pentium, Pentium with HyperThreading, Pentium M, AMD, PPC, etc...
- Witch gcc release you use ?
- Witch libc release you use ?
- Are you used the ./configure --enable-debug=full to compile digiKam & kipi-plugins ?
- Are you used some optimizations options with ./configure script to compile digiKam & kipi-plugins ?

Thanks in advance

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

F.J.Cruz
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From fj.cruz supercable es  2006-11-06 08:29 -------
>----Mensaje original----
>De: caulier.gilles kdemail net
>Fecha: 06/11/2006 7:52
>Para: <digikam-devel kde org>
>Asunto: [Digikam-devel] [Bug 136855] Editing metadata on a few

selected imagefiles and clicking forward or apply crashes digikam.
[bugs.kde.org quoted mail]
06 07:52 -------

>Paco,
>
>Can you test using last stable Exiv2 0.11 like Caspar does ?
>
>Unforget to uninstall old Exiv2 from your computer before.
>
>Thanks in advance
>
>Gilles
>_______________________________________________


Sure Gilles, I'll try it later, when I arrive at home.

Paco Cruz.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Bugzilla from cmaessen@casco.demon.nl
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From cmaessen casco demon nl  2006-11-06 11:08 -------
Op maandag 6 november 2006 07:55, schreef Gilles Caulier:
  > - Witch CPU type you use : Pentium, Pentium with HyperThreading,
  > Pentium M, AMD, PPC, etc...

Intel Pentium 4
Linux 2.6.16.21-0.25-smp i686
SUSE LINUX 10.1 (i586)
KDE 3.5.5 "release 19.1"
  > - Witch gcc release you use ?

caspar casco:~> rpm -qa | grep gcc
libgcc-4.1.0-25
gcc-4.1.0-25
gcc-c++-4.1.0-25
  > - Witch libc release you use ?

caspar casco:~> rpm -qa | grep glibc
glibc-devel-2.4-31.1
glibc-2.4-31.1
  > - Are you used the ./configure --enable-debug=full to compile

Yes
  > digiKam & kipi-plugins ? - Are you used some optimizations options
  > with ./configure script to compile digiKam & kipi-plugins ?

No

I hope this is the information you are looking for.

Caspar.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

F.J.Cruz
In reply to this post by F.J.Cruz
El Lunes, 6 de Noviembre de 2006 08:29, F.J.Cruz escribió:

> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=136855
>
>
>
>
> ------- Additional Comments From fj.cruz supercable es  2006-11-06 08:29
> -------
>
> >----Mensaje original----
> >De: caulier.gilles kdemail net
> >Fecha: 06/11/2006 7:52
> >Para: <digikam-devel kde org>
> >Asunto: [Digikam-devel] [Bug 136855] Editing metadata on a few
>
> selected imagefiles and clicking forward or apply crashes digikam.
> [bugs.kde.org quoted mail]
> 06 07:52 -------
>
> >Paco,
> >
> >Can you test using last stable Exiv2 0.11 like Caspar does ?
> >
> >Unforget to uninstall old Exiv2 from your computer before.
> >
> >Thanks in advance
> >
> >Gilles
> >_______________________________________________
>
> Sure Gilles, I'll try it later, when I arrive at home.
>
> Paco Cruz.
> _______________________________________________
> Digikam-devel mailing list

Well, Exiv2 0.11 compiled and installed. Digikam works ok with the sample
images: I'm not able to reproduce this crash.

Paco Cruz.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

F.J.Cruz
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From fj.cruz supercable es  2006-11-06 23:01 -------
El Lunes, 6 de Noviembre de 2006 08:29, F.J.Cruz escribi�:
[bugs.kde.org quoted mail]

Well, Exiv2 0.11 compiled and installed. Digikam works ok with the sample
images: I'm not able to reproduce this crash.

Paco Cruz.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Bugzilla from mikmach@wp.pl
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From mikmach wp pl  2006-11-06 23:30 -------
I can confirm that for Digikam 601741 and clean install of Exiv2 0.11
Backtrace is very limited (I understand it is E2 taking down Digikam).

Way of reproduce isn't always the same. But generally: select few
images, edit caption and move between images, forward, backward, change
caption, move, etc. And after few iterations D. will crash.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Bugzilla from mikmach@wp.pl
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From mikmach wp pl  2006-11-07 00:22 -------
Also happens with Exiv2 from svn 943.

Using host libthread_db library "/lib/tls/libthread_db.so.1".
`shared object read from target memory' has disappeared; keeping its
symbols.
[Thread debugging using libthread_db enabled]
[New Thread -1240250048 (LWP 494)]
[KCrash handler]
#5  0xb619ccb5 in free () from /lib/tls/libc.so.6
#6  0xb619e6ef in malloc () from /lib/tls/libc.so.6
#7  0xb6346e57 in operator new () from /usr/lib/libstdc++.so.6
#8  0xb6346f7d in operator new[] () from /usr/lib/libstdc++.so.6
#9  0xb796f607 in Ifd (this=0xbf96cda0, ifdId=9599049) at ifd.cpp:271
#10 0xb79619c9 in Exiv2::ExifData::copyFromMetadata (this=0x8656444)
    at exif.cpp:631
#11 0xb7962410 in Exiv2::ExifData::copy (this=0x8656444) at exif.cpp:623
#12 0xb797977c in Exiv2::JpegBase::doWriteMetadata (this=0x8656438,
    outIo= 0x86d9ac0) at jpgimage.cpp:482
#13 0xb797a144 in Exiv2::JpegBase::writeMetadata (this=0x8656438)
    at jpgimage.cpp:360
#14 0xb4e8418a in KIPIPlugins::Exiv2Iface::save (this=0xbf96cff8,
    filePath= 0xbf96d000) at exiv2iface.cpp:304
#15 0xb4e5dfee in KIPIMetadataEditPlugin::IPTCEditDialog::slotApply (
    this=0xbf96d854) at iptceditdialog.cpp:301
#16 0xb733da8c in KDialogBase::qt_invoke ()
   from /usr/local/kde/lib/libkdeui.so.4
#17 0xb4e5ec52 in KIPIMetadataEditPlugin::IPTCEditDialog::qt_invoke (
    this=0xbf96d854, _id=75, _o=0xbf96d0dc) at iptceditdialog.moc:105
#18 0xb69e81bf in QObject::activate_signal ()
   from /usr/lib/qt3/lib/libqt-mt.so.3
#19 0x086380d0 in ?? ()
#20 0xbf96d094 in ?? ()
#21 0x00000000 in ?? ()
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Bugzilla from ahuggel@gmx.net
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From ahuggel gmx net  2006-11-07 03:01 -------
Exiv2 from svn 943 does not address this problem.

This one looks like one of these mysterious memory mgmt related issues.

Can someone who can reproduce this and understands digikam's thread and memory mgmt model well debug this one further, please, with an eye on the memory related issues (where does the memory get free'd for the 1st time, if it's freed twice? etc.)

To pinpoint any related exiv2 issue, it would of course be best to have a small reproducer program which just calls exiv2.

Thanks.
-ahu.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Geoff King-2
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From gsking1 yahoo com  2006-11-07 04:07 -------
I'm experiencing this also for the last couple days from svn.  This worked up until a few days ago when the menu options changed for Metadata and provided the 4 options. To recreate: select photo, choose metadata, edit iptc, change caption or other field, apply (should crash).  may also take a few more tries or click okay or arrow buttons.  This Wipes out all exif and iptc data in file in addition to the crash.

for example:
exiv2 pr -p s Photo_103106_003.jpg
Photo_103106_003.jpg: No Exif data found in the file

Using Ubuntu Edgy
Both Libs (first) and Graphics (second) are compiled with ./configure --enable-debug=full
P4 with Hyperthreading
gcc (GCC) 4.1.2 20060928 (prerelease) (Ubuntu 4.1.1-13ubuntu5)
using exiv2 0.11 compiled from source

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1241032400 (LWP 14218)]
0xb6115c64 in free () from /lib/tls/i686/cmov/libc.so.6
(gdb)
(gdb) bt
#0  0xb6115c64 in free () from /lib/tls/i686/cmov/libc.so.6
#1  0xb611783f in malloc () from /lib/tls/i686/cmov/libc.so.6
#2  0xb62bc4b7 in operator new () from /usr/lib/libstdc++.so.6
#3  0xb62bc5ed in operator new[] () from /usr/lib/libstdc++.so.6
#4  0xb794b4cf in Entry (this=0x86394b8, rhs= 0xbfa1e33c) at ifd.cpp:79
#5  0xb79290ac in std::vector<Exiv2::Entry, std::allocator<Exiv2::Entry> >::_M_insert_aux (this=0xbfa1e504, __position={_M_current = 0x0},
    __x= 0xbfa1e33c) at /usr/lib/gcc/i486-linux-gnu/4.1.2/../../../../include/c++/4.1.2/ext/new_allocator.h:104
#6  0xb794ba15 in Exiv2::Ifd::add (this=0x85f77e8, entry= 0xb61e0160)
    at /usr/lib/gcc/i486-linux-gnu/4.1.2/../../../../include/c++/4.1.2/bits/stl_vector.h:610
#7  0xb793d989 in Exiv2::addToIfd (ifd= 0xbfa1e500, md= 0x8679578, byteOrder=Exiv2::littleEndian) at exif.cpp:1204
#8  0xb793dad3 in Exiv2::addToIfd (ifd= 0xbfa1e500, begin={_M_current = 0x8679578}, end={_M_current = 0x8679d1c}, byteOrder=Exiv2::littleEndian)
    at exif.cpp:1181
#9  0xb793db3f in Exiv2::ExifData::copyFromMetadata (this=0x863e9e4) at exif.cpp:632
#10 0xb793e574 in Exiv2::ExifData::copy (this=0x863e9e4) at exif.cpp:623
#11 0xb7956a1a in Exiv2::JpegBase::doWriteMetadata (this=0x863e9d8, outIo= 0x8639498) at jpgimage.cpp:482
#12 0xb795757e in Exiv2::JpegBase::writeMetadata (this=0x863e9d8) at jpgimage.cpp:360
#13 0xb45226d8 in KIPIPlugins::Exiv2Iface::save (this=0xbfa1e798, filePath= 0xbfa1e7a0) at exiv2iface.cpp:304
#14 0xb44f3753 in KIPIMetadataEditPlugin::IPTCEditDialog::slotApply (this=0xbfa1f254) at iptceditdialog.cpp:301
#15 0xb7354223 in KDialogBase::qt_invoke () from /usr/lib/libkdeui.so.4
#16 0xb44f6094 in KIPIMetadataEditPlugin::IPTCEditDialog::qt_invoke (this=0xbfa1f254, _id=75, _o=0xbfa1e88c) at iptceditdialog.moc:105
#17 0xb6938a84 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#18 0xb69393fc in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#19 0xb6ccdf5f in QButton::clicked () from /usr/lib/libqt-mt.so.3
#20 0xb69d6fe8 in QButton::mouseReleaseEvent () from /usr/lib/libqt-mt.so.3
#21 0xb696f729 in QWidget::event () from /usr/lib/libqt-mt.so.3
#22 0xb68cfb88 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#23 0xb68d1d46 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#24 0xb7095db2 in KApplication::notify () from /usr/lib/libkdecore.so.4
#25 0xb68623fd in QApplication::sendSpontaneousEvent () from /usr/lib/libqt-mt.so.3
#26 0xb6861062 in QETWidget::translateMouseEvent () from /usr/lib/libqt-mt.so.3
#27 0xb685f14c in QApplication::x11ProcessEvent () from /usr/lib/libqt-mt.so.3
#28 0xb6876320 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#29 0xb68ea25e in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#30 0xb68d16af in QApplication::enter_loop () from /usr/lib/libqt-mt.so.3
#31 0xb6aed4a1 in QDialog::exec () from /usr/lib/libqt-mt.so.3
#32 0xb44d59e7 in Plugin_MetadataEdit::slotEditIptc (this=0x8368940) at plugin_metadataedit.cpp:188
#33 0xb44d6b26 in Plugin_MetadataEdit::qt_invoke (this=0x8368940, _id=4, _o=0xbfa1f3dc) at plugin_metadataedit.moc:90
#34 0xb6938957 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#35 0xb69393fc in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#36 0xb72773b9 in KAction::activated () from /usr/lib/libkdeui.so.4
#37 0xb72b4c02 in KAction::slotActivated () from /usr/lib/libkdeui.so.4
#38 0xb737d29d in KAction::slotPopupActivated () from /usr/lib/libkdeui.so.4
#39 0xb737d561 in KAction::qt_invoke () from /usr/lib/libkdeui.so.4
#40 0xb6938957 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#41 0xb6cc4f44 in QSignal::signal () from /usr/lib/libqt-mt.so.3
#42 0xb69588ea in QSignal::activate () from /usr/lib/libqt-mt.so.3
#43 0xb6a5efd3 in QPopupMenu::mouseReleaseEvent () from /usr/lib/libqt-mt.so.3
#44 0xb72803ce in KPopupMenu::mouseReleaseEvent () from /usr/lib/libkdeui.so.4
#45 0xb696f729 in QWidget::event () from /usr/lib/libqt-mt.so.3
#46 0xb68cfb88 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#47 0xb68d1d46 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#48 0xb7095db2 in KApplication::notify () from /usr/lib/libkdecore.so.4
#49 0xb68623fd in QApplication::sendSpontaneousEvent () from /usr/lib/libqt-mt.so.3
#50 0xb6860d3f in QETWidget::translateMouseEvent () from /usr/lib/libqt-mt.so.3
---Type <return> to continue, or q <return> to quit---    
#51 0xb685f14c in QApplication::x11ProcessEvent () from /usr/lib/libqt-mt.so.3
#52 0xb6876320 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#53 0xb68ea25e in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#54 0xb68ea06e in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#55 0xb68d1731 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#56 0x0804ab6c in main (argc=-1208541364, argv=0xbfa201e4) at main.cpp:269
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Gilles Caulier-2
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From caulier.gilles kdemail net  2006-11-07 08:00 -------
Someone can give a valgrind backtrace to check memory leak like this :

valgrind --tool=memcheck --leak-check=full --error-limit=no digikam

Of course, to have a full report in the console, Exiv2, digiKam and kipi-plugins need to be compiled with full debug option.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Gilles Caulier-2
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From caulier.gilles kdemail net  2006-11-07 08:06 -------
Andreas,

Look like my Exiv2 wrapper used by the MetadataEdit kipi-plugin is simple in fact :

http://websvn.kde.org/trunk/extragear/libs/kipi-plugins/common/exiv2iface/exiv2iface.cpp?rev=600798&view=auto
http://websvn.kde.org/trunk/extragear/libs/kipi-plugins/common/exiv2iface/exiv2iface.h?rev=600788&view=auto

If you see somthing wronf, lets me hear...

Note : the current implementation of Exiv2Iface class is a copy of DigiKam::DMetadata class. Later, I have planed to do a new shared "libKExiv2" library as well, to remplace the current implementation in digiKam core and kipi-plugins common area. Like this we will remove duplicated code.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Gilles Caulier-2
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From caulier.gilles kdemail net  2006-11-07 18:24 -------
Andreas,

Perhaps a simple test program is to do a simple loop witch use Exiv2 command line tool and read metadata around a group of JPEG files.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Geoff King-2
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From gsking1 yahoo com  2006-11-08 03:13 -------
Created an attachment (id=18466)
 --> (http://bugs.kde.org/attachment.cgi?id=18466&action=view)
valgrind backtrace text

I hope the attached valgrind backtrace helps.  I'm not sure how much you
need...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Gilles Caulier-2
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From caulier.gilles kdemail net  2006-11-08 08:04 -------
Very good Geof. Thanks you...

Andreas, look like the valgrind report is very instructive...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Bugzilla from ahuggel@gmx.net
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From ahuggel gmx net  2006-11-08 08:29 -------
Yes, looks good - or bad, depending on the viewpoint. Thanks.

I'm going to write a test driver for the Exiv2Iface class now, which I can feed with a series of images. I'd like it to do something similar to what Geoff did manually.

So, Geoff, what actions did you do in detail (just what you described in #26?)

Gilles, what series of calls to the interface does that translate to?

-ahu.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Gilles Caulier-2
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From caulier.gilles kdemail net  2006-11-08 09:34 -------
Andreas,

When i said "good", i want mean "instructive" in fact (:=)))...

About the methods used in Exiv2iface from the MetadataEdit kipi-plugin, it's very simple. look the code from the slots used when we want save the changes in pictures metadata :

In Exif editor dialog, we have :

void EXIFEditDialog::slotApply()
{
    if (d->modified && !d->isReadOnly)
    {
        d->captionPage->applyMetadata(d->exifData);
        ...
        KIPIPlugins::Exiv2Iface exiv2Iface;
        exiv2Iface.load((*d->currItem).path());
        exiv2Iface.setExif(d->exifData);
        exiv2Iface.save((*d->currItem).path());
        d->modified = false;
    }
}

d->modified and d->isReadOnly are just boolean variables. d->exifData is a bytearray to store metadata.

The IPTC code is similar than Exif :

void IPTCEditDialog::slotApply()
{
    if (d->modified && !d->isReadOnly)
    {
        d->captionPage->applyMetadata(d->iptcData);
        ...
        KIPIPlugins::Exiv2Iface exiv2Iface;
        exiv2Iface.load((*d->currItem).path());
        exiv2Iface.setExif(d->iptcData);
        exiv2Iface.save((*d->currItem).path());
        d->modified = false;
    }
}

About to load metadata from pictures when user change current selected one to edit in MetadataEdit plugin, we have another slots for Exif :

void EXIFEditDialog::slotItemChanged()
{
    KIPIPlugins::Exiv2Iface exiv2Iface;
    exiv2Iface.load((*d->currItem).path());
    d->exifData = exiv2Iface.getExif();
    d->captionPage->readMetadata(d->exifData);
    ...
    d->isReadOnly = KIPIPlugins::Exiv2Iface::isReadOnly((*d->currItem).path());
    ...
}

... and for IPTC :

void IPTCEditDialog::slotItemChanged()
{
    KIPIPlugins::Exiv2Iface exiv2Iface;
    exiv2Iface.load((*d->currItem).path());
    d->iptcData = exiv2Iface.getIptc();
    d->captionPage->readMetadata(d->iptcData);
    ...
    d->isReadOnly = KIPIPlugins::Exiv2Iface::isReadOnly((*d->currItem).path());
    ...
}

The slotItemChanged() and slotApply() call the dialog page methods to get or set the matadata values on the Exif/IPTC bytearray. this is the readMetadata() and applyMetadata() methods. These one use too another instances of KIPIPlugins::Exiv2Iface class to use others methods relevant of tags manipulations. For example, in Exif Captions editor page, we have :

void EXIFCaption::readMetadata(QByteArray& exifData)
{
    ...
    KIPIPlugins::Exiv2Iface exiv2Iface;
    exiv2Iface.setExif(exifData);
    QString data;

    data = exiv2Iface.getExifTagString("Exif.Image.DocumentName", false);    
    ...
}

void EXIFCaption::applyMetadata(QByteArray& exifData)
{
    KIPIPlugins::Exiv2Iface exiv2Iface;
    exiv2Iface.setExif(exifData);

    if (d->documentNameCheck->isChecked())
        exiv2Iface.setExifTagString("Exif.Image.DocumentName", d->documentNameEdit->text());
    else
        exiv2Iface.removeExifTag("Exif.Image.DocumentName");
    ...
}

The both class instance are independant and there is no memory conflict here (checked with valgrind). Exiv2Iface do not use static member.

Other important note : this plugin do not use multithreading like in digiKam core. The crash is not relevant of an unthread-safe problem.

You can read all current plugin source code here :

http://websvn.kde.org/trunk/extragear/libs/kipi-plugins/metadataedit

and the Exiv2Iface class here :

http://websvn.kde.org/trunk/extragear/libs/kipi-plugins/common/exiv2iface

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Bugzilla from ahuggel@gmx.net
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From ahuggel gmx net  2006-11-08 16:57 -------
Created an attachment (id=18470)
 --> (http://bugs.kde.org/attachment.cgi?id=18470&action=view)
Exiv2Iface test-driver

Yup, with the attached test program, run with the *.jpg files from the exiv2
test/data directory, I can recreate the problem here, finally. I'm posting this
first as I won't have time to figure out the rest before next week.

-ahu.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Bugzilla from ahuggel@gmx.net
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From ahuggel gmx net  2006-11-08 16:59 -------
Created an attachment (id=18471)
 --> (http://bugs.kde.org/attachment.cgi?id=18471&action=view)
Simple Makefile for the Exiv2Iface test-driver
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Geoff King-2
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From gsking1 yahoo com  2006-11-08 22:24 -------
Glad you can recreate this now.

>>So, Geoff, what actions did you do in detail (just what you described in #26?)

The #26 describes it.  For this particular case I'm not sure exactly which iptc field was changed, but it was probably a few text fields including caption.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 136855] Editing metadata on a few selected imagefiles and clicking forward or apply crashes digikam.

Bugzilla from ahuggel@gmx.net
In reply to this post by Bugzilla from cmaessen@casco.demon.nl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136855         




------- Additional Comments From ahuggel gmx net  2006-11-16 12:29 -------
Exiv2 SVN rev. 979 fixes the issues reproduceable with the test-driver.

Those who could recreate this bug before, please try with the latest Exiv2 version from SVN and let us know if it still occurs. Thanks!

-ahu.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
1234