[Digikam-devel] [Bug 133026] New: crashes on systems using hyperthreading

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From anaselli linux it  2006-11-24 10:00 -------
is QDebug thread safe?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From caulier.gilles kdemail net  2006-11-24 10:08 -------
Angelo,

qDebug() statement are used in Qt doc with QThread example. It must be thread-safe.

But the syntax is more like printf(), not really C++ like kdDebug().

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From anaselli linux it  2006-11-24 10:24 -------
> qDebug() statement are used in Qt doc with QThread example. It must be thread-safe.

Right, I should read docs first, next time ;)
 
> But the syntax is more like printf(), not really C++ like kdDebug().

That could be a problem, anyway. How can you be sure all the kipi's developer
will use qDebug instead of kdDebug?

I do believe kdDebug developers should be aware of the problem and provide
a thread safe solution, if the attached patches could be useful for them they could
use those ones, IMO.

Another possible way could be having a "stringstream" for any threads in a map by thread id
and sinchronize the access to the output every time an eot/eol/eof is coming
(overload of overflow method). But I didn't think a lot to a real solution though...

Angelo
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From caulier.gilles kdemail net  2006-11-24 10:36 -------
Angelo,

Only plugins using multi-threading implementation (QThread) with kdDebug() statements need to be fixed. All others parts can still use kdDebug() without problems.

QThread is used in these kipi plugins :

- RAW converter (I will fix it.).
- Send Images (I have posted comments to new maintener about it).
- JPEG LossLess (I will fix it.).
- Find Images (???).
- Kamera Klient (???).

About KDEAPI, i'm agree with you than kdDebug() implementation need to be fix. But we cannot wit this fix to release digiKAm/DigikamImagePlugins/kipi-plugins... Also this want mean than we will depand of a future KDE version...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From anaselli linux it  2006-11-24 11:53 -------
> About KDEAPI, i'm agree with you than kdDebug() implementation need to be fix. But we cannot wit this fix to release digiKAm/DigikamImagePlugins/kipi-plugins... Also this want mean than we will depand of a future KDE version...


hmm, an important fix like that, should be backported in all the kde version supported
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From caulier.gilles kdemail net  2006-11-24 11:57 -------
Right Angelo,

But who contact for that ? Aaron Seigo ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From anaselli linux it  2006-11-24 12:24 -------
> But who contact for that ? Aaron Seigo ?

Open a new bug to kdecore and let this bug depending on it?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From caulier.gilles kdemail net  2006-11-24 18:32 -------
or just CC Aaron in this file...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From caulier.gilles kdemail net  2007-01-27 13:40 -------
SVN commit 627622 by cgilles:

kipi-plugins from trunk : libkexiv2 : do not use kdDebug() here because it's not thread-safe. Use qDebug() instead...

CCBUGS: 133026



 M  +63 -139   libkexiv2.cpp  
 M  +1 -1      libkexiv2_export.h
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From faure kde org  2008-06-03 12:11 -------
SVN commit 816106 by dfaure:

kDebug concurrency testing, based on code from bug 133026, by Marcel Wiesweg <marcel.wiesweg gmx de>
No problem in KDE4 (kDebug uses qDebug, and includes a mutex for protecting its own data).
CCBUG: 133026
CCMAIL: "Gilles Caulier" <caulier.gilles gmail com>


 M  +70 -4     kdebugtest.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=816106
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From caulier.gilles gmail com  2008-06-03 12:17 -------
Thanks David.

Marcel, This is want mean than we can use KDE4::kDebug() everywhere...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133026         




------- Additional Comments From anaselli linux it  2008-06-03 12:47 -------
\o/
Does that mean it is not deprecated any more?

Angelo
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel