[Digikam-devel] [Bug 132244] New: Special Chars in Keywords decode wrong in IPTC

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From caulier.gilles kdemail net  2007-01-19 14:13 -------
>Digikam could learn quite a few things from BP, such as the wonderfull "fill >flash" feature, which brightens underexposed photos better than any other >program I've yet seen.

Already implemented in current implementation :

http://digikam3rdparty.free.fr/Screenshots/exposureindicatorsfromimageplugins.png
http://digikam3rdparty.free.fr/Screenshots/underexposureindicator.png
http://digikam3rdparty.free.fr/Screenshots/overerexposureindicator.png
http://digikam3rdparty.free.fr/Screenshots/exposureindicatorSetup.png

>The red-eye reduction selector is ROUND, like EYES, so they affect less skin.

The red eyes corrector need to be improved in digiKam ==> in my TODO list.

>Why does no other program do that? Should I continue to list BP's other great
>features?

yes, on devel ML, not in this room.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dotan Cohen-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From kde dotancohen com  2007-01-19 17:15 -------
I don't have those options in my 0.9.0 built from the tarball. I'll build from SVN and try it out. As for the BP features, I'll subscribe to the Digikam DevML. Thanks.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From caulier.gilles kdemail net  2007-01-22 07:53 -------
Dotan,

With #14, Are you sure than your attached picture is in UTF8. If digikam failed to show UTF8 char from IPTC, Why i can show it without problem in digiKam...

Also, the "envelope" IPTC tags is not set in this picture to ping application about char encoding...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From caulier.gilles kdemail net  2007-01-22 08:00 -------
Dotan,

With the image from #13 all char are broken. Sure this one is certainly encoded using UTF-8... but the "envelope" IPTC tag is not set. There is no way to find witch encoding is used in IPTC to decode text from this picture.

I have tried to show all IPTC informations from this picture using Photoshop 7.x, and all text strings are broken like digiKam !

If you read the IPTC Spec. this "Envelope" IPTC tag must be set properlly, else all text tags are unsuitable. I suspect a bug in BrillantPhoto.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From caulier.gilles kdemail net  2007-01-22 08:04 -------
Created an attachment (id=19374)
 --> (http://bugs.kde.org/attachment.cgi?id=19374&action=view)
IPTC and UTF8 from BrillantPhoto displayed in digiKam and Photoshop
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dotan Cohen-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From kde dotancohen com  2007-01-22 10:50 -------
It would not surprise me to learn of a bug of the sort in BrilliantPhoto. In any case, the program is abandonware (not being developed by those who purchased the rights to it), so the issue is mute.

I'm certain that a simple shell script could add the appropriate fields, should anybody need it. I'm not the guy to write it, though.

(Trivia: What movie was this from? "If the milk's sour, I ain't the kind of pussy to drink it.")
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From lz europe com  2007-02-16 22:15 -------
Hi all,
Per previous discussion with Gilles on digikam-devel mailing list, I am posting patches that allow the user to specify which encoding to use for IPTC comments. There are two patches, for libkexiv2 and digikam itself. These are made against the current SVN. The part of the digikam patch that modifies iptcwidget.cpp is to be considered temporary and will not be needed once that widget is converted to use libkexiv2. Gilles, please take a look. Thanks!
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From lz europe com  2007-02-16 22:16 -------
Created an attachment (id=19710)
 --> (http://bugs.kde.org/attachment.cgi?id=19710&action=view)
IPTC Encoding patch for libkexiv2
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From lz europe com  2007-02-16 22:16 -------
Created an attachment (id=19711)
 --> (http://bugs.kde.org/attachment.cgi?id=19711&action=view)
IPTC Encoding patch for digikam
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From caulier.gilles kdemail net  2007-02-18 11:39 -------
ok,

I will take a look in your patch monday morning.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From caulier.gilles gmail com  2007-02-23 13:21 -------
lz,

I have take a look into your patch. I have a question : why you store the "IPTC Encoding" setting in KDE global. This value must be stored in application setting and passed to a virtual KExiv2 method by the derived class DMetadata.

Like this libkexiv2 do not depand anymore of KDE core (in the future, i will certainly remove the KDElib depency and let only Qt depency to have only a pure Qt interface).

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From lz europe com  2007-02-26 10:44 -------
Hi Gilles,
I chose to store the settings in kdeglobal, because it is needed not only by Digikam itself, but also by Digikam kioslaves and, in theory, any application that uses libkexiv2. To be more precise, I've found that DMetadata is used in the kioslaves, but class AlbumSettings is not, and thus I could not read this setting from there. Do Digikam kioslaves have access to Digikam app config?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         
lz europe com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lz europe com
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From lz europe com  2007-04-09 13:08 -------
Hi Gilles,
Just wanted to ask if you had any time to look at my patch further.

Thanks,
  Leonid
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Karlsberg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From eu9645 kolumbus fi  2007-05-05 18:03 -------
Any progress on this?

Johannes
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From caulier.gilles gmail com  2007-05-05 18:08 -------
I have a patch on my computer to support UTF-8 with IPTC, but i'm not yet fully satisfied by it. I will working on between digiKam 0.9.2-beta1 and beta2 release...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Karlsberg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From eu9645 kolumbus fi  2007-05-05 20:08 -------
I tried those patches sent here earlier but got errors when patching. Which version should they be applied?

Johannes
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From caulier.gilles gmail com  2007-05-06 09:26 -------
the patch is on my computer, not in B.K.O

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From arnd.baecker web de  2007-06-12 20:45 -------
Just for completeness a brief quote from Gilles on the IRC wrt
this bug:

The patch is not fine as it does not respect the IPTC norm.
IPTC provide a tag to specify the char encoding.
The patch tries to detect the char encoding to parse the string,
especially the first char which can include specific sub string
to declare encoding. This is not how the IPTC works.
The patch must be re-written.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132244         




------- Additional Comments From lz europe com  2007-06-13 18:26 -------
In connection to the previous comment, just want to mention that not every program that writes IPTC caption tags sets the IPTC encoding tag. For example, Picasa and IrfanView do not. Therefore the world must be full of IPTC-tagged images with encoding tag unset.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel