[Digikam-devel] [Bug 131743] New: Comments and tag edit widgets should retain focus when changing image

[vrabcak]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         
           Summary: Comments and tag edit widgets should retain focus when
                    changing image
           Product: digikam
           Version: 0.9.0-beta1
          Platform: SuSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: t.tichy post cz


Version:           0.9.0-beta1 (using KDE KDE 3.5.3)
Installed from:    SuSE RPMs
OS:                Linux

Common usage pattern of Digikam is: Dowload images from camera and after that tag and add comments to all images from the album. But the new sidebar have usability flaw in adding comments. If you finish editing comment in Comments widget and press PGDOWN for next image, the widget and the whole sidebar lose focus and there is no easy way how to get back to the edit widget with keyboard. You must hit TAB many times or you must move your hand from the keyboard to mouse and back.  
 I suggest that the sidebar with last selected widged should retain focus when changing images with PGUP/PGDOWN. When you are typing many comments, it is very bad for usability to have to use mouse between them.
 There should be also shortcuts for editing comment, date & time and rating, which will greatly improve usability of Digikam with keyboard.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles free fr  2006-08-17 01:57 -------
Note : Rating shortcuts already exist : CTRL+SHIFT+0/1/2/3/4/5

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Usability
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[John Goerzen]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         
jgoerzen complete org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jgoerzen complete org



------- Additional Comments From jgoerzen complete org  2006-11-23 16:32 -------
I agree.  I was about to submit a bug saying it wasn't even possible to move between photos using only the keyboard.  I still don't see where the PgDn shortcut is documented -- it certainly doesn't appear when hovering over the next item arrow, now does it appear in the digikam shortcuts settings box.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         
caulier.gilles kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kdebug mail 4brad com



------- Additional Comments From caulier.gilles kdemail net  2006-12-22 13:13 -------
*** Bug 131632 has been marked as a duplicate of this bug. ***
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         
caulier.gilles kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles kdemail net  2006-12-22 13:18 -------
SVN commit 615716 by cgilles:

digikam from trunk : Always give the keyboard focus to the Comments text edit widget from Comments & Tags sidebar.
BUG: 131743




 M  +3 -1      NEWS  
 M  +0 -4      digikam/albumwidgetstack.cpp  
 M  +0 -1      digikam/mediaplayerview.cpp  
 M  +3 -0      libs/imageproperties/imagedescedittab.cpp  


--- trunk/extragear/graphics/digikam/NEWS #615715:615716
 @ -407,6 +407,8  @
                  tags (and to 'de'select them).
 243 ==> 132309 : Wish: enhance video support in digikam.
 244 ==> 115153 : Assigns tags not only to selected images with drag and drop.
-245 ==>
+245 ==> 131743 : Comments and tag edit widgets should retain focus when changing image.
+246 ==> 131632 : Shortcuts for better captioning workflow.
+247 ==>
 
 ----------------------------------------------------------------------------------------------------
--- trunk/extragear/graphics/digikam/digikam/albumwidgetstack.cpp #615715:615716
 @ -144,9 +144,6  @
             imagePreviewWidget()->setImagePath(url.path());
         }
     }
-
-    if (visibleWidget())
-        visibleWidget()->setFocus();
 }
 
 int AlbumWidgetStack::previewMode(void)
 @ -164,7 +161,6  @
         setPreviewItem();
 
     raiseWidget(mode);
-    visibleWidget()->setFocus();
 }
 
 }  // namespace Digikam
--- trunk/extragear/graphics/digikam/digikam/mediaplayerview.cpp #615715:615716
 @ -240,7 +240,6  @
         return;
 
     raiseWidget(mode);
-    visibleWidget()->setFocus();
 }
 
 }  // NameSpace Digikam
--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #615715:615716
 @ -502,6 +502,9  @
     updateDate();
     updateTagsView();
     update();
+
+    // See B.K.O #131632 and #131743 : always give focus to Comments widget.
+    d->commentsEdit->setFocus();
 }
 
 void ImageDescEditTab::updateTagsView()
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2006-12-22 14:16 -------
SVN commit 615731 by cgilles:

digikam from trunk : Always give the keyboard focus to the Comments text edit widget from Comments & Tags when we change the active sidebar tab.
CCBUGS: 131743




 M  +61 -59    imagedescedittab.cpp  
 M  +1 -0      imagedescedittab.h  
 M  +9 -5      imagepropertiessidebardb.cpp  


--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #615730:615731
 @ -251,7 +251,7  @
     d->dateTimeEdit->installEventFilter(this);
     d->ratingWidget->installEventFilter(this);
     d->tagsView->installEventFilter(this);
-    d->commentsEdit->setFocus();
+    setFocusToComments();
     updateRecentTags();
 
     // Connect to album manager -----------------------------
 @ -317,53 +317,6  @
     delete d;
 }
 
-bool ImageDescEditTab::eventFilter(QObject *, QEvent *e)
-{
-    if ( e->type() == QEvent::KeyPress )
-    {
-        QKeyEvent *k = (QKeyEvent *)e;
-        if (k->state() == Qt::ControlButton &&
-            (k->key() == Qt::Key_Enter || k->key() == Qt::Key_Return))
-        {
-            emit signalNextItem();
-            return true;
-        }
-        else if (k->state() == Qt::ShiftButton &&
-                 (k->key() == Qt::Key_Enter || k->key() == Qt::Key_Return))
-        {
-            emit signalPrevItem();
-            return true;
-        }
-
-        return false;
-    }
-    
-    return false;
-}
-
-void ImageDescEditTab::populateTags()
-{
-    d->tagsView->clear();
-
-    AlbumList tList = AlbumManager::instance()->allTAlbums();
-    for (AlbumList::iterator it = tList.begin(); it != tList.end(); ++it)
-    {
-        TAlbum *tag = (TAlbum*)(*it);
-        slotAlbumAdded(tag);
-    }
-}
-
-void ImageDescEditTab::slotModified()
-{
-    d->modified = true;
-    d->applyBtn->setEnabled(true);
-}
-
-void ImageDescEditTab::assignRating(int rating)
-{
-    d->ratingWidget->setRating(rating);
-}
-
 void ImageDescEditTab::slotApplyAllChanges()
 {
     if (!d->modified)
 @ -401,28 +354,28  @
 
     if (AlbumSettings::instance())
     {
- bool dirty = false;
+        bool dirty = false;
         DMetadata metadata(d->currInfo->filePath());
 
         if (AlbumSettings::instance()->getSaveComments())
         {
             // Store comments in image as JFIF comments, Exif comments, and Iptc Comments.
             metadata.setImageComment(d->commentsEdit->text());
-    dirty = true;
+            dirty = true;
         }
 
         if (AlbumSettings::instance()->getSaveDateTime())
         {
             // Store Image Date & Time as Exif and Iptc tags.
             metadata.setImageDateTime(d->dateTimeEdit->dateTime(), false);
-    dirty = true;
+            dirty = true;
         }
 
         if (AlbumSettings::instance()->getSaveIptcRating())
         {
             // Store Image rating as Iptc tag.
             metadata.setImageRating(d->ratingWidget->rating());
-    dirty = true;
+            dirty = true;
         }
 
         if (AlbumSettings::instance()->getSaveIptcTags())
 @ -433,7 +386,7  @
                 (*it).remove(0, 1);
     
             metadata.setImageKeywords(oldKeywords, tagPaths);
-    dirty = true;
+            dirty = true;
         }
 
         if (AlbumSettings::instance()->getSaveIptcPhotographerId())
 @ -441,7 +394,7  @
             // Store Photograph indentity into Iptc tags.
             metadata.setImagePhotographerId(AlbumSettings::instance()->getIptcAuthor(),
                                             AlbumSettings::instance()->getIptcAuthorTitle());
-    dirty = true;
+            dirty = true;
         }
 
         if (AlbumSettings::instance()->getSaveIptcCredits())
 @ -450,14 +403,14  @
             metadata.setImageCredits(AlbumSettings::instance()->getIptcCredit(),
                                      AlbumSettings::instance()->getIptcSource(),
                                      AlbumSettings::instance()->getIptcCopyright());
-    dirty = true;
+            dirty = true;
         }
 
- if (dirty)
- {
+        if (dirty)
+        {
             metadata.applyChanges();
             ImageAttributesWatch::instance()->fileMetadataChanged(d->currInfo->kurl());
- }
+        }
     }
 
     d->modified = false;
 @ -502,11 +455,60  @
     updateDate();
     updateTagsView();
     update();
+}
 
-    // See B.K.O #131632 and #131743 : always give focus to Comments widget.
+bool ImageDescEditTab::eventFilter(QObject *, QEvent *e)
+{
+    if ( e->type() == QEvent::KeyPress )
+    {
+        QKeyEvent *k = (QKeyEvent *)e;
+        if (k->state() == Qt::ControlButton &&
+            (k->key() == Qt::Key_Enter || k->key() == Qt::Key_Return))
+        {
+            emit signalNextItem();
+            return true;
+        }
+        else if (k->state() == Qt::ShiftButton &&
+                 (k->key() == Qt::Key_Enter || k->key() == Qt::Key_Return))
+        {
+            emit signalPrevItem();
+            return true;
+        }
+
+        return false;
+    }
+    
+    return false;
+}
+
+void ImageDescEditTab::populateTags()
+{
+    d->tagsView->clear();
+
+    AlbumList tList = AlbumManager::instance()->allTAlbums();
+    for (AlbumList::iterator it = tList.begin(); it != tList.end(); ++it)
+    {
+        TAlbum *tag = (TAlbum*)(*it);
+        slotAlbumAdded(tag);
+    }
+}
+
+void ImageDescEditTab::slotModified()
+{
+    d->modified = true;
+    d->applyBtn->setEnabled(true);
+}
+
+void ImageDescEditTab::setFocusToComments()
+{
     d->commentsEdit->setFocus();
 }
 
+void ImageDescEditTab::assignRating(int rating)
+{
+    d->ratingWidget->setRating(rating);
+}
+
 void ImageDescEditTab::updateTagsView()
 {
     d->tagsView->blockSignals(true);
--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.h #615730:615731
 @ -56,6 +56,7  @
     void assignRating(int rating);
     void setItem(ImageInfo *info=0, int itemType=0);
     void populateTags();
+    void setFocusToComments();
 
 signals:
 
--- trunk/extragear/graphics/digikam/libs/imageproperties/imagepropertiessidebardb.cpp #615730:615731
 @ -41,13 +41,14  @
 #include "themeengine.h"
 #include "albumiconitem.h"
 #include "albumiconview.h"
+#include "navigatebarwidget.h"
+#include "imagedescedittab.h"
+#include "imageattributeswatch.h"
 #include "imagepropertiestab.h"
 #include "imagepropertiesmetadatatab.h"
 #include "imagepropertiescolorstab.h"
-#include "imagedescedittab.h"
-#include "navigatebarwidget.h"
 #include "imagepropertiessidebardb.h"
-#include "imageattributeswatch.h"
+#include "imagepropertiessidebardb.moc"
 
 namespace Digikam
 {
 @ -225,7 +226,7  @
     setCursor(KCursor::waitCursor());
 
     // No database data available, for example in the case of image editor is
-    // launched from camera GUI.
+    // started from camera GUI.
     if (!d->currentInfo)
     {
         if (tab == m_propertiesTab && !m_dirtyPropertiesTab)
 @ -285,6 +286,10  @
         }
     }
 
+    // See B.K.O #131632 and #131743 : always give focus to Comments widget
+    // when we toogle between tab and when we change current item.
+    d->desceditTab->setFocusToComments();
+
     unsetCursor();
 }
 
 @ -345,4 +350,3  @
 
 }  // NameSpace Digikam
 
-#include "imagepropertiessidebardb.moc"
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From kdebug mail 4brad com  2006-12-22 19:53 -------
This is fine with me, though I could see other people annoyed if their focus changes.  Perhaps a right solution is to just keep keyboard focus where it was on the prior image.   Including the caption of course.  Or is that what the 2nd patch does?.  There are some keyboard shortcuts to actual letters (like 'a' for zoom, digits for rotate etc.)

In general, if you are going to have text boxes like the caption and search box, having ordinary letters as action keys when focus is on "the picture" is going to cause some confusion, as people type and find themselves accidentally rotating or vice versa (not as harmful.)   Keyboard focus should perhaps be less subtle (now it's a cursor and a thickening of the border of the comment box.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From mikmach wp pl  2007-01-01 17:20 -------
Uh, uh. I always steals focus which makes keyboard navigation in Digikam completely impossible.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |



------- Additional Comments From marcel.wiesweg gmx de  2007-01-01 22:40 -------
Reopen because of regression:
As soon as the Comments/Tags sidebar tab has been visible once, keyboard focus will always be on the comments widget.
Thats a problem because:
- the focus is gone even if another sidebar tab is visible
- keyboard navigation in icon view is impossible
- shortcuts dont work anymore (deleting a picture with Del)

Suggestion:
Keep focus on comments widget only if it had the focus, and the next picture was chosen with Page Up/Down?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From mikmach wp pl  2007-01-02 00:33 -------
> Suggestion:
> Keep focus on comments widget only if it had the focus, and the next
> picture was chosen with Page Up/Down?


I am for it. But this policy should also apply for all other widgets in
all tabs. Plus some smart way to change "major" focus between panel,
album view and album tree ("minor" focus would be changing between
appropriately panel widgets, images and albums).

m.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2007-01-02 23:35 -------
Other problem with current implementation : if you take focus using mouse wheel on icon view or album tree view, the focus on Comment edit widget is lost.

Idem if you enable the icon tool tip feature and you move the mouse over a thumnail.

Nota : if comment & tab side is visible and comment edit widget has the focus, you can change the current selected thumb from album view to use page-up/page-down...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From kdebug mail 4brad com  2007-01-03 00:27 -------
The main thing required is a reliable flow.  You can sort of get this by pressing Alt-C after going to next photo (pgdown) but that's not too exciting.  You might allow people to define their own shortcut for commenting or even a "next and caption" shortcut.

My preference is for fast captioning with no need to ever take hands off the keyboard to use the mouse, which is served by a "next and caption" shortcut.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2007-01-03 10:32 -------
From #8 : Suggestion from Marcel to keep focus on comments widget only if it had the focus : yes this is a possible solution...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2007-01-03 10:32 -------
SVN commit 619377 by cgilles:

digikam from trunk : Image editor Transform shortcuts : use CTRL instead SHIFT to prevent conflict with new rule from Comments Text edit widget focus from right side bar.

CCBUGS: 131743




 M  +5 -5      editorwindow.cpp  


--- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp #619376:619377
 @ -354,11 +354,11  @
     d->flipAction = new KActionMenu(i18n("Flip"), "flip", actionCollection(), "editorwindow_flip");
     d->flipAction->setDelayed(false);
 
-    d->flipHorzAction = new KAction(i18n("Horizontally"), 0, SHIFT+Key_Asterisk,
+    d->flipHorzAction = new KAction(i18n("Horizontally"), 0, CTRL+Key_Asterisk,
                                    m_canvas, SLOT(slotFlipHoriz()),
                                    actionCollection(), "editorwindow_fliphorizontal");
 
-    d->flipVertAction = new KAction(i18n("Vertically"), 0, SHIFT+Key_Slash,
+    d->flipVertAction = new KAction(i18n("Vertically"), 0, CTRL+Key_Slash,
                                    m_canvas, SLOT(slotFlipVert()),
                                    actionCollection(), "editorwindow_flipvertical");
                                   
 @ -373,15 +373,15  @
     d->rotateAction->setDelayed(false);
 
     d->rotate90Action  = new KAction(i18n("90 Degrees"),
-                                    0, SHIFT+Key_9, m_canvas, SLOT(slotRotate90()),
+                                    0, CTRL+Key_9, m_canvas, SLOT(slotRotate90()),
                                     actionCollection(),
                                     "rotate_90");
     d->rotate180Action = new KAction(i18n("180 Degrees"),
-                                    0, SHIFT+Key_8, m_canvas, SLOT(slotRotate180()),
+                                    0, CTRL+Key_8, m_canvas, SLOT(slotRotate180()),
                                     actionCollection(),
                                     "rotate_180");
     d->rotate270Action = new KAction(i18n("270 Degrees"),
-                                    0, SHIFT+Key_7, m_canvas, SLOT(slotRotate270()),
+                                    0, CTRL+Key_7, m_canvas, SLOT(slotRotate270()),
                                     actionCollection(),
                                     "rotate_270");
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2007-01-03 10:33 -------
SVN commit 619378 by cgilles:

kipi-plugins from trunk : JPEGLossLess shortcuts : use CTRL instead SHIFT to prevent conflict with new rule from Comments Text edit widget focus from digiKam right side bar.

CCBUGS: 131743




 M  +5 -5      plugin_jpeglossless.cpp  


--- trunk/extragear/libs/kipi-plugins/jpeglossless/plugin_jpeglossless.cpp #619377:619378
 @ -92,7 +92,7  @
 
     m_action_RotateImage->insert( new KAction(i18n("90 Degrees"),
                                   0,
-                                  SHIFT+Key_9,
+                                  CTRL+Key_9,
                                   this,
                                   SLOT(slotRotate()),
                                   actionCollection(),
 @ -100,7 +100,7  @
 
     m_action_RotateImage->insert( new KAction(i18n("180 Degrees"),
                                   0,
-                                  SHIFT+Key_8,
+                                  CTRL+Key_8,
                                   this,
                                   SLOT(slotRotate()),
                                   actionCollection(),
 @ -108,7 +108,7  @
 
     m_action_RotateImage->insert( new KAction(i18n("270 Degrees"),
                                   0,
-                                  SHIFT+Key_7,
+                                  CTRL+Key_7,
                                   this,
                                   SLOT(slotRotate()),
                                   actionCollection(),
 @ -121,7 +121,7  @
 
     m_action_FlipImage->insert( new KAction(i18n("Horizontally"),
                                 0,
-                                SHIFT+Key_Asterisk,
+                                CTRL+Key_Asterisk,
                                 this,
                                 SLOT(slotFlip()),
                                 actionCollection(),
 @ -129,7 +129,7  @
 
     m_action_FlipImage->insert( new KAction(i18n("Vertically"),
                                 0,
-                                SHIFT+Key_Slash,
+                                CTRL+Key_Slash,
                                 this,
                                 SLOT(slotFlip()),
                                 actionCollection(),
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2007-01-03 10:53 -------
SVN commit 619384 by cgilles:

digikam from trunk : Image editor Zoom Auto-Fit shortcut : use "CTRL+SHIFT+A" instead "A" to prevent conflict with new rule from Comments Text edit widget focus from right side bar.

CCBUGS: 131743




 M  +1 -1      editorwindow.cpp  


--- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp #619383:619384
 @ -303,7 +303,7  @
     d->zoomMinusAction = KStdAction::zoomOut(m_canvas, SLOT(slotDecreaseZoom()),
                                             actionCollection(), "editorwindow_zoomminus");
     d->zoomFitAction = new KToggleAction(i18n("Zoom &AutoFit"), "viewmagfit",
-                                        Key_A, this, SLOT(slotToggleAutoZoom()),
+                                        CTRL+SHIFT+Key_A, this, SLOT(slotToggleAutoZoom()),
                                         actionCollection(), "editorwindow_zoomfit");
 
 #if KDE_IS_VERSION(3,2,0)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2007-01-03 10:58 -------
From #8 : shortcuts dont work anymore (deleting a picture with Del) : for this one we can use CTRL+Del instead Del. Of course it's not really homogenous with other KDE applications...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2007-01-03 11:10 -------
SVN commit 619391 by cgilles:

digikam from trunk : Image editor Curve Tool shortcut : use "CTRL+U" instead "SHIFT+C" to prevent conflict with new rule from Comments Text edit widget focus from right side bar.

CCBUGS: 131743




 M  +2 -2      digikamimageplugin_adjustcurves_ui.rc  
 M  +6 -8      imageplugin_adjustcurves.cpp  


--- trunk/extragear/graphics/digikamimageplugins/adjustcurves/digikamimageplugin_adjustcurves_ui.rc #619390:619391
 @ -1,5 +1,5  @
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_adjustcurves" >
+<kpartgui version="3" name="digikamimageplugin_adjustcurves" >
 
  <MenuBar>
 
 @ -18,7 +18,7  @
  </ToolBar>
 
  <ActionProperties>
-  <Action shortcut="Shift+C" name="imageplugin_adjustcurves" />
+  <Action name="imageplugin_adjustcurves" />
  </ActionProperties>
 
 </kpartgui>
--- trunk/extragear/graphics/digikamimageplugins/adjustcurves/imageplugin_adjustcurves.cpp #619390:619391
 @ -1,10 +1,9  @
 /* ============================================================
- * File  : imageplugin_adjustcurves.cpp
- * Author: Gilles Caulier <caulier dot gilles at kdemail dot net>
- * Date  : 2004-12-01
+ * Authors: Gilles Caulier <caulier dot gilles at kdemail dot net>
+ * Date   : 2004-12-01
  * Description :
  *
- * Copyright 2004-2006 by Gilles Caulier
+ * Copyright 2004-2007 by Gilles Caulier
  *
  * This program is free software; you can redistribute it
  * and/or modify it under the terms of the GNU General
 @ -32,6 +31,7  @
 #include "bannerwidget.h"
 #include "adjustcurves.h"
 #include "imageplugin_adjustcurves.h"
+#include "imageplugin_adjustcurves.moc"
 
 K_EXPORT_COMPONENT_FACTORY( digikamimageplugin_adjustcurves,
                             KGenericFactory<ImagePlugin_AdjustCurves>("digikamimageplugin_adjustcurves"));
 @ -40,7 +40,8  @
                                                    const QStringList &)
                         : Digikam::ImagePlugin(parent, "ImagePlugin_AdjustCurves")
 {
-    m_curvesAction = new KAction(i18n("Curves Adjust..."), "adjustcurves", 0,
+    m_curvesAction = new KAction(i18n("Curves Adjust..."), "adjustcurves",
+ CTRL+Key_U,
                          this, SLOT(slotCurvesAdjust()),
                          actionCollection(), "imageplugin_adjustcurves");
 
 @ -67,6 +68,3  @
     dlg.exec();
     delete headerFrame;
 }
-
-
-#include "imageplugin_adjustcurves.moc"
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         




------- Additional Comments From caulier.gilles kdemail net  2007-01-03 11:13 -------
SVN commit 619393 by cgilles:

digikam from trunk : Image editor Curve Tool shortcut : use "CTRL+M" instead "CTRL+U" to be homgenous with Photoshop shortcuts.

CCBUGS: 131743




 M  +1 -1      imageplugin_adjustcurves.cpp  


--- trunk/extragear/graphics/digikamimageplugins/adjustcurves/imageplugin_adjustcurves.cpp #619392:619393
 @ -41,7 +41,7  @
                         : Digikam::ImagePlugin(parent, "ImagePlugin_AdjustCurves")
 {
     m_curvesAction = new KAction(i18n("Curves Adjust..."), "adjustcurves",
- CTRL+Key_U,
+ CTRL+Key_M,         // NOTE: Photoshop 7 use CTRL+M.
                          this, SLOT(slotCurvesAdjust()),
                          actionCollection(), "imageplugin_adjustcurves");
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel