[Digikam-devel] [Bug 130381] New: automatic colorbalance and camera color balance checkboxes swapped

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 130381] New: automatic colorbalance and camera color balance checkboxes swapped

Erik van der Velden
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130381         
           Summary: automatic colorbalance and camera color balance
                    checkboxes swapped
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: erikvandervelden netscape net


Version:           9.0 svn (using KDE KDE 3.5.3)
Installed from:    Compiled From Sources
Compiler:          x86_64-pc-linux-gnu-3.4.6
OS:                Linux

In >settings>IO files there are two checkboxes; one for automatic color balance and and one for camera color balance.
However, the options are actually swapped and the values are read wrongly.

The following patch fixes this:

Index: digikam/utilities/setup/setupiofiles.cpp
===================================================================
--- digikam/utilities/setup/setupiofiles.cpp    (revision 558963)
+++ digikam/utilities/setup/setupiofiles.cpp    (working copy)
 @ -333,8 +333,8  @
     d->NRSigmaRange->setValue( config->readDoubleNumEntry("NRSigmaRange", 4.0) );
     d->SuperCCDsecondarySensor->setChecked(config->readBoolEntry("SuperCCDsecondarySensor", false));
     d->unclipColors->setChecked(config->readBoolEntry("UnclipColors", false));
-    d->cameraColorBalance->setChecked(config->readBoolEntry("AutomaticColorBalance", true));
-    d->automaticColorBalance->setChecked(config->readBoolEntry("CameraColorBalance", true));
+    d->cameraColorBalance->setChecked(config->readBoolEntry("CameraColorBalance", true));
+    d->automaticColorBalance->setChecked(config->readBoolEntry("AutomaticColorBalance", true));
     d->RGBInterpolate4Colors->setChecked(config->readBoolEntry("RGBInterpolate4Colors", false));

     d->JPEGcompression->setValue( config->readNumEntry("JPEGCompression", 75) );
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] [Bug 130381] automatic colorbalance and camera color balance checkboxes swapped

Gilles Caulier
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130381         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles free fr  2006-07-07 09:29 -------
SVN commit 559363 by cgilles:

Fix swaped dcraw color balance settings
BUG: 130381


 M  +2 -2      setupiofiles.cpp  


--- trunk/extragear/graphics/digikam/utilities/setup/setupiofiles.cpp #559362:559363
 @ -333,8 +333,8  @
     d->NRSigmaRange->setValue( config->readDoubleNumEntry("NRSigmaRange", 4.0) );
     d->SuperCCDsecondarySensor->setChecked(config->readBoolEntry("SuperCCDsecondarySensor", false));
     d->unclipColors->setChecked(config->readBoolEntry("UnclipColors", false));
-    d->cameraColorBalance->setChecked(config->readBoolEntry("AutomaticColorBalance", true));
-    d->automaticColorBalance->setChecked(config->readBoolEntry("CameraColorBalance", true));
+    d->cameraColorBalance->setChecked(config->readBoolEntry("CameraColorBalance", true));
+    d->automaticColorBalance->setChecked(config->readBoolEntry("AutomaticColorBalance", true));
     d->RGBInterpolate4Colors->setChecked(config->readBoolEntry("RGBInterpolate4Colors", false));
 
     d->JPEGcompression->setValue( config->readNumEntry("JPEGCompression", 75) );
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel