[Digikam-devel] [Bug 128472] New: Aspect ratio plugin enchancements - auto orientation, new selection

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         
           Summary: Aspect ratio plugin enchancements - auto orientation,
                    new selection
           Product: digikam
           Version: unspecified
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: malenko email cz


Version:            (using KDE KDE 3.5.3)
Installed from:    Gentoo Packages

I implemented various enhancements to aspect ratio plug-in. The changes include
1) Automatic setting of orientation
2) It is possible to "click and draw" a new selection. You do not need to move the actual selection to desired position.

I changed imageselectionwidget and aspect ratio dialog.

Minor issues
- Enhancement 2) slightly changes original behavior.  Clicking outside of selection start drawing a new selection now. Before it moved the selection to this position. This can be reverted by changing m_allowCreatingNewRegion to false. If this version will be approved then this this variable can be removed from source code.
- I was not able to catch the "CTRL released" event. (This is due to my minor knowledge of qt.) The relevant code is prepared in function keyReleased. The code works perfectly now, but somebody might wish to look at it. Remove the calling of this function from mouseReleaseEvent() afterwards.

I wish every photographer fun when cropping the pictures. Bye
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From malenko email cz  2006-06-02 00:34 -------
Created an attachment (id=16419)
 --> (http://bugs.kde.org/attachment.cgi?id=16419&action=view)
imageeffect_ratiocrop.cpp
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From malenko email cz  2006-06-02 00:35 -------
Created an attachment (id=16420)
 --> (http://bugs.kde.org/attachment.cgi?id=16420&action=view)
imageeffect_ratiocrop.h
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From malenko email cz  2006-06-02 00:35 -------
Created an attachment (id=16421)
 --> (http://bugs.kde.org/attachment.cgi?id=16421&action=view)
imageselectionwidget.cpp
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From malenko email cz  2006-06-02 00:36 -------
Created an attachment (id=16422)
 --> (http://bugs.kde.org/attachment.cgi?id=16422&action=view)
imageselectionwidget.h
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Chris Howells]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From howells kde org  2006-06-02 01:02 -------
Hi,

Please attach unified diffs created with the diff -u command.

Thanks.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From caulier.gilles free fr  2006-06-02 07:59 -------
Hi JM

I'm interresed to test your implementation. please use "svn diff > mypatch" against trunk to make a patch. Thanks in advance

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From malenko email cz  2006-06-02 08:08 -------
Created an attachment (id=16425)
 --> (http://bugs.kde.org/attachment.cgi?id=16425&action=view)
diff -u patch
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From malenko email cz  2006-06-02 08:20 -------
Created an attachment (id=16426)
 --> (http://bugs.kde.org/attachment.cgi?id=16426&action=view)
svn patch (untested)

I was not able to test this as I haven't found configure
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From malenko email cz  2006-06-02 08:41 -------
I forgot to mention another feature.
3) when resizing selection and holding CTRL the center of selection keeps its place and the opposite corner is moved.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         




------- Additional Comments From caulier.gilles free fr  2006-06-02 08:50 -------
JM,

Your implementation have been done using current stable implementation of digiKam not trunk.

Stable branch is now just a bugfix release. New features must be add to trunk branch now.

Your patch cannot be apply on trunk branch of digiKam (future 0.9.0). I'm very interresed by your new features. Please backport your code using svn trunk, not svn stable.

Thanks in advance

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Image Editor
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Image Editor                |Core Plugin
            Product|digikam                     |digikamimageplugins
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |0.8.2



------- Additional Comments From caulier.gilles free fr  2006-07-28 14:40 -------
Some new about porting code to 0.9.0 (svn trunk) ? Thanks in advance

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128472         
caulier.gilles kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE



------- Additional Comments From caulier.gilles kdemail net  2007-01-16 07:34 -------
This file is now obsolete.

Gilles Caulier

*** This bug has been marked as a duplicate of 140136 ***
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel