[Digikam-devel] [Bug 128293] New: aspect ratio crop does not respect aspect ratio

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128293         




------- Additional Comments From arnd.baecker web de  2008-02-02 21:30 -------
SVN commit 770107 by abaecker:

When cropping images, fullfill the given aspect ratio as good as possible (patch by Roberto Castagnola).

CCBUGS: 128293
TODO:KDE4PORT



 M  +134 -65   imageeffect_ratiocrop.cpp  
 M  +15 -16    imageeffect_ratiocrop.h  
 M  +363 -357  imageselectionwidget.cpp  
 M  +16 -17    imageselectionwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=770107
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128293         




------- Additional Comments From arnd.baecker web de  2008-02-02 21:35 -------
Thanks a lot for this nice patch, Roberto!

I applied this patch together with the one you sent me by mail to
ensure that the current selection values are only saved when the selection
is applied (i.e not also on Cancel).
All tests I did worked fine, but due to the complexity and number
of possibilities there still good be some overlooked cases.

As last step, before this bug can be finally closed, Roberto
plans to provide a patch which (optionally) ensures precise
aspect ratios as discussed in #c12 above.

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128293         




------- Additional Comments From caulier.gilles gmail com  2008-02-02 21:41 -------
Ok Arnd,

Thanks to Roberto. Excelent job...

Tomorow, i will backport patch to KDE4 as well

Gille Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128293         




------- Additional Comments From roberto.castagnola gmail com  2008-02-02 23:49 -------
Arnd, Gilles,

I think it will take longer to ensures precise aspect ratios as discussed in #c12 above. However I consider it as a new feature and I will open a new bug/wish as soon as the patch is ready. In the meantime, I think this bug can be closed.

Anyway, feel free to add me to CC list if a new bug/wish is opened for this plugin.

Best, Roberto
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128293         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2008-02-03 22:52 -------
SVN commit 770517 by cgilles:

digiKam from trunk: backport commit #770107 from KDE3 branch
BUG: 128293


 M  +169 -107  imageeffect_ratiocrop.cpp  
 M  +21 -21    imageeffect_ratiocrop.h  
 M  +364 -361  imageselectionwidget.cpp  
 M  +30 -34    imageselectionwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=770517
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel