[Digikam-devel] [Bug 127634] New: communication between digikam and its kioslaves broken if size_t != off_t

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127634         
           Summary: communication between digikam and its kioslaves broken
                    if size_t != off_t
           Product: digikam
           Version: 0.8.1
          Platform: NetBSD pkgsrc
        OS/Version: NetBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: mark mcs vuw ac nz


Version:           0.8.1 (using KDE KDE 3.5.2)
Installed from:    NetBSD pkgsrc
Compiler:          gcc 3.3.3
OS:                NetBSD

On systems where  size_t != off_t communication between digikam and its kioslaves (eg digikamsearch) breaks because the kioslaves try to pass a different sized object from what digikam expects.

Specifically they pass stbuf.st_size which is of type off_t while digikam is expecting a size_t object at that point.  My fix is to change digikam to expect an off_t (I'll attach a patch shortly), alternatively you could cast all the st_size's to size_t but that seems ugly.

This appears to still be a problem with 0.8.2-rc1.

cheers
mark
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127634         




------- Additional Comments From mark mcs vuw ac nz  2006-05-19 02:36 -------
Created an attachment (id=16166)
 --> (http://bugs.kde.org/attachment.cgi?id=16166&action=view)
Fix wrong type

Patch that fixes type mismatch between digikam and its kioslaves.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127634         




------- Additional Comments From caulier.gilles free fr  2006-05-19 07:34 -------
SVN commit 542353 by cgilles:

digikam from stable: fix wrong cast between digikam album lister and kio slave
CCBUGS: 127634

 M  +1 -1      albumlister.cpp  


--- branches/stable/extragear/graphics/digikam/digikam/albumlister.cpp #542352:542353
 @ -313,7 +313,7  @
     int     albumID;
     QString name;
     QString date;
-    size_t  size;
+    off_t   size;
     QSize   dims;
 
     ImageInfoList newItemsList;
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127634         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles free fr  2006-05-19 07:35 -------
SVN commit 542354 by cgilles:

digikam from trunk: fix wrong cast between digikam album lister and kio slave
BUG: 127634

 M  +1 -1      albumlister.cpp  


--- trunk/extragear/graphics/digikam/digikam/albumlister.cpp #542353:542354
 @ -323,7 +323,7  @
     int     albumID;
     QString name;
     QString date;
-    size_t  size;
+    off_t   size;
     QSize   dims;
 
     ImageInfoList newItemsList;
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127634         




------- Additional Comments From mark mcs vuw ac nz  2006-07-27 03:29 -------
On Friday 19 May 2006 17:35, Gilles Caulier wrote:
[bugs.kde.org quoted mail]

Unfortunately this is still broken in 0.8.2, but now for the reverse reason.
You fixed the above so that albumlister.cpp was expecting an off_t but someone
also fixed the other end so that they now pass a size_t:

eg. kioslaves/digikamalbums.cpp now has:

        *os << static_cast<size_t>(stbuf.st_size);

so there is still a mismatch in the size of the argument that each side is
sending/expecting.

cheers
mark
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel