digiKam › digikam-devel

[Digikam-devel] [Bug 121367] New: Add properties tab to digiKam and (especially) IE

Classic

List

Threaded

26 messages Options

Gilles Caulier

[Digikam-devel] [Bug 121367] Add properties tab to digiKam and (especially) IE

Bugzilla from mikmach@wp.pl

[Digikam-devel] [Bug 121367] Add properties tab to digiKam and (especially) IE

In reply to this post by Bugzilla from mikmach@wp.pl

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=121367

------- Additional Comments From mikmach wp pl 2006-04-25 13:07 -------
> #3 (formatting of section headers)

Hmm. What do you think about that?

--- imagepropertiestab.cpp.orig 2006-04-25 12:10:49.000000000 +0200
+++ imagepropertiestab.cpp 2006-04-25 12:50:34.000000000 +0200
@ -130,7 +130,7 @

// --------------------------------------------------

- QLabel *title = new QLabel(i18n("File
Properties"), settingsArea);
+ QLabel *title = new QLabel(i18n("File
Properties"), settingsArea);
QLabel *folder = new QLabel(i18n("Folder:"),
settingsArea);
QLabel *modifiedDate = new QLabel(i18n("Modified:"),
settingsArea);
QLabel *size = new QLabel(i18n("Size:"),
settingsArea);
@ -138,12 +138,12 @
QLabel *permissions = new QLabel(i18n("Permissions:"),
settingsArea);

KSeparator *line = new KSeparator (Horizontal,
settingsArea);
- QLabel *title2 = new QLabel(i18n("Image
Properties"), settingsArea);
+ QLabel *title2 = new QLabel(i18n("Image
Properties"), settingsArea);
QLabel *mime = new QLabel(i18n("Type:"),
settingsArea);
QLabel *dimensions = new QLabel(i18n("Dimensions:"),
settingsArea);

KSeparator *line2 = new KSeparator (Horizontal,
settingsArea);
- d->title3 = new QLabel(i18n("Photograph
Properties"), settingsArea);
+ d->title3 = new QLabel(i18n("Photograph
Properties"), settingsArea);
d->make = new QLabel(i18n("Make:"),
settingsArea);
d->model = new QLabel(i18n("Model:"),
settingsArea);
d->photoDate = new QLabel(i18n("Created:"),
settingsArea);

> #4 ==> no, because i want an homogenous GUI between Showfoto and digiKam
> (Main interface, image editor and camera gui). Showfoto don't have
> 'Comments & Tags' and 'Tags Filter' sidebar tabs. Properties and
> Metadata are common. This is why, these one, are in first on the top.

Showfoto is separate application not used directly together with
digiKam, there is no UI need to keep interface so slavishly connected.

I move some part of discussion from the digikam-devel list:

Gilles:
>> - You didn't add comments and tags info in properties panel saying that
>> it is redundant to Comments&Tags panel but simultaneously adding many
>> info from meta tags. Hmm?
> yes, Comments & Tags informations are redondant.
> Metadata isn't redandant because it's a sorting and resume area with the

most
> important photograph settings extracted from EXIF/IPTC/Markernotes.

But this data is in Simple view of Metadata. Only one short (as in mouse
way), click away.

> In order words, we no need to dupplicate Comments & Tags informations in
> Properties tab because The Comments & Tags tab is clean...

I will elaborate: digiKam can be used by two sets of people: 1) making
many photos, highly interested in technical information because that
help them to judge quality of photo 2) amateurs more interested in
content and its meaning to them.

You and many current KDE/Linux users belong to 1st group. I am
belonging to 2nd and on technical list I am minority. However, in
general population of camera, users it is majority. OK, I am ending this
subject.

> #5 ==> I don't understand what you mean... Where is the problem exactly ?

In most situations Folder line will not give meaningful information.
Will show only last element of path, not showing whole Album path,
limiting usefulness of that element. I can only speak for myself but
when browsing images with right panel opened I am closing left
(organizational) panel - so don't have info about structure of digiKam
directory.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 121367] Add properties tab to digiKam and (especially) IE

In reply to this post by Bugzilla from mikmach@wp.pl

Gilles Caulier

[Digikam-devel] [Bug 121367] Add properties tab to digiKam and (especially) IE

In reply to this post by Bugzilla from mikmach@wp.pl

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=121367
caulier.gilles free fr changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED

------- Additional Comments From caulier.gilles free fr 2006-04-25 13:39 -------
#3 ==> Fixed in svn.
#5 ==> We using KSqueezedTextLabel not a QLabel to prevent broken layout if album path is very long ! You can see the real full path name using mouse to move under the label. A tool tip will be displayed.

I close this file now

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 121367] Add properties tab to digiKam and (especially) IE

In reply to this post by Bugzilla from mikmach@wp.pl

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=121367

------- Additional Comments From caulier.gilles free fr 2006-04-25 16:16 -------
SVN commit 533699 by cgilles:

digikam from trunk : album item file tips : hide all Photograph Properties informations if no metadata are available from current image.

CCBUGS: 121367
CCMAIL: digikam-devel kde org

M +55 -50 albumfiletip.cpp

--- trunk/extragear/graphics/digikam/digikam/albumfiletip.cpp #533698:533699
@ -23,6 +23,8 @
*
* ============================================================ */

+#define MAXSTRINGLEN 30
+
// Qt includes.

#include <qtooltip.h>
@ -366,61 +368,64 @
// -- Photograph Info ----------------------------------------------------
// NOTA: If something is changed here, please updated imageproperties section too.

- tip += headBeg + i18n("Photograph Properties") + headEnd;
-
- QString metaStr;
PhotoInfoContainer photoInfo = metaData.getPhotographInformations();
-
- str = QString("%1 / %2").arg(photoInfo.make.isEmpty() ? unavailable : photoInfo.make)
- .arg(photoInfo.model.isEmpty() ? unavailable : photoInfo.model);
- if (str.length() > 50) str = str.left(47) + "...";
- metaStr += cellBeg + i18n("Make/Model:") + cellMid + QStyleSheet::escape( str ) + cellEnd;

- if (photoInfo.dateTime.isValid())
+ if (!photoInfo.isEmpty())
{
- str = KGlobal::locale()->formatDateTime(photoInfo.dateTime, true, true);
- if (str.length() > 50) str = str.left(47) + "...";
- metaStr += cellBeg + i18n("Created:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
- }
- else
- metaStr += cellBeg + i18n("Created:") + cellMid + QStyleSheet::escape( unavailable ) + cellEnd;
-
- str = photoInfo.aperture.isEmpty() ? unavailable : photoInfo.aperture;
+ QString metaStr;
+ tip += headBeg + i18n("Photograph Properties") + headEnd;
+
+ str = QString("%1 / %2").arg(photoInfo.make.isEmpty() ? unavailable : photoInfo.make)
+ .arg(photoInfo.model.isEmpty() ? unavailable : photoInfo.model);
+ if (str.length() > MAXSTRINGLEN) str = str.left(MAXSTRINGLEN-3) + "...";
+ metaStr += cellBeg + i18n("Make/Model:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
+
+ if (photoInfo.dateTime.isValid())
+ {
+ str = KGlobal::locale()->formatDateTime(photoInfo.dateTime, true, true);
+ if (str.length() > MAXSTRINGLEN) str = str.left(MAXSTRINGLEN-3) + "...";
+ metaStr += cellBeg + i18n("Created:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
+ }
+ else
+ metaStr += cellBeg + i18n("Created:") + cellMid + QStyleSheet::escape( unavailable ) + cellEnd;

- if (photoInfo.focalLenght35mm.isEmpty())
- str += QString(" / %1").arg(photoInfo.focalLenght.isEmpty() ? unavailable : photoInfo.focalLenght);
- else
- str += QString(" / %1").arg(i18n("%1 (35mm: %2)").arg(photoInfo.focalLenght).arg(photoInfo.focalLenght35mm));
+ str = photoInfo.aperture.isEmpty() ? unavailable : photoInfo.aperture;
+
+ if (photoInfo.focalLenght35mm.isEmpty())
+ str += QString(" / %1").arg(photoInfo.focalLenght.isEmpty() ? unavailable : photoInfo.focalLenght);
+ else
+ str += QString(" / %1").arg(i18n("%1 (35mm: %2)").arg(photoInfo.focalLenght).arg(photoInfo.focalLenght35mm));
+
+ if (str.length() > MAXSTRINGLEN) str = str.left(MAXSTRINGLEN-3) + "...";
+ metaStr += cellBeg + i18n("Aperture/Focal:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
+
+ str = QString("%1 / %2").arg(photoInfo.exposureTime.isEmpty() ? unavailable : photoInfo.exposureTime)
+ .arg(photoInfo.sensitivity.isEmpty() ? unavailable : i18n("%1 ISO").arg(photoInfo.sensitivity));
+ if (str.length() > MAXSTRINGLEN) str = str.left(MAXSTRINGLEN-3) + "...";
+ metaStr += cellBeg + i18n("Exposure/Sensitivity:") + cellMid + QStyleSheet::escape( str ) + cellEnd;

- if (str.length() > 50) str = str.left(47) + "...";
- metaStr += cellBeg + i18n("Aperture/Focal:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
+ if (photoInfo.exposureMode.isEmpty() && photoInfo.exposureProgram.isEmpty())
+ str = unavailable;
+ else if (!photoInfo.exposureMode.isEmpty() && photoInfo.exposureProgram.isEmpty())
+ str = photoInfo.exposureMode;
+ else if (photoInfo.exposureMode.isEmpty() && !photoInfo.exposureProgram.isEmpty())
+ str = photoInfo.exposureProgram;
+ else
+ str = QString("%1 / %2").arg(photoInfo.exposureMode).arg(photoInfo.exposureProgram);
+ if (str.length() > MAXSTRINGLEN) str = str.left(MAXSTRINGLEN-3) + "...";
+ metaStr += cellBeg + i18n("Mode/Program:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
+
+ str = photoInfo.flash.isEmpty() ? unavailable : photoInfo.flash;
+ if (str.length() > MAXSTRINGLEN) str = str.left(MAXSTRINGLEN-3) + "...";
+ metaStr += cellBeg + i18n("Flash:") + cellMid + QStyleSheet::escape( str ) + cellEnd;

- str = QString("%1 / %2").arg(photoInfo.exposureTime.isEmpty() ? unavailable : photoInfo.exposureTime)
- .arg(photoInfo.sensitivity.isEmpty() ? unavailable : i18n("%1 ISO").arg(photoInfo.sensitivity));
- if (str.length() > 50) str = str.left(47) + "...";
- metaStr += cellBeg + i18n("Exposure/Sensitivity:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
-
- if (photoInfo.exposureMode.isEmpty() && photoInfo.exposureProgram.isEmpty())
- str = unavailable;
- else if (!photoInfo.exposureMode.isEmpty() && photoInfo.exposureProgram.isEmpty())
- str = photoInfo.exposureMode;
- else if (photoInfo.exposureMode.isEmpty() && !photoInfo.exposureProgram.isEmpty())
- str = photoInfo.exposureProgram;
- else
- str = QString("%1 / %2").arg(photoInfo.exposureMode).arg(photoInfo.exposureProgram);
- if (str.length() > 50) str = str.left(47) + "...";
- metaStr += cellBeg + i18n("Mode/Program:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
+ str = photoInfo.whiteBalance.isEmpty() ? unavailable : photoInfo.whiteBalance;
+ if (str.length() > MAXSTRINGLEN) str = str.left(MAXSTRINGLEN-3) + "...";
+ metaStr += cellBeg + i18n("White Balance:") + cellMid + QStyleSheet::escape( str ) + cellEnd;

- str = photoInfo.flash.isEmpty() ? unavailable : photoInfo.flash;
- if (str.length() > 50) str = str.left(47) + "...";
- metaStr += cellBeg + i18n("Flash:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
-
- str = photoInfo.whiteBalance.isEmpty() ? unavailable : photoInfo.whiteBalance;
- if (str.length() > 50) str = str.left(47) + "...";
- metaStr += cellBeg + i18n("White Balance:") + cellMid + QStyleSheet::escape( str ) + cellEnd;
-
- tip += metaStr;
-
+ tip += metaStr;
+ }
+
// -- digiKam properties ------------------------------------------

tip += headBeg + i18n("digiKam Properties") + headEnd;
@ -437,7 +442,7 @
(*it).remove(0, 1);

str = tagPaths.join(", ");
- if (str.length() > 50) str = str.left(47) + "...";
+ if (str.length() > MAXSTRINGLEN) str = str.left(MAXSTRINGLEN-3) + "...";
tip += cellBeg + i18n("Tags:") + cellMid + str + cellEnd;

str.fill( '*', info->rating() );
@ -451,7 +456,7 @
{
QString str = input.simplifyWhiteSpace();
str = QStyleSheet::escape(str);
- uint maxLen = 30;
+ uint maxLen = MAXSTRINGLEN;

if (str.length() <= maxLen)
return str;
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 121367] Add properties tab to digiKam and (especially) IE

In reply to this post by Bugzilla from mikmach@wp.pl