Contribution: Getting started

[Koushik S]

Hello,

    I'm interested in contributing to the project and needed some guidance on that. I have compiled and installed digikam from source, and went through some of the bugs posted at the bugtracking system.

    I found Bug 306767 (https://bugs.kde.org/show_bug.cgi?id=306767) to be a simple bugfix (I think) with some help. I started to understand a bit of the codebase, and I found that the selection is done by the drawFocusRect in the itemviewimagedelegate.cpp file, but I'm not sure how to move on from there. Any guidance would be helpful.

--

regards,

Koushik. S

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Hi,

Thanks for your help.

Please use exclusively git/master code to hack and make patches.
Patches must be posted to relevant bugzilla entries.

Rename action is managed on top level here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/main/digikamapp.cpp#L1021

This call this method in view :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/digikamview.cpp#L1822

redirected to icon-view here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/items/digikamimageview.cpp#L651

Which launch rename dialog. The current selection is passed
byDigikamView::selectedUrls(). Rename dialog perform files renaming in
background and digiKam ScanController will detect files changes from
file system. icon-view contents will change accordingly with
ScanController results.

So, the IconView selection to restore is not simple to do. You must
take a care about original file names which will be changed by rename
tool, wait ScanController end and restore selection.

Best

Gilles Caulier

2014-10-21 19:24 GMT+02:00 Koushik S <[hidden email]>:

> Hello,
>
>     I'm interested in contributing to the project and needed some guidance
> on that. I have compiled and installed digikam from source, and went through
> some of the bugs posted at the bugtracking system.
>
>     I found Bug 306767 (https://bugs.kde.org/show_bug.cgi?id=306767) to be a
> simple bugfix (I think) with some help. I started to understand a bit of the
> codebase, and I found that the selection is done by the drawFocusRect in the
> itemviewimagedelegate.cpp file, but I'm not sure how to move on from there.
> Any guidance would be helpful.
>
> --
> regards,
> Koushik. S
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Koushik,

Patch applied to git/master and bug #306767 closed.

Do you plan to work on another bugzilla entry ?

Best

Gilles Caulier

2014-10-22 16:16 GMT+02:00 Gilles Caulier <[hidden email]>:

> Hi,
>
> Thanks for your help.
>
> Please use exclusively git/master code to hack and make patches.
> Patches must be posted to relevant bugzilla entries.
>
> Rename action is managed on top level here :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/main/digikamapp.cpp#L1021
>
> This call this method in view :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/digikamview.cpp#L1822
>
> redirected to icon-view here :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/items/digikamimageview.cpp#L651
>
> Which launch rename dialog. The current selection is passed
> byDigikamView::selectedUrls(). Rename dialog perform files renaming in
> background and digiKam ScanController will detect files changes from
> file system. icon-view contents will change accordingly with
> ScanController results.
>
> So, the IconView selection to restore is not simple to do. You must
> take a care about original file names which will be changed by rename
> tool, wait ScanController end and restore selection.
>
> Best
>
> Gilles Caulier
>
> 2014-10-21 19:24 GMT+02:00 Koushik S <[hidden email]>:
>> Hello,
>>
>>     I'm interested in contributing to the project and needed some guidance
>> on that. I have compiled and installed digikam from source, and went through
>> some of the bugs posted at the bugtracking system.
>>
>>     I found Bug 306767 (https://bugs.kde.org/show_bug.cgi?id=306767) to be a
>> simple bugfix (I think) with some help. I started to understand a bit of the
>> codebase, and I found that the selection is done by the drawFocusRect in the
>> itemviewimagedelegate.cpp file, but I'm not sure how to move on from there.
>> Any guidance would be helpful.
>>
>> --
>> regards,
>> Koushik. S
>>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Koushik S]

Hi,

That's great! And yes, I do plan on working on another bugfix, specifically, Bug 335661 (https://bugs.kde.org/show_bug.cgi?id=335661). I'm still sifting through the source code to understand how it works.

On Thu, Oct 23, 2014 at 6:37 PM, Gilles Caulier <[hidden email]> wrote:

Koushik,

Patch applied to git/master and bug #306767 closed.

Do you plan to work on another bugzilla entry ?

Best

Gilles Caulier

2014-10-22 16:16 GMT+02:00 Gilles Caulier <[hidden email]>:
> Hi,
>
> Thanks for your help.
>
> Please use exclusively git/master code to hack and make patches.
> Patches must be posted to relevant bugzilla entries.
>
> Rename action is managed on top level here :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/main/digikamapp.cpp#L1021
>
> This call this method in view :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/digikamview.cpp#L1822
>
> redirected to icon-view here :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/items/digikamimageview.cpp#L651
>
> Which launch rename dialog. The current selection is passed
> byDigikamView::selectedUrls(). Rename dialog perform files renaming in
> background and digiKam ScanController will detect files changes from
> file system. icon-view contents will change accordingly with
> ScanController results.
>
> So, the IconView selection to restore is not simple to do. You must
> take a care about original file names which will be changed by rename
> tool, wait ScanController end and restore selection.
>
> Best
>
> Gilles Caulier
>
> 2014-10-21 19:24 GMT+02:00 Koushik S <[hidden email]>:
>> Hello,
>>
>>     I'm interested in contributing to the project and needed some guidance
>> on that. I have compiled and installed digikam from source, and went through
>> some of the bugs posted at the bugtracking system.
>>
>>     I found Bug 306767 (https://bugs.kde.org/show_bug.cgi?id=306767) to be a
>> simple bugfix (I think) with some help. I started to understand a bit of the
>> codebase, and I found that the selection is done by the drawFocusRect in the
>> itemviewimagedelegate.cpp file, but I'm not sure how to move on from there.
>> Any guidance would be helpful.
>>
>> --
>> regards,
>> Koushik. S
>>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

--

regards,

Koushik. S

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Koushik,

I will post all technical details to bug #335661 after noon (i take
train to go to Paris today)

Best

Gilles Caulier

2014-10-23 15:48 GMT+02:00 Koushik S <[hidden email]>:

> Hi,
>
> That's great! And yes, I do plan on working on another bugfix, specifically,
> Bug 335661 (https://bugs.kde.org/show_bug.cgi?id=335661). I'm still sifting
> through the source code to understand how it works.
>
> On Thu, Oct 23, 2014 at 6:37 PM, Gilles Caulier <[hidden email]>
> wrote:
>>
>> Koushik,
>>
>> Patch applied to git/master and bug #306767 closed.
>>
>> Do you plan to work on another bugzilla entry ?
>>
>> Best
>>
>> Gilles Caulier
>>
>> 2014-10-22 16:16 GMT+02:00 Gilles Caulier <[hidden email]>:
>> > Hi,
>> >
>> > Thanks for your help.
>> >
>> > Please use exclusively git/master code to hack and make patches.
>> > Patches must be posted to relevant bugzilla entries.
>> >
>> > Rename action is managed on top level here :
>> >
>> >
>> > https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/main/digikamapp.cpp#L1021
>> >
>> > This call this method in view :
>> >
>> >
>> > https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/digikamview.cpp#L1822
>> >
>> > redirected to icon-view here :
>> >
>> >
>> > https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/items/digikamimageview.cpp#L651
>> >
>> > Which launch rename dialog. The current selection is passed
>> > byDigikamView::selectedUrls(). Rename dialog perform files renaming in
>> > background and digiKam ScanController will detect files changes from
>> > file system. icon-view contents will change accordingly with
>> > ScanController results.
>> >
>> > So, the IconView selection to restore is not simple to do. You must
>> > take a care about original file names which will be changed by rename
>> > tool, wait ScanController end and restore selection.
>> >
>> > Best
>> >
>> > Gilles Caulier
>> >
>> > 2014-10-21 19:24 GMT+02:00 Koushik S <[hidden email]>:
>> >> Hello,
>> >>
>> >>     I'm interested in contributing to the project and needed some
>> >> guidance
>> >> on that. I have compiled and installed digikam from source, and went
>> >> through
>> >> some of the bugs posted at the bugtracking system.
>> >>
>> >>     I found Bug 306767 (https://bugs.kde.org/show_bug.cgi?id=306767) to
>> >> be a
>> >> simple bugfix (I think) with some help. I started to understand a bit
>> >> of the
>> >> codebase, and I found that the selection is done by the drawFocusRect
>> >> in the
>> >> itemviewimagedelegate.cpp file, but I'm not sure how to move on from
>> >> there.
>> >> Any guidance would be helpful.
>> >>
>> >> --
>> >> regards,
>> >> Koushik. S
>> >>
>> >> _______________________________________________
>> >> Digikam-devel mailing list
>> >> [hidden email]
>> >> https://mail.kde.org/mailman/listinfo/digikam-devel
>> >>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
>
>
> --
> regards,
> Koushik. S
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Koushik S]

Hello,

    I went through the source code to figure out more about the working, and here's what I found out.

-- slotCrop() handles the cropping after the shortcut is triggered
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/widgets/canvas.cpp#L358

-- The cropping itself is handled by the crop function is dimg.cpp
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dimg/dimg.cpp#L2207

-- I think the viewer update takes place imagepreviewitem.cpp, but I might be wrong
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/widgets/imagepreviewitem.cpp#L57

I'm not sure how to go about from here. The preview only messes up when the image is cropped as a vertical band, which I guess means that cropping is not an issue. I began looking into the zoom functions in graphicsdimgview.cpp, and hope to find something there.

I'd like to have your say on it though.

On Fri, Oct 24, 2014 at 1:20 PM, Gilles Caulier <[hidden email]> wrote:

Koushik,

I will post all technical details to bug #335661 after noon (i take
train to go to Paris today)

Best

Gilles Caulier

2014-10-23 15:48 GMT+02:00 Koushik S <[hidden email]>:
> Hi,
>
> That's great! And yes, I do plan on working on another bugfix, specifically,
> Bug 335661 (https://bugs.kde.org/show_bug.cgi?id=335661). I'm still sifting
> through the source code to understand how it works.
>
> On Thu, Oct 23, 2014 at 6:37 PM, Gilles Caulier <[hidden email]>
> wrote:
>>
>> Koushik,
>>
>> Patch applied to git/master and bug #306767 closed.
>>
>> Do you plan to work on another bugzilla entry ?
>>
>> Best
>>
>> Gilles Caulier
>>
>> 2014-10-22 16:16 GMT+02:00 Gilles Caulier <[hidden email]>:
>> > Hi,
>> >
>> > Thanks for your help.
>> >
>> > Please use exclusively git/master code to hack and make patches.
>> > Patches must be posted to relevant bugzilla entries.
>> >
>> > Rename action is managed on top level here :
>> >
>> >
>> > https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/main/digikamapp.cpp#L1021
>> >
>> > This call this method in view :
>> >
>> >
>> > https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/digikamview.cpp#L1822
>> >
>> > redirected to icon-view here :
>> >
>> >
>> > https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/items/digikamimageview.cpp#L651
>> >
>> > Which launch rename dialog. The current selection is passed
>> > byDigikamView::selectedUrls(). Rename dialog perform files renaming in
>> > background and digiKam ScanController will detect files changes from
>> > file system. icon-view contents will change accordingly with
>> > ScanController results.
>> >
>> > So, the IconView selection to restore is not simple to do. You must
>> > take a care about original file names which will be changed by rename
>> > tool, wait ScanController end and restore selection.
>> >
>> > Best
>> >
>> > Gilles Caulier
>> >
>> > 2014-10-21 19:24 GMT+02:00 Koushik S <[hidden email]>:
>> >> Hello,
>> >>
>> >>     I'm interested in contributing to the project and needed some
>> >> guidance
>> >> on that. I have compiled and installed digikam from source, and went
>> >> through
>> >> some of the bugs posted at the bugtracking system.
>> >>
>> >>     I found Bug 306767 (https://bugs.kde.org/show_bug.cgi?id=306767) to
>> >> be a
>> >> simple bugfix (I think) with some help. I started to understand a bit
>> >> of the
>> >> codebase, and I found that the selection is done by the drawFocusRect
>> >> in the
>> >> itemviewimagedelegate.cpp file, but I'm not sure how to move on from
>> >> there.
>> >> Any guidance would be helpful.
>> >>
>> >> --
>> >> regards,
>> >> Koushik. S
>> >>
>> >> _______________________________________________
>> >> Digikam-devel mailing list
>> >> [hidden email]
>> >> https://mail.kde.org/mailman/listinfo/digikam-devel
>> >>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
>
>
> --
> regards,
> Koushik. S
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

--

regards,

Koushik. S

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel