Color theme plan...

[Gilles Caulier-4]

Hi all,

I plan to make severals changes in Theme Manager in a near future. My
plan is to remove all customized XML theme and to use KDE color theme
instead, as KDenlive do...

http://www.flickr.com/photos/digikam/5595401580/sizes/o/in/photostream/

The goal is to fix all mistakes with colors melange reported in
bugzilla. Also, this will simplify theme management :

- there is a complex color assignment in this method :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L302

This code have been back-ported from Amarok 1.4 by me in the pass.
Sound like not all colors mix are perfect in GUI.

- there are a lots of KDE color theme schemes down-loadable by KDE
control panel.

Only ThemeEngine class will be touch by this change. 2 others classes
still unchanged. In Theme, we populate all KDE color themes available
and we assign it to digiKam when user select one of them in theme menu
entry. XML interface will be removed, but all the rest of color
assignment still there, especially this method :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L302

In fact, we assign palette from KDE theme to digiKam and we build
theme by this method. In changePalette() method we just assign the
palette and no more...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I plan to make severals changes in Theme Manager in a near future. My
> plan is to remove all customized XML theme and to use KDE color theme
> instead, as KDenlive do...

It's fine for me, but I use the default colors anyway so I dont care too much.
I think there are some custom gradients in some themes which would probably
need to be removed.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

I guess this sounds fine, we definitely need to fix theming issues, either  
by removing it completely (not so good) or by adapting to the KDE theming  
(good :-) ).

Andi

On Wed, 06 Apr 2011 16:21:05 +0200, Gilles Caulier  
<[hidden email]> wrote:

> Hi all,
>
> I plan to make severals changes in Theme Manager in a near future. My
> plan is to remove all customized XML theme and to use KDE color theme
> instead, as KDenlive do...
>
> http://www.flickr.com/photos/digikam/5595401580/sizes/o/in/photostream/
>
> The goal is to fix all mistakes with colors melange reported in
> bugzilla. Also, this will simplify theme management :
>
> - there is a complex color assignment in this method :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L302
>
> This code have been back-ported from Amarok 1.4 by me in the pass.
> Sound like not all colors mix are perfect in GUI.
>
> - there are a lots of KDE color theme schemes down-loadable by KDE
> control panel.
>
> Only ThemeEngine class will be touch by this change. 2 others classes
> still unchanged. In Theme, we populate all KDE color themes available
> and we assign it to digiKam when user select one of them in theme menu
> entry. XML interface will be removed, but all the rest of color
> assignment still there, especially this method :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L302
>
> In fact, we assign palette from KDE theme to digiKam and we build
> theme by this method. In changePalette() method we just assign the
> palette and no more...
>
> Gilles Caulier
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Code patched on git master.

It still an important hard-coded value in source code :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L201

This color is used to draw rating and other digiKam properties in GUI.
I use orange like color from Dolphin rating icon.

Perhaps we can do better, for ex to compute this color to have the
best contrast with background color accordingly with KDE color scheme
selected in setup menu.

Same for this less important color :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L216

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L223

Suggestion are welcome...

Second point : as you can see, we don't use now the gradient and other
color effect in icon view. We have 2 solution :

- remove it definitively from source code to simplify implementation.
Typically this consist to remove Texture class and perhaps Theme
class. This depend of complexity.

- re-use it. To do that, we can provide customized KDE color scheme
config file, including standard KDE settings + digiKam specific
settings for gui texturing. In settings menu, we can list standard KDE
file and use simple Theme instance + digiKam specific files which can
play in-deep with Theme configuration.

KDE color scheme files are KDE RC file based text file :

[gilles@localhost core]$ cat /usr/share/apps/color-schemes/WontonSoup.colors
[ColorEffects:Disabled]
ColorAmount=0
ColorEffect=0
ContrastAmount=0.65
ContrastEffect=1
IntensityAmount=0.25
IntensityEffect=2

[ColorEffects:Inactive]
ColorAmount=0
ColorEffect=0
ContrastAmount=0.25
ContrastEffect=2
IntensityAmount=0.05
IntensityEffect=2

[Colors:Button]
BackgroundAlternate=90,98,109
BackgroundNormal=82,88,99
DecorationFocus=125,141,153
DecorationHover=119,149,179
ForegroundActive=255,255,255
ForegroundInactive=135,143,154
ForegroundLink=156,212,255
ForegroundNegative=225,150,209
ForegroundNeutral=218,198,115
ForegroundNormal=210,222,240
ForegroundPositive=145,221,100
ForegroundVisited=64,128,255

[Colors:Selection]
BackgroundAlternate=111,126,144
BackgroundNormal=120,136,156
DecorationFocus=125,141,153
DecorationHover=119,149,179
ForegroundActive=255,255,255
ForegroundInactive=174,192,218
ForegroundLink=156,212,255
ForegroundNegative=225,150,209
ForegroundNeutral=218,198,115
ForegroundNormal=209,225,244
ForegroundPositive=145,221,100
ForegroundVisited=64,128,255
...

It's easy to add a digiKam section with customized settings for
texturing stuff...


Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

>
> This color is used to draw rating and other digiKam properties in GUI.
> I use orange like color from Dolphin rating icon.
>
> Perhaps we can do better, for ex to compute this color to have the
> best contrast with background color accordingly with KDE color scheme
> selected in setup menu.

My wish would be a blue color with the default theme again ;-)
I dont know how it was done with other themes, but for the default blue/white
colors, blue is the color also found in the category header and for selected
items, bringing in yellow text and stars adds a new color which is not found
anywhere else.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2011/4/7 Marcel Wiesweg <[hidden email]>:

>
>>
>> This color is used to draw rating and other digiKam properties in GUI.
>> I use orange like color from Dolphin rating icon.
>>
>> Perhaps we can do better, for ex to compute this color to have the
>> best contrast with background color accordingly with KDE color scheme
>> selected in setup menu.
>
> My wish would be a blue color with the default theme again ;-)
> I dont know how it was done with other themes, but for the default blue/white
> colors, blue is the color also found in the category header and for selected
> items, bringing in yellow text and stars adds a new color which is not found
> anywhere else.

My last patch from git Master must fix this problem now...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel