Building of the new digikam on SuSE 9.3 (rc2-tarballs)

[Dr. Ing. Dieter Jurzitza]

Dear listmembers,
this is just to let you know that with a single patch one can build both
digikam and digikamimageplugins as of the rc2-tarballs on SuSE 9.3.

I attach the patch I use and found by the help of the digikam developers; this
may readily be fixed in CVS,
digikamimageplugins built "as is" on SuSE 9.3, might be similar on other
distributions still using gcc-3.3.

Thanks to the developers!

To whom it may concern,
take care



Dieter Jurzitza

--
-----------------------------------------------------------

                               |
                                \
                 /\_/\           |
                | ~x~ |/-----\   /
                 \   /-       \_/
  ^^__   _        /  _  ____   /
 <°°__ \- \_/     |  |/    |  |
  ||  ||         _| _|    _| _|

if you really want to see the pictures above - use some font
with constant spacing like courier! :-)
-----------------------------------------------------------

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gerhard Kulzer]

Am Saturday 03 March 2007 schrieb Dieter Jurzitza:

> Dear listmembers,
> this is just to let you know that with a single patch one can build both
> digikam and digikamimageplugins as of the rc2-tarballs on SuSE 9.3.
>
> I attach the patch I use and found by the help of the digikam developers;
> this may readily be fixed in CVS,
> digikamimageplugins built "as is" on SuSE 9.3, might be similar on other
> distributions still using gcc-3.3.
>
> Thanks to the developers!
>
> To whom it may concern,
> take care
>
>
>
> Dieter Jurzitza

Thank you very much Dieter, the changes have been commited to SVN. The
0.9.1-final will be released today.

Gerhard

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-4]

Gerhard,

 

I suspect than QString::null <==> QString() is a wrong way. The tip given by http://www.englishbreakfastnetwork.org/ is perhaps right about English words typo fix, but not about QT/ C++ implementation. Please add a notice in HACKING file from svn...

 

My viewpoint is simple : an automatized script cannot remplace a real developper witch compile the application and test in live (:=))) 

 

Gilles

 

2007/3/4, Gerhard Kulzer <[hidden email]>:

Am Saturday 03 March 2007 schrieb Dieter Jurzitza:

> Dear listmembers,
> this is just to let you know that with a single patch one can build both
> digikam and digikamimageplugins as of the rc2-tarballs on SuSE 9.3.
>
> I attach the patch I use and found by the help of the digikam developers;
> this may readily be fixed in CVS,
> digikamimageplugins built "as is" on SuSE 9.3, might be similar on other
> distributions still using gcc-3.3.
>
> Thanks to the developers!
>
> To whom it may concern,
> take care
>
>
>
> Dieter Jurzitza

Thank you very much Dieter, the changes have been commited to SVN. The
0.9.1-final will be released today.

Gerhard

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Dr. Ing. Dieter Jurzitza]

Dear Gilles,
what about something like
// test for gcc
#include <ansidecl.h>

#if GCC_VERSION <= 3003
        #define QSTRING Qstring::null
#else
        #define QSTRING Qstring()
#fi
and then in albumfolderview.cpp:

@@ -1171,7 +1171,7 @@

        QString libraryPath = parent->folderPath();

- KFileDialog dlg(QString(), "inode/directory", this, "importFolder", true);
+ KFileDialog dlg(QSTRING, "inode/directory", this, "importFolder", true);
        glg.setMode(KFile::Directory | KFile::Files);
        if(dlg.exec() != QDialog::Accepted)
            return;

but I heard about real C-Programmers disliking preprocessor directives :-))).

Nothing serious, just my 2 cents here,
thank you for looking into this,
take care


Dieter Jurzitza

Am Sonntag, 4. März 2007 08:40 schrieb Gilles Caulier:
*******
> I suspect than QString::null <==> QString() is a wrong way. The tip given
*******
--
-----------------------------------------------------------

                               |
                                \
                 /\_/\           |
                | ~x~ |/-----\   /
                 \   /-       \_/
  ^^__   _        /  _  ____   /
 <°°__ \- \_/     |  |/    |  |
  ||  ||         _| _|    _| _|

if you really want to see the pictures above - use some font
with constant spacing like courier! :-)
-----------------------------------------------------------
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-4]

I'm not favorable to use preprocessor. It's old C style witch reduce readability of source code.

 

Normaly all compile fine now with gcc 3.x. Also we will prepare the QT4 port witch fix all these compilation problems.

 

Gilles 

 

2007/3/4, Dieter Jurzitza <[hidden email]>:

Dear Gilles,
what about something like
// test for gcc
#include <ansidecl.h>

#if GCC_VERSION <= 3003
       #define QSTRING Qstring::null
#else
       #define QSTRING Qstring()
#fi
and then in albumfolderview.cpp:

@@ -1171,7 +1171,7 @@

       QString libraryPath = parent->folderPath();

-       KFileDialog dlg(QString(), "inode/directory", this, "importFolder", true);
+       KFileDialog dlg(QSTRING, "inode/directory", this, "importFolder", true);
       glg.setMode(KFile::Directory | KFile::Files);
       if(dlg.exec() != QDialog::Accepted)
           return;

but I heard about real C-Programmers disliking preprocessor directives :-))).

Nothing serious, just my 2 cents here,
thank you for looking into this,
take care


Dieter Jurzitza

Am Sonntag, 4. März 2007 08:40 schrieb Gilles Caulier:
*******
> I suspect than QString::null <==> QString() is a wrong way. The tip given
*******
--
-----------------------------------------------------------

                              |
                               \
                /\_/\           |
               | ~x~ |/-----\   /
                \   /-       \_/
^^__   _        /  _  ____   /
<°°__ \- \_/     |  |/    |  |
||  ||         _| _|    _| _|

if you really want to see the pictures above - use some font
with constant spacing like courier! :-)
-----------------------------------------------------------
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users