Build error with digikam 2.9.0 under Fedora 17

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Build error with digikam 2.9.0 under Fedora 17

Brian Morrison
I'm seeing this error during the final install stage of my .spec file:

+ desktop-file-validate /home/bdm/rpmbuild/BUILDROOT/digikam-2.9.0-1.fc17.x86_64/usr/share/applications/kde4/kipiplugins.desktop
/home/bdm/rpmbuild/BUILDROOT/digikam-2.9.0-1.fc17.x86_64/usr/share/applications/kde4/kipiplugins.desktop:
error: file contains group "KipiPlugins Entry", but groups extending the format should start with "X-"

Looking at it I think the kipiplugins.desktop file should have a
different name for the version string starting with X-.

This is also broken in the Fedora Koji packages so it would help
everyone who gets packages to install/build from there too.

Is there a simple fix for this that won't break anything? I assume it's
a KDE thing...

--

Brian Morrison

                "I am not young enough to know everything"
                                                          Oscar Wilde
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error with digikam 2.9.0 under Fedora 17

Gilles Caulier-4
This have been fixed for next 3.0.0. Look here, fixed is attached to
report. You can backport it easily :

https://bugs.kde.org/show_bug.cgi?id=306193

Gilles Caulier

2012/9/8 Brian Morrison <[hidden email]>:

> I'm seeing this error during the final install stage of my .spec file:
>
> + desktop-file-validate /home/bdm/rpmbuild/BUILDROOT/digikam-2.9.0-1.fc17.x86_64/usr/share/applications/kde4/kipiplugins.desktop
> /home/bdm/rpmbuild/BUILDROOT/digikam-2.9.0-1.fc17.x86_64/usr/share/applications/kde4/kipiplugins.desktop:
> error: file contains group "KipiPlugins Entry", but groups extending the format should start with "X-"
>
> Looking at it I think the kipiplugins.desktop file should have a
> different name for the version string starting with X-.
>
> This is also broken in the Fedora Koji packages so it would help
> everyone who gets packages to install/build from there too.
>
> Is there a simple fix for this that won't break anything? I assume it's
> a KDE thing...
>
> --
>
> Brian Morrison
>
>                 "I am not young enough to know everything"
>                                                           Oscar Wilde
> _______________________________________________
> Digikam-users mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-users
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error with digikam 2.9.0 under Fedora 17

Brian Morrison
On Sat, 8 Sep 2012 17:06:01 +0200
Gilles Caulier <[hidden email]> wrote:

> This have been fixed for next 3.0.0. Look here, fixed is attached to
> report. You can backport it easily :
>
> https://bugs.kde.org/show_bug.cgi?id=306193

Right, OK.

Looking at the source for 2.9.0 I have an extra/libkipi directory,
however in the pluginloader.cpp file in it there are no QMap strings
and not a single KipiPlugins Entry string.

So which file should I be patching?

--

Brian Morrison

                "I am not young enough to know everything"
                                                          Oscar Wilde
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error with digikam 2.9.0 under Fedora 17

Brian Morrison
On Sat, 8 Sep 2012 16:58:29 +0100
Brian Morrison <[hidden email]> wrote:

> So which file should I be patching?

Ah, it should be:

extra/kipi-plugins/common/libkipiplugins/kipiplugins.desktop.cmake

I assume that the 3.0.0 code base has moved things about?

--

Brian Morrison

                "I am not young enough to know everything"
                                                          Oscar Wilde
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error with digikam 2.9.0 under Fedora 17

Gilles Caulier-4
yes, it's the same.

libkipi is a little bit different due to new implementation, but patch
fix same function between 2x and 3x...

Gilles Caulier

2012/9/8 Brian Morrison <[hidden email]>:

> On Sat, 8 Sep 2012 16:58:29 +0100
> Brian Morrison <[hidden email]> wrote:
>
>> So which file should I be patching?
>
> Ah, it should be:
>
> extra/kipi-plugins/common/libkipiplugins/kipiplugins.desktop.cmake
>
> I assume that the 3.0.0 code base has moved things about?
>
> --
>
> Brian Morrison
>
>                 "I am not young enough to know everything"
>                                                           Oscar Wilde
> _______________________________________________
> Digikam-users mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-users
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error with digikam 2.9.0 under Fedora 17

Brian Morrison
On Sat, 8 Sep 2012 18:39:20 +0200
Gilles Caulier <[hidden email]> wrote:

> yes, it's the same.
>
> libkipi is a little bit different due to new implementation, but patch
> fix same function between 2x and 3x...

OK, I'm a bit confused about that because the file contents in the web
CVS system is totally different to the file I needed to patch, but I
have now managed to build and install 2.9.0 on Fedora 17 and it seems to
work so far.

Thanks for the help.

--

Brian Morrison

                "I am not young enough to know everything"
                                                          Oscar Wilde
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users