digiKam › digikam-users

Bug fix suggestion

classic Classic list List threaded Threaded
♦
♦
 3 messages Options
Dave Brown
Reply | Threaded
Open this post in threaded view
♦
♦
|

Bug fix suggestion

Dave Brown
I have not reported this as I have never done something like this but a suggestion to fix build fail when libqtav is installed but not found.


Linux acer-laptop 4.4.0-21-generic #37-Ubuntu SMP Mon Apr 18 18:34:49 UTC 2016 i686 i686 i686 GNU/Linux

dpkg -l libqtav
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                      Version           Architecture      Description
+++-=========================-=================-=================-=======================================================
ii  libqtav:i386              1.11.0~git170108- i386              QtAV library


----------------------------------------------------------------------------------------------------------------------

if (NOT APPLE)
    find_path(QTAV_CORE_INCLUDE_DIR
              NAMES QtAV.h
              HINTS ${_qt5_install_prefix}                                           # For MXE
                    ${_qt5_install_prefix}/../qt5/include                            # For Mageia
                    ${_qt5_install_prefix}/../../include/qt5                         # For Suse
                    ${_qt5_install_prefix}/../../../include/x86_64-linux-gnu/qt5     # For Debian
++ ${_qt5_install_prefix}/../../../include/i386-linux-gnu/qt5 # For Mint32 (possibly all 32 Debian)
             PATH_SUFFIXES QtAV
    )

    find_path(QTAV_WIDGETS_INCLUDE_DIR
              NAMES QtAVWidgets.h
              HINTS ${_qt5_install_prefix}                                           # For MXE
                    ${_qt5_install_prefix}/../qt5/include                            # For Mageia
                    ${_qt5_install_prefix}/../../include/qt5                         # For Suse
                    ${_qt5_install_prefix}/../../../include/x86_64-linux-gnu/qt5     # For Debian
++                ${_qt5_install_prefix}/../../../include/i386-linux-gnu/qt5 # For Mint32 (possibly all 32 Debian)
              PATH_SUFFIXES QtAVWidgets
    )


Dave Brown
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Bug fix suggestion

Gilles Caulier-4
Yes, please create an entry in bugzilla with the patch attached. We need to have a trace in time, and bugzilla is perfect for that. 

Note : next QtAV will be ported to CMake. I guide the QtAv team in this way. This want mean that a puzzled Cmake script to find QtAV will not be required in the future.

 Thanks in advance

Gilles Caulier

2017-01-27 5:47 GMT+01:00 Dave Brown <[hidden email]>:
I have not reported this as I have never done something like this but a suggestion to fix build fail when libqtav is installed but not found.


Linux acer-laptop 4.4.0-21-generic #37-Ubuntu SMP Mon Apr 18 18:34:49 UTC 2016 i686 i686 i686 GNU/Linux

dpkg -l libqtav
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                      Version           Architecture      Description
+++-=========================-=================-=================-=======================================================
ii  libqtav:i386              1.11.0~git170108- i386              QtAV library


----------------------------------------------------------------------------------------------------------------------

if (NOT APPLE)
    find_path(QTAV_CORE_INCLUDE_DIR
              NAMES QtAV.h
              HINTS ${_qt5_install_prefix}                                           # For MXE
                    ${_qt5_install_prefix}/../qt5/include                            # For Mageia
                    ${_qt5_install_prefix}/../../include/qt5                         # For Suse
                    ${_qt5_install_prefix}/../../../include/x86_64-linux-gnu/qt5     # For Debian
++ ${_qt5_install_prefix}/../../../include/i386-linux-gnu/qt5 # For Mint32 (possibly all 32 Debian)
             PATH_SUFFIXES QtAV
    )

    find_path(QTAV_WIDGETS_INCLUDE_DIR
              NAMES QtAVWidgets.h
              HINTS ${_qt5_install_prefix}                                           # For MXE
                    ${_qt5_install_prefix}/../qt5/include                            # For Mageia
                    ${_qt5_install_prefix}/../../include/qt5                         # For Suse
                    ${_qt5_install_prefix}/../../../include/x86_64-linux-gnu/qt5     # For Debian
++                ${_qt5_install_prefix}/../../../include/i386-linux-gnu/qt5 # For Mint32 (possibly all 32 Debian)
              PATH_SUFFIXES QtAVWidgets
    )


Dave Brown
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Bug fix suggestion

Gilles Caulier-4

2017-02-23 21:58 GMT+01:00 Gilles Caulier <[hidden email]>:
Yes, please create an entry in bugzilla with the patch attached. We need to have a trace in time, and bugzilla is perfect for that. 

Note : next QtAV will be ported to CMake. I guide the QtAv team in this way. This want mean that a puzzled Cmake script to find QtAV will not be required in the future.

 Thanks in advance

Gilles Caulier

2017-01-27 5:47 GMT+01:00 Dave Brown <[hidden email]>:
I have not reported this as I have never done something like this but a suggestion to fix build fail when libqtav is installed but not found.


Linux acer-laptop 4.4.0-21-generic #37-Ubuntu SMP Mon Apr 18 18:34:49 UTC 2016 i686 i686 i686 GNU/Linux

dpkg -l libqtav
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                      Version           Architecture      Description
+++-=========================-=================-=================-=======================================================
ii  libqtav:i386              1.11.0~git170108- i386              QtAV library


----------------------------------------------------------------------------------------------------------------------

if (NOT APPLE)
    find_path(QTAV_CORE_INCLUDE_DIR
              NAMES QtAV.h
              HINTS ${_qt5_install_prefix}                                           # For MXE
                    ${_qt5_install_prefix}/../qt5/include                            # For Mageia
                    ${_qt5_install_prefix}/../../include/qt5                         # For Suse
                    ${_qt5_install_prefix}/../../../include/x86_64-linux-gnu/qt5     # For Debian
++ ${_qt5_install_prefix}/../../../include/i386-linux-gnu/qt5 # For Mint32 (possibly all 32 Debian)
             PATH_SUFFIXES QtAV
    )

    find_path(QTAV_WIDGETS_INCLUDE_DIR
              NAMES QtAVWidgets.h
              HINTS ${_qt5_install_prefix}                                           # For MXE
                    ${_qt5_install_prefix}/../qt5/include                            # For Mageia
                    ${_qt5_install_prefix}/../../include/qt5                         # For Suse
                    ${_qt5_install_prefix}/../../../include/x86_64-linux-gnu/qt5     # For Debian
++                ${_qt5_install_prefix}/../../../include/i386-linux-gnu/qt5 # For Mint32 (possibly all 32 Debian)
              PATH_SUFFIXES QtAVWidgets
    )


Dave Brown
Free forum by Nabble Edit this page