[Bug 309598] New: recent tags menu: existing tags added and shouldn't be

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=309598

            Bug ID: 309598
          Severity: normal
           Version: 2.8.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: recent tags menu: existing tags added and shouldn't be
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Other
            Status: UNCONFIRMED
         Component: Tags
           Product: digikam

When adding new tags, there are added to the context menu Tags > Recently used.
If there is an existing tag and you add another, both are added to recently
used while, most logicaly, only the one asked by the user should be.

Reproducible: Always

Steps to Reproduce:
1. take an image with an existing tag, check it's not in recently used context
menu tags list
2. add a new tag
3.
Actual Results:  
Both old and new tags are in recently used list

Expected Results:  
Only the new one should be.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309598

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
I remember that something like that have been fixed recently. Can you try with
2.9.0 release ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andrew Goodbody]

https://bugs.kde.org/show_bug.cgi?id=309598

Andrew Goodbody <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|2.8.0                       |2.9.0

--- Comment #2 from Andrew Goodbody <[hidden email]> ---
I am seeing this on 2.9.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=309598

--- Comment #3 from [hidden email] ---
I would if I can, but for now, Philipp seems to not have time to update his ppa
(https://launchpad.net/~philip5/+archive/extra) and not really wanted to do
full manual compile, so waiting for now.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=309598

--- Comment #4 from Marcel Wiesweg <[hidden email]> ---
From which UI element do you add the new tag?
The way it is currently implemented, we update the recent-tags list when a tag
is assigned, but the assignment does not check ( and will not, for reason of
performance) if the tag is already assigned.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=309598

--- Comment #5 from [hidden email] ---
for now, I'm using mostly the right panel or context menu/recent tags if tags
is listed there either in thumbnail or preview mode.
Can't use keyboard shortcuts as I have too many tags (outside of a few).
But I think it happens in the 3 cases.

For performance, for sure, it's an extra task but on current desktop, I don't
think the penalty is noticeable (especially if you cache displayed data). On a
laptop (and especially my netbook), probably heavier.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andrew Goodbody]

https://bugs.kde.org/show_bug.cgi?id=309598

--- Comment #6 from Andrew Goodbody <[hidden email]> ---
Marcel, I think you miss the point. When you assign a new tag to an image, all
tags for that image are added to the recently used list, even if they are not
being changed in this operation. This is wrong. Only the tag actually added
should go into the recently used list. This is using the right hand side bar.
eg if an image previously had tags a,b,c,d,e,f,g,h,i,j assigned and then you
assign tag k, then all those tags go into the recently used list.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=309598

--- Comment #7 from Marcel Wiesweg <[hidden email]> ---
Apparently all existing tags are assigned (a no-op for already assigned ones),
resulting in the observed behavior. The underlying problem is that the list is
kept at a very low level. I believe it should be kept more high-level in
TagsCache and co-managed through ImageInfo. Then the cost I mentioned is gone,
due to caching.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=309598

--- Comment #8 from [hidden email] ---
still valid

Test on 3.4 (lubuntu 13.10/kde 4.11.3 main install).  pending on 3.5(macos
10.9/kde 4.11.4/macports, mostly w network share)(long collection scanning...)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309598

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.9.0                       |3.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309598

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|recent tags menu: existing  |"Recent Tags" menu show
                   |tags added and shouldn't be |existing tags added and
                   |                            |shouldn't be

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Julien,

This file still valid using last digiKam 4.2.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309598

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WAITINGFORINFO
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #10 from Gilles Caulier <[hidden email]> ---
This file still valid using last digiKam 4.10.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309598

--- Comment #11 from Gilles Caulier <[hidden email]> ---
New digiKam 4.11.0 is available with official PKG installer for OSX.

https://www.digikam.org/node/740

Can you reproduce the problem with this release ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309598

--- Comment #12 from Gilles Caulier <[hidden email]> ---
digiKam 4.12.0 is out :

https://www.digikam.org/node/741

We need a fresh feedback using this release please...
Thanks in advance.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=309598

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WAITINGFORINFO              |FIXED
   Version Fixed In|                            |5.1.0

--- Comment #13 from [hidden email] ---
With digiKam 5.0.0, this problem is not reproducible.
I close this file now. Don't hesitate to re-open if necessary.
Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=309598

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tags-Engine                 |Usability-Menus

--
You are receiving this mail because:
You are the assignee for the bug.