[Bug 309558] New: Bad inheritance of keyboard shortcut when creating sub-tag

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=309558

            Bug ID: 309558
          Severity: normal
           Version: 2.8.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: Bad inheritance of keyboard shortcut when creating
                    sub-tag
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Other
            Status: UNCONFIRMED
         Component: Usability
           Product: digikam

When creating a sub-tag of a tag, it seems the children inherits properties of
his parents. It includes keyboard shortcut which is obviously bad and create a
conflict which makes the shortcut useless.
Shortcut should be exclude from inheritance.


Reproducible: Always

Steps to Reproduce:
1. have a tag with a shortcut defined
2. create a sub-tag
3. use the shortcut of the first tag
Actual Results:  
gui says there is a conflict: nothing done

Expected Results:  
write the corresponding tag

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309558

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Usability                   |Tags

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=309558

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |3.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/1d0973cbdf8f57a2cf3329b
                   |                            |e1fcea0587f43df47

--- Comment #1 from Marcel Wiesweg <[hidden email]> ---
Git commit 1d0973cbdf8f57a2cf3329be1fcea0587f43df47 by Marcel Wiesweg.
Committed on 12/01/2013 at 22:05.
Pushed by mwiesweg into branch 'master'.

Do not keep shortcut of parent tag in New-Tag-Dialog: Would only create a
conflict.
FIXED-IN: 3.0.0

M  +2    -1    NEWS
M  +3    -2    digikam/tags/tageditdlg.cpp

http://commits.kde.org/digikam/1d0973cbdf8f57a2cf3329be1fcea0587f43df47

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309558

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
     Ever confirmed|0                           |1

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Marcel,

With your, TagEdit dialog never show the shortcuts already assigned to a tag
from DB.

It's very problematic, because user (me) think that tag has no shortcut
assigned, and i try to re-assign it without success. But in background, yes
shortcuts work perfectly...

You commit remove assignation of tag KS from DB through this line :

KShortcut ksc(album->property(TagPropertyName::tagKeyboardShortcut()));
d->keySeqWidget->setKeySequence(ksc.primary(), KKeySequenceWidget::NoValidate);

And there is no other code lines to show shortcut details by keySeqWidget. This
one still always empty.

Q : What's the purpose of this commit ? If it fix something, it create a
regression here...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309558

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.8.0                       |3.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=309558

--- Comment #3 from Marcel Wiesweg <[hidden email]> ---
Ok, then I edited the wrong location obviously.
The original bug was about a new tag being assigned the same shortcut as the
parent, which is contradictory. A new tag should have no shortcut assigned by
default.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309558

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|3.0.0                       |
            Version|3.3.0                       |4.0.0-beta1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=309558

--- Comment #4 from [hidden email] ---
worked on linux/3.4 but with the side-effect mentionned by Gilles

Test on 3.4 (lubuntu 13.10/kde 4.11.3 main install).  pending on 3.5(macos
10.9/kde 4.11.4/macports, mostly w network share)(long collection scanning...)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309558

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0.0-beta1                 |4.0.0

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Marcel,

The side effect of your previous patch is also reported in bug #338509

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309558

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|http://commits.kde.org/digi |http://commits.kde.org/digi
                   |kam/1d0973cbdf8f57a2cf3329b |kam/e0877e3205911cd42a792c7
                   |e1fcea0587f43df47           |d071d638831f4cdec
   Version Fixed In|                            |4.4.0
             Status|REOPENED                    |RESOLVED

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Git commit e0877e3205911cd42a792c7d071d638831f4cdec by Gilles Caulier.
Committed on 13/09/2014 at 09:42.
Pushed by cgilles into branch 'master'.

Add rules to not inherit of parent tags keyboard shortcut when creating ne tag.
Editing tags properties must show already assigned tag keyboard shortcut.
Related: bug 338509
FIXED-IN: 4.4.0

M  +3    -1    NEWS
M  +13   -6    app/tags/tageditdlg.cpp
M  +1    -1    app/tags/tageditdlg.h

http://commits.kde.org/digikam/e0877e3205911cd42a792c7d071d638831f4cdec

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=309558

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tags-Engine                 |Usability-Shortcuts

--
You are receiving this mail because:
You are the assignee for the bug.