[Bug 309341] New: digiKam doesn't write XMP-tiff Orientation tag for raw files

[Elle Stone]

https://bugs.kde.org/show_bug.cgi?id=309341

            Bug ID: 309341
          Severity: normal
           Version: 2.9.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: digiKam doesn't write XMP-tiff Orientation tag for raw
                    files
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: openSUSE RPMs
            Status: UNCONFIRMED
         Component: Sidecar Management
           Product: digikam

Under digiKam settings/Metadata/Rotation, I have "When rotating a file, Rotate
only by setting a flag" and "Write flag to metadata if possible". Under
settings/Behavior I have "Write to sidecar files"/"Write to XMP sidecar only".
When using the rotation arrows to change the image rotation, the orientation
tag is correctly written to the .jpg.xmp sidecar file for jpegs. But it is
never written for .cr2.xmp or for .mrw.xmp sidecar files. So I'm guessing it
isn't being written for any raw files at all.

Reproducible: Always

Steps to Reproduce:
1.Select a raw file that needs to have the rotation flag changed.
2.Change the flag using the rotation arrows.
3.Select Image/"Write metadata to image"
4.Use exiftool to check the sidecar orientation tag. It doesn't change.
Actual Results:  
The image display changes orientation like it should. But the information in
the raw file sidecar doesn't change. (It changes for jpeg sidecars, but not for
raw file sidecars).

Expected Results:  
For both raw file sidecars and jpg sidecars, the orientation flag should change
to reflect the actual orientation that was set using the rotation arrows.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309341

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Sidecar Management          |Metadata

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=309341

--- Comment #1 from Marcel Wiesweg <[hidden email]> ---
Metadata orientation and RAW files is a mess. At least, depending on the
format.
As far as I know, there are RAW files where interpretation of the metadata flag
is not straightforward; it can apply to the embedded JPEG, the RAW data, or
both.
As a result, we never read the metadata of the RAW file and apply it, but rely
on libraw to give use the picture in the proper orientation.
Implications:
- writing a changed rotation to metadata is currently explicitly disabled for
RAW files
- I can enable writing the rotation flag to a sidecar file, but it may not have
an effect for our reading the file
- it is ATM not transparent how rotation of RAW files on loading is achieved by
libraw.
- I dont know how to interpret the orientation flag from RAW metadata, so I
wont know what to do with the rotation from the sidecar.

=> we'll need more information regarding the different RAW formats.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=309341

--- Comment #2 from Gilles Caulier <[hidden email]> ---
- writing a changed rotation to metadata is currently explicitly disabled for
RAW files
sound fine.

- I can enable writing the rotation flag to a sidecar file, but it may not have
an effect for our reading the file

It must be better to use DB orientation flag for RAW and use it to display
preview and thumb.
- it is ATM not transparent how rotation of RAW files on loading is achieved by
libraw.

It's done by libraw. In fact it's originaly dcraw code used inside. I already
take a look in dcraw code in the past (it's a big puzzle), and it use some
cached properties in metadata... It's a mess...

- I dont know how to interpret the orientation flag from RAW metadata, so I
wont know what to do with the rotation from the sidecar.

My suggestion  : simply decode it as non raw format and let's user turn preview
as it need through the DB flag...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=309341

--- Comment #3 from Marcel Wiesweg <[hidden email]> ---

> My suggestion  : simply decode it as non raw format and let's user turn
> preview as it need through the DB flag...

I completely agree with your analysis, I was trying to sketch the difficulties
we have here.
Yes that is what we do. Elle requested to write the rotation to the sidecar,
for interoperability or backup.
That could be possible for some selected RAW formats if we knew that the flag
is used straightforwardly without hidden magic. I dont know if that is the case
for any format.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=309341

--- Comment #4 from [hidden email] ---
This file still valid using last digiKam 5.0.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=309341

--- Comment #5 from [hidden email] ---
What's about this file using digiKam AppImage bundle 5.4.0 pre release given at
this url :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.