[Bug 308373] New: ACL default:mask ignored / mask changed for exif rotated images on import

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 308373] New: ACL default:mask ignored / mask changed for exif rotated images on import

Thomas Bettler
https://bugs.kde.org/show_bug.cgi?id=308373

            Bug ID: 308373
          Severity: normal
           Version: 2.9.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: ACL default:mask ignored / mask changed for exif
                    rotated images on import
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Gentoo Packages
            Status: UNCONFIRMED
         Component: Import
           Product: digikam

While importing images directly from camera, the exif rotated ones get their
permissions changed in a undesired way...
The destination folder has the following ACL settings:
bash$ getfacl .
# file: .
# owner: t
# group: users
user::rwx
user:r:rwx
user:t:rwx
group::---
mask::rwx
other::---
default:user::rwx
default:user:ra:rwx
default:user:th:rwx
default:group::---
default:mask::rwx
default:other::---

Example 1: landscape oriented image (no need to rotate)
bash$ getfacl IMG_5665.JPG
# file: IMG_5665.JPG
# owner: t
# group: users
user::rw-
user:r:rwx                  #effective:rw-
user:t:rwx                 #effective:rw-
group::---
mask::rw-
other::---

Example2: Portrait oriented image (auto rotated on import)
bash$ getfacl IMG_5666.JPG
# file: IMG_5666.JPG
# owner: t
# group: users
user::rw-
user:r:rwx                  #effective:---
user:t:rwx                 #effective:---
group::---
mask::---
other::---

Unexpectingly and unfortunately the rotated image has mask:: changed to ---
Expected behaviour: It should be mask::rw- as the non rotated images instead.

Reproducible: Always

Steps to Reproduce:
1. Import images with digikam

Actual Results:  
Unexpectingly and unfortunately the rotated image has mask:: changed to ---


Expected Results:  
Expected behaviour: It should be mask::rw- as the non rotated images instead.

Contact me, if you need more information.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308373] ACL default:mask ignored / mask changed for exif rotated images on import

Marcel Wiesweg
https://bugs.kde.org/show_bug.cgi?id=308373

--- Comment #1 from Marcel Wiesweg <[hidden email]> ---
Do you see the same problem if you rotate a file from the normal digikam view?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308373] ACL default:mask ignored / mask changed for exif rotated images on import

Thomas Bettler
In reply to this post by Thomas Bettler
https://bugs.kde.org/show_bug.cgi?id=308373

--- Comment #2 from Thomas Bettler <[hidden email]> ---
yes

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308373] ACL default:mask ignored / mask changed for exif rotated images on import

Marcel Wiesweg
In reply to this post by Thomas Bettler
https://bugs.kde.org/show_bug.cgi?id=308373

--- Comment #3 from Marcel Wiesweg <[hidden email]> ---
Git commit 8d3a76cac529b4f07323e801603da533d1b23ae5 by Marcel Wiesweg.
Committed on 04/11/2012 at 18:40.
Pushed by mwiesweg into branch 'master'.

Copy file permissions to a rotated JPEG file

M  +11   -0    libs/jpegutils/jpegutils.cpp

http://commits.kde.org/digikam/8d3a76cac529b4f07323e801603da533d1b23ae5

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308373] ACL default:mask ignored / mask changed for exif rotated images on import

Marcel Wiesweg
In reply to this post by Thomas Bettler
https://bugs.kde.org/show_bug.cgi?id=308373

--- Comment #4 from Marcel Wiesweg <[hidden email]> ---
This should at least copy the basic Unix permissions. I dont use ACLs, and Qt
does not seem to support them (difficult for a cross-platform library), so I
cant test the effect of this change.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308373] ACL default:mask ignored / mask changed for exif rotated images on import

Thomas Bettler
In reply to this post by Thomas Bettler
https://bugs.kde.org/show_bug.cgi?id=308373

--- Comment #5 from Thomas Bettler <[hidden email]> ---
Thanks for your patch marcel. I tried it and can report it corrects the
unexpected behaviour with the ACL mask on *nix systems. You may include this
patch also in 3.0.0-rc
Thanks a lot

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308373] ACL default:mask ignored / mask changed for exif rotated images on import

Gilles Caulier-4
In reply to this post by Thomas Bettler
https://bugs.kde.org/show_bug.cgi?id=308373

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Thomas,

Marcel patch's is already applied to 3.0.0-RC code. I can close this file
now...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308373] ACL default:mask ignored / mask changed for exif rotated images on import

Gilles Caulier-4
In reply to this post by Thomas Bettler
https://bugs.kde.org/show_bug.cgi?id=308373

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |3.0.0
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel