[Bug 308344] New: Display custom tags icons like in the album folder view

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 308344] New: Display custom tags icons like in the album folder view

Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=308344

            Bug ID: 308344
          Severity: wishlist
           Version: 3.0.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: Display custom tags icons like in the album folder
                    view
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Other
            Status: NEW
         Component: Tags
           Product: digikam

Currently we are drawing the tag icon around custom tag icons, but it is not
consistent with the album view and doesn't look very good in general.
Even when the icon settings are set to 48px, the custom tag is barely visible.

If we decide to use it, I can merge my branch with the master repository.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308344] Display custom tags icons like in the album folder view

Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=308344

--- Comment #1 from Andi Clemens <[hidden email]> ---
Created attachment 74528
  --> https://bugs.kde.org/attachment.cgi?id=74528&action=edit
new look

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308344] Display custom tags icons like in the album folder view

Andi Clemens
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=308344

--- Comment #2 from Andi Clemens <[hidden email]> ---
Created attachment 74529
  --> https://bugs.kde.org/attachment.cgi?id=74529&action=edit
old look

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308344] Display custom tags icons like in the album folder view

Marcel Wiesweg
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=308344

--- Comment #3 from Marcel Wiesweg <[hidden email]> ---
I dont care too much for this area, ok for me. It should clean up a bit of
code.
Gilles?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308344] Display custom tags icons like in the album folder view

Gilles Caulier-4
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=308344

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Marcel, no probem for me...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308344] Display custom tags icons like in the album folder view

Andi Clemens
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=308344

Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/86b9232f0eb637c51e604e9
                   |                            |f2c19923f8bb29717

--- Comment #5 from Andi Clemens <[hidden email]> ---
Git commit 86b9232f0eb637c51e604e9f2c19923f8bb29717 by Andi Clemens.
Committed on 13/10/2012 at 20:57.
Pushed by aclemens into branch 'master'.

display custom tag icons like in the album folder view

M  +8    -109  digikam/album/albumthumbnailloader.cpp
M  +1    -10   digikam/album/albumthumbnailloader.h
M  +0    -4    digikam/database/syncjob.cpp
M  +1    -1    digikam/tags/tagspopupmenu.cpp
M  +1    -1    libs/models/albummodel.cpp

http://commits.kde.org/digikam/86b9232f0eb637c51e604e9f2c19923f8bb29717

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 308344] Display custom tags icons like in the album folder view

Gilles Caulier-4
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=308344

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel