[Bug 307223] New: group selected by time not grouping one pair per album

[Marek Potocki]

https://bugs.kde.org/show_bug.cgi?id=307223

            Bug ID: 307223
          Severity: normal
           Version: 2.9.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: group selected by time not grouping one pair per album
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: openSUSE RPMs
            Status: UNCONFIRMED
         Component: general
           Product: digikam

When I group all photos in album (RAW+JPEG) by time, it work's except one pair.

Reproducible: Always

Steps to Reproduce:
1. go to album with photo pairs RAW+JPEG
2. select all
3. use function group selected by time (or similar - I don't use English
version)
Actual Results:  
All files are grouped, except one (in first 10). Sometimes problem not appear.


KDE 4.8.5

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marek Potocki]

https://bugs.kde.org/show_bug.cgi?id=307223

Marek Potocki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Albums GUI

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=307223

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Smit Mehta <[hidden email]> ---
Hi Marek

Can you please send me two screenshots? One showing the group option you select
and other showing the problem in the image area? It doesnt need to be in
English. We will figure that out.

Thanks.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marek Potocki]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #2 from Marek Potocki <[hidden email]> ---
> Can you please send me two screenshots? One showing the group option you select
> and other showing the problem in the image area? It doesnt need to be in
> English. We will figure that out.

OK, they are two screenshots
error0.png: polish option "Pogrupuj wybrane wg. czasu" (translate
error - properly "wg." is without dot at end)
error1.png: photo DSC05096.(ARW and JPG) aren't groupped. when I
change sort order, photo with error is another.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marek Potocki]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #3 from Marek Potocki <[hidden email]> ---
Created attachment 74096
  --> https://bugs.kde.org/attachment.cgi?id=74096&action=edit
error1.png

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #4 from Smit Mehta <[hidden email]> ---
Hi Marek

I am not able to reproduce it here. However it might be possible that the time
might be different by "seconds". to check that
(a) click on captions/tags on the right pane
(b) check the date and time

i have attached a screenshot to guide you how to reproduce the above steps.

if both are same for both the "raw" and "jpeg" image, then send those files to
me here.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #5 from Smit Mehta <[hidden email]> ---
Created attachment 74130
  --> https://bugs.kde.org/attachment.cgi?id=74130&action=edit
description for checking the date

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marek Potocki]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #6 from Marek Potocki <[hidden email]> ---
I found regularity of this bug. I click right button of mouse for display
context menu over one of photos, and pair with this file is not created.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #7 from Smit Mehta <[hidden email]> ---
Hi Marek

I am not sure what you mean by your last comment. Can you give some screenshot
of what you are referring to?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marek Potocki]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #8 from Marek Potocki <[hidden email]> ---
2012/11/3 Smit Mehta <[hidden email]>:
> https://bugs.kde.org/show_bug.cgi?id=307223
>
> --- Comment #7 from Smit Mehta <[hidden email]> ---
> Hi Marek
>
> I am not sure what you mean by your last comment. Can you give some screenshot
> of what you are referring to?

OK. Step by step:

1. I select all photos in album, and open context menu over any photo
in my example - IMG_0230.JPG (screen1.jpg)
2. After select group by time (pogrupuj wybrane wg czasu), all
selected files are grouped, exclude pair with this photo (screen2.jpg)
BUT
Bug doesn't appear when context menu is opened over any photo from
first pair in album (screen1a.jpg and screen2a.jpg)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marek Potocki]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #9 from Marek Potocki <[hidden email]> ---
Created attachment 74966
  --> https://bugs.kde.org/attachment.cgi?id=74966&action=edit
group2.jpg

--- Comment #10 from Marek Potocki <[hidden email]> ---
Created attachment 74967
  --> https://bugs.kde.org/attachment.cgi?id=74967&action=edit
group1a.jpg

--- Comment #11 from Marek Potocki <[hidden email]> ---
Created attachment 74968
  --> https://bugs.kde.org/attachment.cgi?id=74968&action=edit
group2a.jpg

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=307223

--- Comment #12 from Marcel Wiesweg <[hidden email]> ---
Marek, thanks for your precise analysis.
Smit, look at DigikamImageView::createGroupByTimeFromSelection(), first line:
    QList<ImageInfo> selectedInfos = selectedImageInfosCurrentFirst();

"CurrentFirst" -> current info is prepended in the list, thus out of order. Can
be replaced by the more simple selectedImageInfos().
Why is that a problem at all? The algorithm is simple, but seems to imply that
the infos are sorted by date, which is often the case, but in no way
guaranteed. Easiest way to fix is to qSort() the list with a custom lessThan
method which sorts by date/time.
When it comes to nit-picking optimization, an algorithm which only iterates (by
incrementing index or iterator) without editing the list (takeFirst) will be
slightly more efficient.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=307223

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/729399dcd5bf63046097ed3
                   |                            |e479e2d2906ed82cc

--- Comment #13 from Marcel Wiesweg <[hidden email]> ---
Git commit 729399dcd5bf63046097ed3e479e2d2906ed82cc by Marcel Wiesweg.
Committed on 12/01/2013 at 18:47.
Pushed by mwiesweg into branch 'master'.

Rewrite algorithm for grouping by time:
- sort list by date, dont take this state for granted
- iterator-based on read-only list, less expensive than list editing
Works for me, testing appreciated.

M  +27   -8    digikam/items/digikamimageview.cpp

http://commits.kde.org/digikam/729399dcd5bf63046097ed3e479e2d2906ed82cc

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307223

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
   Version Fixed In|                            |3.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=307223

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|AlbumsView                  |AlbumsView-Group

--
You are receiving this mail because:
You are the assignee for the bug.