[Bug 306879] New: Filter sections folding behavior is weird

https://bugs.kde.org/show_bug.cgi?id=306879

            Bug ID: 306879
          Severity: minor
               URL: http://imageshack.us/a/img833/9314/digikam280filtersec
                    tion.png
           Version: 2.8.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: Filter sections folding behavior is weird
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Ubuntu Packages
            Status: UNCONFIRMED
         Component: Filters
           Product: digikam

In the Filters tab (bottom right), the vertical space used seems to depend on
which section is fold or not.

See the screenshot linked:
http://imageshack.us/a/img833/9314/digikam280filtersection.png

Reproducible: Always

Steps to Reproduce:
1. Open the "Filters" tab
2. (check all sections are unfolded)
3. Fold the "geolocalisation" section
4. See how the "tag filters" do not use all the vertical space anymore
5. Fold all sections
6. Unfold the "geolocalisation" section
7. See how the vertical space used by all sections is different than at step 5.
Actual Results:  
Vertical space used is not always the same

Expected Results:  
Vertical space use should be coherent

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=306879

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[hidden email]
            Version|2.8.0                       |3.0.0
     Ever confirmed|0                           |1

--- Comment #1 from Smit Mehta <[hidden email]> ---
Hi Mathieu

I confirm the bug. We will look into it.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=306879

--- Comment #2 from Smit Mehta <[hidden email]> ---
Hi Gilles

I think its just a simple typo. Look at this :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/filters/filtersidebarwidget.cpp#L271

Actually i think, its intended for "tag filters" instead of "geo tags" to
expand. It looks more consistent. So whenever you open "tags filter", it will
take up the entire space available, because it requires more space due to
scrollbar area inside it. Otherwise, it should be extended.

If I make that condition to be (id==3) it will behave better. What do you
think? If its fine, i will commit it in current git/master on 18 sept. So that
it wont hurt beta packaging.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=306879

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Smit,
yes, it's a typo...
In fact why int values are used here to define view section. We must use an
enum of values with human readable names...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=306879

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/ae2e4874ab324d49a96f4f1
                   |                            |852213ac9f5577484

--- Comment #4 from Smit Mehta <[hidden email]> ---
Git commit ae2e4874ab324d49a96f4f1852213ac9f5577484 by Smit Mehta.
Committed on 17/09/2012 at 17:42.
Pushed by smitmehta into branch 'master'.

fixed typo in filtersiderbarwidget.cpp
added enum for more readibility

M  +2    -1    .gitignore
M  +2    -1    NEWS
M  +1    -1    digikam/filters/filtersidebarwidget.cpp
M  +9    -0    digikam/filters/filtersidebarwidget.h

http://commits.kde.org/digikam/ae2e4874ab324d49a96f4f1852213ac9f5577484

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=306879

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel