digiKam › digikam-devel

[Bug 305382] New: editing NEF gives artefacts

Classic

List

29 messages Options

Options

12

Gilles Caulier-4

[Bug 305382] editing RAW gives artefacts with Bilinear quality

https://bugs.kde.org/show_bug.cgi?id=305382

--- Comment #18 from Gilles Caulier <[hidden email]> ---
Marcel,

Yes, problem is reproducible with stand alone version.

Axel,

I talk to Alex Tutubalin, who is in CC in this file. He is libraw author...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[Bug 305382] editing RAW gives artefacts with Bilinear quality

In reply to this post by Axel Krebs

https://bugs.kde.org/show_bug.cgi?id=305382

--- Comment #19 from Gilles Caulier <[hidden email]> ---
Created attachment 74861
--> https://bugs.kde.org/attachment.cgi?id=74861&action=edit
Makefile.dist used to reproduce artifacts problem with LibRaw

Alex,

I found the problem... It's in libraw source code. I'm sure. I can reproduce
the artifacts problem with official Libraw 0.15.0-beta1 tarball.

The problem is about "-O4" gcc compilation optimization option. If you remove
it from offcial MakeFile.dist, the artifacts problem is reproducible with
"dcraw_emu -q0 myrawfile.NEF" (NEF is just and example, it's also reproducible
with CR2 files...)

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[Bug 305382] editing RAW gives artefacts with Bilinear quality

In reply to this post by Axel Krebs

https://bugs.kde.org/show_bug.cgi?id=305382

--- Comment #20 from Gilles Caulier <[hidden email]> ---
Alex,

I can confirm also, that with my stand alone libraw compiled with CMake, if i
use "-O4" optimization, as with official libraw tarball, artifacts
disappears...

It's definitively a libraw problem....

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[Bug 305382] editing RAW gives artefacts with Bilinear quality

In reply to this post by Axel Krebs

https://bugs.kde.org/show_bug.cgi?id=305382

--- Comment #21 from Gilles Caulier <[hidden email]> ---
Git commit ca11950fa5926ccfb4438d8b9cbd072370be3f0b by Gilles Caulier.
Committed on 29/10/2012 at 11:55.
Pushed by cgilles into branch 'master'.

- Use -O4 compilation option to optimize speed with dosaicing process.

- Fix artifacts produced by libraw when OpenMP is used. This problem still
present in libraw and must be fixed as DOWNSTREAM
Please confirm if probelm still reproducible on your computer with this fix.
Related: bug 308489

M +2 -1 libraw/CMakeLists.txt

http://commits.kde.org/libkdcraw/ca11950fa5926ccfb4438d8b9cbd072370be3f0b

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Axel Krebs

[Bug 305382] editing RAW gives artefacts with Bilinear quality

In reply to this post by Axel Krebs

https://bugs.kde.org/show_bug.cgi?id=305382

--- Comment #22 from Axel Krebs <[hidden email]> ---
Gilles + Marcel:

This sounds great. Impressive work. Thank you guys!

Please let me know, if I could help somehow.

Axel

(please, _NOT_ "Alex")
---
Am 29.10.2012 10:13, schrieb Gilles Caulier:

> https://bugs.kde.org/show_bug.cgi?id=305382
>
> --- Comment #19 from Gilles Caulier <[hidden email]> ---
> Created attachment 74861
> --> https://bugs.kde.org/attachment.cgi?id=74861&action=edit
> Makefile.dist used to reproduce artifacts problem with LibRaw
>
> Alex,
>
> I found the problem... It's in libraw source code. I'm sure. I can reproduce
> the artifacts problem with official Libraw 0.15.0-beta1 tarball.
>
> The problem is about "-O4" gcc compilation optimization option. If you remove
> it from offcial MakeFile.dist, the artifacts problem is reproducible with
> "dcraw_emu -q0 myrawfile.NEF" (NEF is just and example, it's also reproducible
> with CR2 files...)
>
> Gilles Caulier
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 305382] editing RAW gives artefacts with Bilinear quality

In reply to this post by Axel Krebs

https://bugs.kde.org/show_bug.cgi?id=305382

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[hidden email]
Version Fixed In|[hidden email] |

--- Comment #23 from Gilles Caulier <[hidden email]> ---
Alex,

Sorry, i make a mistake with bugzilla settings to CC you. Now it's fixed.
Please review this entry and comment...

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[digikam] [Bug 305382] editing RAW gives artefacts with Bilinear quality

In reply to this post by Axel Krebs

https://bugs.kde.org/show_bug.cgi?id=305382

--- Comment #24 from Alex Tutubalin <[hidden email]> ---
There is no OpenMP speedup for linear interpolate in LibRaw 0.15-release

I was unable to reproduce this problem (several months ago), anyway I've
removed OpenMP speedup for safety.

Please re-check with current LibRaw 0.15.1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 305382] editing RAW gives artefacts with Bilinear quality

In reply to this post by Axel Krebs

https://bugs.kde.org/show_bug.cgi?id=305382

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Version Fixed In| |3.3.0
Resolution|--- |FIXED

--- Comment #25 from Gilles Caulier <[hidden email]> ---
Confirmed. Artefact are not reproducible with libraw 0.15.1 if compiled with
OpenMP and no optimization -O4 is used.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Axel Krebs

[digikam] [Bug 305382] editing RAW gives artefacts with Bilinear quality

In reply to this post by Axel Krebs

https://bugs.kde.org/show_bug.cgi?id=305382

--- Comment #26 from Axel Krebs <[hidden email]> ---
(In reply to comment #8)
> Just to precise the comparison :
>
> I run "./dcraw_emu -q 0 5D3_5199.CR2" from libraw compiled with libkdcraw =>
> artefacts.
>
> I run "./dcraw_emu -q 0 5D3_5199.CR2" from libraw compiled with offcial
> tarball => no artefacts.
>
> Gilles Caulier

Gilles:

sorry for this late comment: the pic ***5199.CR2 are _not_ the ones which
caused my bugreporting this issue!!

The pic I reported was "DSC_8604_XX.jpg"

Axel

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

12