[Bug 303848] New: automatic lens correction tool called from within batch quenue manager doesn't work when 'use metadata' option is set

[Maciej Słojewski]

https://bugs.kde.org/show_bug.cgi?id=303848

            Bug ID: 303848
          Severity: normal
           Version: 2.7.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: automatic lens correction tool called from within
                    batch quenue manager doesn't work when 'use metadata'
                    option is set
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Ubuntu Packages
            Status: UNCONFIRMED
         Component: Batch Queue Manager
           Product: digikam

.jpg files made with use of digital camera ( Canon PowerShot S3 IS). When such
a file is opened within digikam editor and I select a tool 'automatic lens
correction', by default the following options are visible:
- show grid (unset)
- use metadata (set) and in the parentheses (found partial matching)
- Producer: Canon
- Model: Canon PowerShot S3 IS
- (...)
Then when I apply proposed changes (by clicking OK button) photo is correctly
processed.

When I add the same photo to Batch Quenue Manager to default qunue (#1) and
specify 'assigned tool': automatic lens correction tool and in the window 'tool
setting' I specify 'use metadata' then I get the following errors:

(...) Element "*.JPG" from quenue "#1": Processing of the specified item was
not successful...
(...) Element "*.JPG" from quenue "#1": All required information about lens
couldn't be determined...

In other words: when I manually process photos, one by one, with use of
'automatic lens correction' tool, everything is ok. When I try to do the same
action with use of 'batch quenue manager', it fails to do this action.

My apologies, but above error messages are translated by myself from my mother
tongue (Polish) into English.

Reproducible: Always

Steps to Reproduce:
1. Take any .JPG photo made with use of Canon PowerShot S3 IS
2. Put it in 'batch quenue manager'.
3. Select 'automatic lens correction' tool with 'use metadata' option set.
4. Run quenue.
Actual Results:  
I get the following errors:

(...) Element "*.JPG" from quenue "#1": Processing of the specified item was
not successful...
(...) Element "*.JPG" from quenue "#1": All required information about lens
couldn't be determined...


Expected Results:  
Automatic correction of the photo as it is done when the same photo is
processed with use of digikam editor and I select a tool 'automatic lens
correction' with 'use metadata' option set.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=303848

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|automatic lens correction   |BQM LensCorrection tool :
                   |tool called from within     |doesn't work when 'use
                   |batch quenue manager        |metadata' option is set
                   |doesn't work when 'use      |
                   |metadata' option is set     |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=303848

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Roman,

Your last patches over digiKam LensFunIface applied to current git/master (next
3.0.0 release) will fix this entry ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Roman I Khimov]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #2 from Roman I Khimov <[hidden email]> ---
Gilles,

Don't tnink so, this one looks different to me.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Maciej,

Can you provide some sample images to test here. Please host files on the web
for download

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maciej Słojewski]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #4 from Maciej Słojewski <[hidden email]> ---
Created attachment 76315
  --> https://bugs.kde.org/attachment.cgi?id=76315&action=edit
For batch test puropose

Uploaded file for testing purposes. The 1 out of 2 photos. This photo was
resized down. The bug might be reproduced with this photo.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maciej Słojewski]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #5 from Maciej Słojewski <[hidden email]> ---
Created attachment 76316
  --> https://bugs.kde.org/attachment.cgi?id=76316&action=edit
Uploaded file for testing purposes.

Uploaded file for testing purposes. The 2 out of 2 photos. This photo was
resized down. The bug might be reproduced with this photo.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maciej Słojewski]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #6 from Maciej Słojewski <[hidden email]> ---
I've prepared short screencast illustrating what is the issue. This screencast
might be watched here: http://youtu.be/pCBp3qh9ESE The screencast was prepared
with the same photo set as previously uploaded.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Akshay Ratan]

https://bugs.kde.org/show_bug.cgi?id=303848

Akshay <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Akshay <[hidden email]> ---
@Gilles: In reproducing this bug, what is happening on my Kubuntu 11.10 oneiric
is that Lens Auto correction tool is not working at all ! Vignette correction
and lens distortion is working ..any suggestions as to what can be done ? I am
using digikam 3.x version on KDE 4.x....

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Lens AutoCorrection is not available if at least lensfun shared lib version >=
0.2.6 is not present on your system. It's a n optional dependency.

Install this lib, reconfigure with cmake, compile and install. Check at cmake
config time than lensfun support is actived in cmake resume.

Note : i don't yet tested compilation and runtime using last lensfun 0.2.7

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Akshay Ratan]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #9 from Akshay <[hidden email]> ---
@Gilles ::  I am triying my best to reproduce the bug, but unfortunately lens
auto-correction tool is not at all working ! Tried taking help at IRC too !

Anyways, this is my CMake output :: http://paste.kde.org/691178/ 

Little details:: libclapack library found................. NO  (optional -
internal version used instead)
libimagemagick library found............. NO  (optional)
QtKOAuth library found................... NO  (optional)

All other libraries are found! Even sorted out lensfun dependency as you
advised earlier :) Please guide me a little on this.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Akshay Ratan]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #10 from Akshay <[hidden email]> ---
Hi Gilles,   I am trying my best to reproduce the bug, but unfortunately lens
auto-correction tool is not at all working ! Tried taking help at IRC too !

Anyways, this is my CMake output :: http://paste.kde.org/691178/ 

Little details:: libclapack library found................. NO  (optional -
internal version used instead)
libimagemagick library found............. NO  (optional)
QtKOAuth library found................... NO  (optional)

All other libraries are found! Even sorted out lensfun dependency as you
advised earlier :) I presume libclapack internal dependency with digikam might
be bugging which I saw in itself is another minor bug.Please guide me a little
on this.


--- On Mon, 2/18/13, Gilles Caulier <[hidden email]> wrote:

From: Gilles Caulier <[hidden email]>
Subject: [digikam] [Bug 303848] BQM LensCorrection tool : doesn't work when
'use metadata' option is set
To: [hidden email]
Date: Monday, February 18, 2013, 12:48 PM

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Lens AutoCorrection is not available if at least lensfun shared lib version >=
0.2.6 is not present on your system. It's a n optional dependency.

Install this lib, reconfigure with cmake, compile and install. Check at cmake
config time than lensfun support is actived in cmake resume.

Note : i don't yet tested compilation and runtime using last lensfun 0.2.7

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Little details:: libclapack library found................. NO  (optional -
internal version used instead)
libimagemagick library found............. NO  (optional)
QtKOAuth library found................... NO  (optional)

==> we don't care : there are optional dependencies for kipi-plugins not
digiKam.

From your trace http://paste.kde.org/691178/ all is ready to be compiled. Go to
build dir and run make....

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #12 from Gilles Caulier <[hidden email]> ---
If Lensfun tool doesn't work, try to indentify why.

Instead to use GUI, look my test lensfun command line progam in core/test :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/changes/tests/testlensfuniface.cpp

To compile it, turn on cmake option -DKDE4_BUILD_TESTS=on :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/CMakeLists.txt#L1705

If you want to see debug statements on the console, run kdebugdialog and turn
on digiKam, Keviv2, and others relevant debug spaces.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=303848

Teemu Rytilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #13 from Teemu Rytilahti <[hidden email]> ---
Could this be just that when there's just a partial match, it won't proceed on
BQM?

What I had in mind (as I have similar problem, for some reason lensfun returns
two lenses instead of the "strict" match) to save the selected lens after
asking user about it. So when lensfun returns multiple matches (in my case
"<lens>" and "<lens> r", allow user to save the preferred lens and use that as
a default from that point.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #14 from Gilles Caulier <[hidden email]> ---
Git commit 09e5724cc30efa46314fb773be318890be1d32c4 by Gilles Caulier.
Committed on 28/11/2013 at 16:10.
Pushed by cgilles into branch 'master'.

apply patch from Teemu Rytilahti to handle properly multiple matches of lens
from lensfun
REVIEW: 111021

M  +32   -26   libs/dimg/filters/lens/lensfuniface.cpp

http://commits.kde.org/digikam/09e5724cc30efa46314fb773be318890be1d32c4

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Matthias Weiss]

https://bugs.kde.org/show_bug.cgi?id=303848

Matthias Weiss <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #15 from Matthias Weiss <[hidden email]> ---
Hi Gilles,

    I've experiencing the same problem with my Sony Nex 5r + Sony SEL 35mm
f/1.8 lens, in the BQM the automatic lens correction fails because it can't
find the lens in lensfun. I also tried it with the editor, here also the lens
isn't detected automatically. When I then select the the lens manually the
correction ist applied correctly.

I'm using raw files in the BQM.

Tell me if I can help with debugging ...

(and thanx for this awesome piece of software! :-) )

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Matthias Weiss]

https://bugs.kde.org/show_bug.cgi?id=303848

--- Comment #16 from Matthias Weiss <[hidden email]> ---
I forgot: I'm using digikam 4.0.0 with lensfun 0.2.8 on debian unstable.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=303848

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|BQM LensCorrection tool :   |BQM LensCorrection tool :
                   |doesn't work when 'use      |doesn't work when 'use
                   |metadata' option is set     |metadata' option is turned
                   |                            |on

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=303848

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Tool-Lens
                   |                            |Distortion

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel