[Bug 303163] New: "Undo" after "Color, Color Space Conversion" does not restore the original ICC profile

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 303163] New: "Undo" after "Color, Color Space Conversion" does not restore the original ICC profile

Elle Stone
https://bugs.kde.org/show_bug.cgi?id=303163

            Bug ID: 303163
          Severity: normal
           Version: 2.6.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: "Undo" after "Color, Color Space Conversion" does not
                    restore the original ICC profile
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: openSUSE RPMs
            Status: UNCONFIRMED
         Component: Color Management
           Product: digikam

If you hit the "Edit, Undo, Color Profile Conversion", the color space
conversion is "undone" but the embedded profile is still the color conversion
destination profile. For instance, if you convert from sRGB to ProPhoto and
then "undo", the color space conversion itself is undone, but the embedded
profile is ProPhoto. So the colors look funny. If you save (preferably under a
new name), close showfoto, and then reopen the image, you can see that ProPhoto
is still assigned and the colors look funny. Assign sRGB and the colors are
restored.

If you try to undo two sequential color space conversions, I'm not sure what
really happens, but the results are very wrong.

To reproduce, open an image and convert to another color space profile using
"Color, Color Space Conversion." Then select Edit, Undo and select "Color
Profile Conversion. The colors will immediately look wrong. If you save and
reopen, you'll see that the embedded profile is the profile you converted to,
and the colors will be wrong. Assign the original profile and the collors will
be correct.

The same thing happens in digiKam and showFoto.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303163] "Undo" after "Color, Color Space Conversion" does not restore the original ICC profile

Marcel Wiesweg
https://bugs.kde.org/show_bug.cgi?id=303163

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/ead996b2a89b72e0f248c57
                   |                            |edc68c22ba079fd93

--- Comment #1 from Marcel Wiesweg <[hidden email]> ---
Git commit ead996b2a89b72e0f248c57edc68c22ba079fd93 by Marcel Wiesweg.
Committed on 22/07/2012 at 15:58.
Pushed by mwiesweg into branch 'master'.

Record color profile and metadata in undo history in editor.

So far only the history was recorded. Add a container to store history and icc
profile.
Undo/redo now works cleanly when a plugin changes the color profile.
DMetadata is currently not kept in undo because either an imageplugin (only two
atm, noncritical)
or a concurrent user metadata editing operation can change the metadata;
essentially,
all critical metadata editing would need to be applied before saving.
In ImageWindow, we re-write from the database to metadata before saving, so
probably all will work.

M  +2    -1    NEWS
M  +0    -5    utilities/imageeditor/canvas/canvas.cpp
M  +0    -1    utilities/imageeditor/canvas/canvas.h
M  +29   -5    utilities/imageeditor/canvas/dimginterface.cpp
M  +3    -2    utilities/imageeditor/canvas/dimginterface.h
M  +27   -10   utilities/imageeditor/canvas/undoaction.cpp
M  +19   -3    utilities/imageeditor/canvas/undoaction.h
M  +18   -18   utilities/imageeditor/canvas/undomanager.cpp
M  +2    -1    utilities/imageeditor/canvas/undomanager.h
M  +1    -1    utilities/imageeditor/editor/imagewindow.cpp

http://commits.kde.org/digikam/ead996b2a89b72e0f248c57edc68c22ba079fd93

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303163] "Undo" after "Color, Color Space Conversion" does not restore the original ICC profile

Gilles Caulier-4
In reply to this post by Elle Stone
https://bugs.kde.org/show_bug.cgi?id=303163

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
   Version Fixed In|                            |2.8.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303163] "Undo" after "Color, Color Space Conversion" does not restore the original ICC profile

Marcel Wiesweg
In reply to this post by Elle Stone
https://bugs.kde.org/show_bug.cgi?id=303163

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Marcel Wiesweg <[hidden email]> ---
*** Bug 306087 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel