[Bug 302740] New: Duplicate rotation/mirror entries in image menu, shortcuts not working

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #17 from Gilles Caulier <[hidden email]> ---
For me with this libkipi version and digiKam 2.8.0, it's not reproducible...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #18 from Andreas K. Huettel <[hidden email]> ---
> For me with this libkipi version and digiKam 2.8.0, it's not reproducible...
>
OK... please give me a few days, I'll try to get to the bottom of this.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Wonko]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #19 from Wonko <[hidden email]> ---
I just noticed that I had still kipi-plugins2.6.0 installed, and upgraded to
2.7.0. Now the Ctrl-Shift-Left shortcut is working, when the lossless JPEG
plugin is enabled, and does nothing when it is deactivated. I no longer get the
ambuguity dialog, unless I restore the shortcuts to their default values
(Ctrl-Shift-Left for the 'Left' action, nothing for 'Rotated Left').

Summary: Either the lossless JPEG plugin needs to be deactivated, or the
shortcut for 'Left' needs to be changed from Ctrl-Shift-Left to make this
shortcut work.

Why is the Plugin still around, when this feature is available directly in
Digikam? Does it work different, or does it have additional features?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #20 from Andi Clemens <[hidden email]> ---
Git commit a97ed4b9aaf4d27194507a140afb5f0522ec5c1a by Andi Clemens.
Committed on 13/10/2012 at 18:34.
Pushed by aclemens into branch 'master'.

No need to duplicate actions here, they have already been added to the global
action collection.

M  +1    -1    digikam/items/digikamimageview.cpp
M  +0    -36   digikam/utils/contextmenuhelper.cpp
M  +0    -7    digikam/utils/contextmenuhelper.h
M  +1    -1    digikam/views/imagepreviewview.cpp

http://commits.kde.org/digikam/a97ed4b9aaf4d27194507a140afb5f0522ec5c1a

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302740

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|2.7.0                       |3.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #21 from Andreas K. Huettel <[hidden email]> ---
This is NOT fixed in 3.0.0-rc yet.

And, it is actually a libkipi bug: in libkipi the plugin name from the ignore
list is compared against the LOCALIZED plugin name (which here in a german
installation is "Verlustfreies JPEG"; of course this won't be found in the
ignore list).

Analysis done: I patched libkipi-4.9.95 pluginloader.cpp to add a debug output
also if a plugin is NOT found in the ignore list:
    315         if (d->ignoredPlugins.contains(name))
    316         {
    317             kDebug(51001) << "Plugin " << name << " is in the ignore
list from host application";
    318             continue;
    319         } else {
    320             kDebug(51001) << "Plugin " << name << " is NOT in the
ignore list from host application";
    321         }

The resulting messages are:
[...]
digikam(19796)/KIPI (loading) KIPI::PluginLoader::init: Plugin  "Piwigo-Export"
 is NOT in the ignore list from host application
digikam(19796)/KIPI (loading) KIPI::PluginLoader::init: Plugin
"SmugMug-Import/Export"  is NOT in the ignore list from host application
digikam(19796)/KIPI (loading) KIPI::PluginLoader::init: Plugin  "Verlustfreies
JPEG"  is NOT in the ignore list from host application
digikam(19796)/KIPI (loading) KIPI::PluginLoader::init: Plugin
"KioExportImport"  is NOT in the ignore list from host application
digikam(19796)/KIPI (loading) KIPI::PluginLoader::init: Plugin
"Bildbetrachter"  is NOT in the ignore list from host application
digikam(19796)/KIPI (loading) KIPI::PluginLoader::init: Plugin  "Shwup-Export"
is NOT in the ignore list from host application

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #22 from Andreas K. Huettel <[hidden email]> ---
Reading the docs, libkipi should probably use KService::untranslatedGenericName
instead of KService::name ...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #23 from Andreas K. Huettel <[hidden email]> ---
(In reply to comment #22)
> Reading the docs, libkipi should probably use
> KService::untranslatedGenericName instead of KService::name ...

... except that KService::untranslatedGenericName returns empty string for all
kipi plugins. :(

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #24 from Andreas K. Huettel <[hidden email]> ---
OK here's how to fix this (2 steps required):

1) in each kipi-plugin service .desktop file, add a line as for example
UntranslatedGenericName=JPEGLossless
(with the respective untranslated name of the plugin)

2) apply the following patch to libkipi (debug output not required of course):

diff -ruN libkipi-4.9.95.orig/libkipi/pluginloader.cpp
libkipi-4.9.95/libkipi/pluginloader.cpp
--- libkipi-4.9.95.orig/libkipi/pluginloader.cpp        2012-12-17
16:03:59.000000000 +0100
+++ libkipi-4.9.95/libkipi/pluginloader.cpp     2013-01-02 23:08:12.000000000
+0100
@@ -302,6 +302,7 @@
     {
         KService::Ptr service   = *iter;
         QString name            = service->name();
+        QString uname           = service->untranslatedGenericName();
         QString library         = service->library();
         QStringList reqFeatures =
service->property(QString::fromLatin1("X-KIPI-ReqFeatures")).toStringList();
         int binVersion          =
service->property(QString::fromLatin1("X-KIPI-BinaryVersion")).toInt();
@@ -312,10 +313,12 @@
             continue;
         }

-        if (d->ignoredPlugins.contains(name))
+        if (d->ignoredPlugins.contains(uname))
         {
-            kDebug(51001) << "Plugin " << name << " is in the ignore list from
host application";
+            kDebug(51001) << "Plugin " << name << "(generic name " << uname <<
") is in the ignore list from host application";
             continue;
+        } else {
+            kDebug(51001) << "Plugin " << name << "(generic name " << uname <<
") is NOT in the ignore list from host application";
         }

         if (binVersion != kipi_binary_version)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302740

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
            Version|2.6.0                       |3.0.0
     Ever confirmed|0                           |1

--- Comment #25 from Gilles Caulier <[hidden email]> ---
Victor,

Do you see the investigations from Andreas in this file ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #26 from Andreas K. Huettel <[hidden email]> ---
Ping?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Victor Dodon]

I will investigate the problem and apply the patch to libkipi and to all kipi-plugins.

Andreas, thank you very much for your input and for the patch.

Victor.

On Sun, Jan 27, 2013 at 6:04 PM, Andreas K. Huettel <[hidden email]> wrote:

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #26 from Andreas K. Huettel <[hidden email]> ---
Ping?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Victor Dodon]

https://bugs.kde.org/show_bug.cgi?id=302740

--- Comment #27 from Victor Dodon <[hidden email]> ---
I will investigate the problem and apply the patch to libkipi and to all
kipi-plugins.

Andreas, thank you very much for your input and for the patch.

Victor.




On Sun, Jan 27, 2013 at 6:04 PM, Andreas K. Huettel
<[hidden email]>wrote:

> https://bugs.kde.org/show_bug.cgi?id=302740
>
> --- Comment #26 from Andreas K. Huettel <[hidden email]> ---
> Ping?
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302740

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #28 from Gilles Caulier <[hidden email]> ---
Git commit 0e25e3ee73cf4048b6d97ccc496bad5b1a1fd577 by Victor Dodon.
Committed on 28/01/2013 at 09:57.
Pushed by dodon into branch 'master'.

Check the untranslatedGenericName service property when loading plugins

BUGS: 302740
CCMAIL: [hidden email]
CCMAIL: [hidden email]

M  +6    -5    libkipi/pluginloader.cpp
M  +1    -0  
tests/kxmlhelloworld/plugin/kipiplugin_kxmlhelloworld.desktop.cmake

http://commits.kde.org/libkipi/0e25e3ee73cf4048b6d97ccc496bad5b1a1fd577

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=302740

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|AlbumsView                  |AlbumsView-Menu

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=302740

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Albums-Menus                |Usability-Shortcuts

--
You are receiving this mail because:
You are the assignee for the bug.