[Bug 302562] New: Rename "View Image" to "Preview".

[Dotan Cohen-3]

https://bugs.kde.org/show_bug.cgi?id=302562

            Bug ID: 302562
          Severity: normal
           Version: unspecified
          Priority: NOR
          Assignee: [hidden email]
           Summary: Rename "View Image" to "Preview".
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Other
            Status: NEW
         Component: Usability
           Product: digikam

View -> View Image should probably be renamed to View -> Preview as that seems
to be the proper name for the feature according to the confusion on bug
#302559.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=302562

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Smit Mehta <[hidden email]> ---
Hi Dotan, Gilles

What do you think? If its fine with you, I can find the required code and patch
it.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302562

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Agree. View->View Image menu entry is typo redondant. View->Preview Image is
fine.

No need a patch here in Bugzilla. Please patch directly git/master (not 3.0.0
branch). Commit will be backported to 3.0.0 later...

Don't forget to patch NEWS file too...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=302562

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/82dfdf1c0ed12fe0560de47
                   |                            |43ea3ecc5722257c8

--- Comment #3 from Smit Mehta <[hidden email]> ---
Git commit 82dfdf1c0ed12fe0560de4743ea3ecc5722257c8 by Smit Mehta.
Committed on 26/06/2012 at 19:42.
Pushed by smitmehta into branch 'master'.

Fixing typo. View Image -> Preview Image

M  +1    -1    NEWS
M  +1    -1    digikam/main/digikamapp.cpp

http://commits.kde.org/digikam/82dfdf1c0ed12fe0560de4743ea3ecc5722257c8

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302562

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Smit,

You miss to patch icon-view Context Menu where there is a "View" action which
is used to switch in preview mode...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=302562

--- Comment #5 from Smit Mehta <[hidden email]> ---
Gilles,

I changed the line 843 of digikam/main/digikamapp.cpp. I think that only
governs the name of that action. However even I am surprised that it didnt
change anything. When I used grep on the digiKam directory, i didnt see any
other code affecting that. Any ideas?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302562

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Context menu action is here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/items/digikamimageview.cpp#L327

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=302562

--- Comment #7 from Smit Mehta <[hidden email]> ---
Git commit f699376e285d3e81b79a788c32182a9b49d61edb by Smit Mehta.
Committed on 27/06/2012 at 09:11.
Pushed by smitmehta into branch 'master'.

context menu typo fix. view->preview

M  +1    -1    digikam/items/digikamimageview.cpp

http://commits.kde.org/digikam/f699376e285d3e81b79a788c32182a9b49d61edb

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302562

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.7.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=302562

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Preview-Engine

--
You are receiving this mail because:
You are the assignee for the bug.