[Bug 302422] New: Slideshow info is displayed too high

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 302422] New: Slideshow info is displayed too high

Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=302422

            Bug ID: 302422
          Severity: normal
           Version: 2.7.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: Slideshow info is displayed too high
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Compiled Sources
            Status: NEW
         Component: SlideShow
           Product: digikam

If you, for example, only show filenames in the slideshow, the filename seems
to appear almost in the middle of the screen.

This is because we have too much space under the filename label, because it is
reserved for the slideshow toolbar that may appear here if the mouse cursor is
moved to the bottom left.

I would not display the toolbar in every corner of the screen, it only should
be visible in the top left and top right corner. Therefore we could move the
image info to the bottom of the screen.

Furthermore it would be nice if we implement a toolbar that also displays the
thumbnails of all images in the slideshow, as in gwenview, to have more control
over the slideshow.

The attached patch only disables the bottom left and bottom right corners for
the toolbar and moves the image info to the bottom of the screen (e.g. if only
filenames are displayed).

What do you think?

Reproducible: Always

Actual Results:  


Expected Results:

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 302422] Slideshow info is displayed too high

Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=302422

--- Comment #1 from Andi Clemens <[hidden email]> ---
Created attachment 72082
  --> https://bugs.kde.org/attachment.cgi?id=72082&action=edit
the patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 302422] Slideshow info is displayed too high [patch]

Gilles Caulier-4
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=302422

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Slideshow info is displayed |Slideshow info is displayed
                   |too high                    |too high [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 302422] Slideshow info is displayed too high [patch]

Gilles Caulier-4
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=302422

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Andi,

Your patch cannot be applied to git/master :

[gilles@localhost core]$ patch -p1 < slideshow_info.diff
patching file utilities/slideshow/slideshow.cpp
Hunk #1 FAILED at 8.
Hunk #2 succeeded at 406 (offset 8 lines).
Hunk #3 FAILED at 791.
Hunk #4 succeeded at 835 (offset 8 lines).
Hunk #5 succeeded at 850 (offset 8 lines).
Hunk #6 FAILED at 856.
3 out of 6 hunks FAILED -- saving rejects to file
utilities/slideshow/slideshow.cpp.rej
patching file utilities/slideshow/slideshow.h
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 95.
2 out of 2 hunks FAILED -- saving rejects to file
utilities/slideshow/slideshow.h.rej

Please update it...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 302422] Slideshow info is displayed too high [patch]

Cruceru Calin-Cristian
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=302422

--- Comment #3 from Cruceru Calin-Cristian <[hidden email]> ---
Created attachment 85289
  --> https://bugs.kde.org/attachment.cgi?id=85289&action=edit
patch for bug 302422

I did what Andi proposed on a fresh cloned digikam. So I guess it should work.

However, I spoke with Gilles and I know it could be done even better. But it is
my first trial to solve something in digikam, so I hope there is no problem I
posted this patch.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 302422] Slideshow info is displayed too high [patch]

Gilles Caulier-4
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=302422

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72082|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 302422] Slideshow info is displayed too high [patch]

Cruceru Calin-Cristian
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=302422

Cruceru Calin-Cristian <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/d8cc9d2a6b4a5ec4f37e80e
                   |                            |7024f9ab7800326ef

--- Comment #4 from Cruceru Calin-Cristian <[hidden email]> ---
Git commit d8cc9d2a6b4a5ec4f37e80e7024f9ab7800326ef by Cruceru Calin-Cristian.
Committed on 24/02/2014 at 06:52.
Pushed by crucerucalincristian into branch 'master'.

GUI: Toolbar in SlideShow only appears now in the top right and left corners
and Image Info appears now with 0 offset in left buttom corner

M  +10   -30   utilities/slideshow/slideshow.cpp
M  +2    -3    utilities/slideshow/slideshow.h

http://commits.kde.org/digikam/d8cc9d2a6b4a5ec4f37e80e7024f9ab7800326ef

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 302422] Slideshow info is displayed too high [patch]

Cruceru Calin-Cristian
In reply to this post by Andi Clemens
https://bugs.kde.org/show_bug.cgi?id=302422

Cruceru Calin-Cristian <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel