[Bug 302212] New: Incorrect rotation of DNG portrait images in preview

[Sander van der Heijden]

https://bugs.kde.org/show_bug.cgi?id=302212

            Bug ID: 302212
          Severity: normal
           Version: 2.6.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: Incorrect rotation of DNG portrait images in preview
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Other
            Status: UNCONFIRMED
         Component: Preview
           Product: digikam

When opening a DNG image (converted from CR2) with portrait orientation in the
album view, the preview is not rotated correctly. However, the thumbnail is
displayed correctly and also opening the image in the image editor will display
the image in the correct orientation.

Reproducible: Always

Steps to Reproduce:
1. Convert a CR2 image with portrait orientation to DNG
2. Open the image in the preview mode
3.
Actual Results:  
The thumbnail will display correctly, but the preview will be displayed in
landscape orientation...

Expected Results:  
Both thumbnail and preview will be displayed in portrait orientation

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Sander van der Heijden]

https://bugs.kde.org/show_bug.cgi?id=302212

--- Comment #1 from Sander van der Heijden <[hidden email]> ---
Created attachment 71966
  --> https://bugs.kde.org/attachment.cgi?id=71966&action=edit
Screenshot of incorrect orientation

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=302212

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Can you share CR2 and DNG file to test here ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Sander van der Heijden]

https://bugs.kde.org/show_bug.cgi?id=302212

--- Comment #3 from Sander van der Heijden <[hidden email]> ---
(In reply to comment #2)
> Can you share CR2 and DNG file to test here ?
>
> Gilles Caulier

Hi Gilles,

Files to test are shared via following URLs.
CR2: http://db.tt/MhKk4Ako
DNG: http://db.tt/PqtNbAVA

Sander van der Heijden

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michal Thoma]

https://bugs.kde.org/show_bug.cgi?id=302212

Michal Thoma <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Michal Thoma <[hidden email]> ---
I have same experience with out of the camera DNG from Ricoh GR Digital IV.
Thumbnail is displayed in portrait correctly while RAW is not.

Pentax PEF raw files are displayed correctly both thumbnail and preview.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pedro Sá (kunst uber alles)]

https://bugs.kde.org/show_bug.cgi?id=302212

--- Comment #5 from Pedro Sá (kunst uber alles) <[hidden email]> ---
Canon CR2 raw files are displayed correctly both thumbnail and preview, DNG
not, after convertion.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=302212

--- Comment #6 from Marcel Wiesweg <[hidden email]> ---
CR2 works all right here as well.
DNG thumb is ok (based on embedded preview), DNG full import is ok.
The DNG's preview is using half-size conversion because the preview is only 36%
per dimension (13% of pixels), too small. The half-size converted image is
improperly rotated. I need to investigate a bit more. Usually, IIRC, libraw
fully handles exif rotation, so I suspect a libraw problem.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=302212

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |2.8.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/1ed6ff7259d16992797f30c
                   |                            |966c1bd795e6d553d

--- Comment #7 from Marcel Wiesweg <[hidden email]> ---
Git commit 1ed6ff7259d16992797f30c966c1bd795e6d553d by Marcel Wiesweg.
Committed on 22/07/2012 at 20:04.
Pushed by mwiesweg into branch 'master'.

Add metadata to DImg created from QImage-based loading methods to fix finding
the correct exif orientation.

Since we make use of the database field, we need to compare the database value
with the metadata value.
Images created with the preview loading methods had no metadata, so a wrong
value was calculated.
FIXED-IN: 2.8.0

M  +2    -1    NEWS
M  +2    -0    libs/threadimageio/previewtask.cpp

http://commits.kde.org/digikam/1ed6ff7259d16992797f30c966c1bd795e6d553d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=302212

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Preview-Image               |Preview-RAW

--
You are receiving this mail because:
You are the assignee for the bug.