[Bug 300848] New: "Reread Metadata From Image" is broken

[Frédéric COIFFIER]

https://bugs.kde.org/show_bug.cgi?id=300848

            Bug ID: 300848
          Severity: normal
           Version: unspecified
          Priority: NOR
          Assignee: [hidden email]
           Summary: "Reread Metadata From Image" is broken
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Gentoo Packages
            Status: UNCONFIRMED
         Component: Metadata
           Product: digikam

The problem exists only in recent Git revisions (2.5.0 worked).
commit 597da399b75546f2c89726fdaa4d06fbd874c2cb

When EXIF fields of an image are modified by an external applications, they
cannot be reloaded by the "Reread Metadata From Image" function.

Reproducible: Always

Steps to Reproduce:
1. Import an image in Digikam
2. Modify the EXIF with an external applications like :
exiftool -E -overwrite_original_in_place -UserComment=test -Title=test test.jpg
3. Verify the EXIF with exitool

exiftool test.jpg | grep test
File Name                       : test.jpg
User Comment                    : test
Title                           : test
4. Reread metadata with Digikam

Actual Results:  
=> EXIF information aren't updated

Expected Results:  
EXIF information in Digikam should be updated

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=300848

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|unspecified                 |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael Holtermann-3]

https://bugs.kde.org/show_bug.cgi?id=300848

Michael Holtermann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Michael Holtermann <[hidden email]> ---
Same here with digiKam 2.6.0at  KDE 4.8.3 (Ubuntu 12.04, with PPA from
philip5).

Today I've updated to new digikam from 2.5, and most of my Tags are missing.
The database contains only 67 Tags from about 300 Tags before. I'll fill
another issue for that.

But now, if I try to recreate the meta data, none of the options in the
"Albums" and "Image" menus work.

BTW - with 2.6 there is the new dialog "Maintenance" that is able to rewrite
tags to images. May I suggest to move the menu items that *reads* the metadata
to the database to that dialog, too? IMHO this would be more consistent.

Regards,
Michael

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=300848

--- Comment #2 from Johannes Wienke <[hidden email]> ---
I can also confirm this at 2.6.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Frédéric COIFFIER]

https://bugs.kde.org/show_bug.cgi?id=300848

Frédéric COIFFIER <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Frédéric COIFFIER <[hidden email]> ---
Patch like this seems to correct the problem :


diff --git a/digikam/views/digikamview.cpp b/digikam/views/digikamview.cpp
index e461f99..b0b9bad 100644
--- a/digikam/views/digikamview.cpp
+++ b/digikam/views/digikamview.cpp
@@ -1352,13 +1352,15 @@ void DigikamView::slotAlbumReadMetadata()
 void DigikamView::slotImageWriteMetadata()
 {
     ImageInfoList selected = d->iconView->selectedImageInfos();
-    new MetadataSynchronizer(selected,
MetadataSynchronizer::WriteFromDatabaseToFile);
+    MetadataSynchronizer* tool = new MetadataSynchronizer(selected,
MetadataSynchronizer::WriteFromDatabaseToFile);
+    tool->start();
 }

 void DigikamView::slotImageReadMetadata()
 {
     ImageInfoList selected = d->iconView->selectedImageInfos();
-    new MetadataSynchronizer(selected,
MetadataSynchronizer::ReadFromFileToDatabase);
+    MetadataSynchronizer* tool = new MetadataSynchronizer(selected,
MetadataSynchronizer::ReadFromFileToDatabase);
+    tool->start();
 }

 // ----------------------------------------------------------------


Is there a core developper to confirm ?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=300848

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Fixed in git master with commit :

http://commits.kde.org/digikam/1feef3d7a7f93a0cc921e9caa7c0fee1f37e6143

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=300848

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.7.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel