[Bug 298265] New: Embedded preview changes from full to reduced size regardless album view settings

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

            Bug ID: 298265
          Severity: major
           Version: unspecified
          Priority: NOR
          Assignee: [hidden email]
           Summary: Embedded preview changes from full to reduced size
                    regardless album view settings
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: openSUSE RPMs
            Status: UNCONFIRMED
         Component: Preview
           Product: digikam

Hi,  I am not sure how this bug may be related to #275400, but it happens to me
that some files are shown in full size preview and others in reduced size,
despite on the "album view" settings (settings/configure digikam/album view) i
have selected "embedded preview loads full-sized images".
Even when deselecting this option, I get the same behavior. The preview does
not stay in one specific mode. It switches depending on the file. I have not
found anything different among the files since they were taken with the same
camera, format etc.
The reduced-size preview, is blurry as mentioned on #275400 and also
corresponds to an older version of the file. It seems like a thumbnail of the
original file, prior the use of the editor (i.e. transforming/aspect radio
crop..).  I have cropped several images, but the reduced size preview still
shows them prior their edition and very blurry.

- I do want to fix the preview to full size but it does not hold. It keeps
switching to full or reduced size without apparent reason and regardless of the
embedded preview setting.
- the symptom continues regardless rebuilding fingerprints and thumbnails.

Reproducible: Always

Steps to Reproduce:
1.in "album view" clic any file.
2.with some pics, the embedded preview is shown as full-sized, while with
others is shown as "reduced-size"
3.to change settings of "Embedded preview loads..." does not change this
behavior nor holds on a specific preview mode.
Actual Results:  
some pics are shown in reduced-size preview mode, while others in full-size.

Expected Results:  
the preview mode should stay fixed and always the same, regardless the file,
depending only to the settings on "settings/configure digikam/album
view/embedded preview loads full-sized images".

For some of the pics files the only way I found to see in full size, is using
the Editor. The light-table, slideshow, and the preview mode keep showing
reduced-size, very blurry and not including the editions (like cropping) done
to the files since they were downloaded the first time.

- Hardware: ASUS/AMD Phenom + nVidia
- OS:  OpenSuSE 12.1  (linux 3.1.9-1.4-desktop x86_64)
- GUI: KDE 4.7.2 (4.7.2) "release 5"
- Digikam: 2.5.0 (built date Feb 3 2012)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

GPSanino <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |2.5.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=298265

Varun Herale <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Varun Herale <[hidden email]> ---
Hello,

I am not really able to replicate this bug.

Could you attach a couple of screenshots of two photos being shown in "Full
Size Preview" and "Reduced Size Preview" when "embedded preview loads
full-sized images" is checked ? [Along with the properties frame open].

Varun Herale

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #2 from GPSanino <[hidden email]> ---
Hi Varun,

thanks so much for answering about this bug.  Attached you will find the
screen  snapshots.
for bnoth cases I confirmed that I have setup digikam to load the
full-sized preview images.

- Here you can see that it loads a reduced-size.
- the reduced size is also blurry. Same under the light table, and
slideshow. Only on editor and showphoto the images are shown correct.
- you can check the versioning at right, and will see that the reduced
size also is not including the changes to the original image.

I do not know where digikam is "storing" the preview files - to attempt
deleting them and may the preview will make them again...  I even tried
by deleting some home/user/.thumbnail  image files to test if Digikam
rebuild the preview images, but it does not. By rebuilding the
thumbnails (under tool) or the fingerprints or saving to files the
meadata, the problem is not solved neither. And these changes on the
preview mode occur always with the same images. It is not random. But
the images are all the same format etc. So, no idea what Digikam is
taking into account to show different preview modes to some and not
others...

Please if there is anything else I can do to help, tell me.

Thanks so much,
gps


G. Paolo Sanino
OrcaTech
Mobil: [phone]
E-mail: [hidden email]
CP: 7640392


On 04/17/2012 11:25 AM, Varun Herale wrote:

> https://bugs.kde.org/show_bug.cgi?id=298265
>
> Varun Herale <[hidden email]> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |[hidden email]
>
> --- Comment #1 from Varun Herale <[hidden email]> ---
> Hello,
>
> I am not really able to replicate this bug.
>
> Could you attach a couple of screenshots of two photos being shown in "Full
> Size Preview" and "Reduced Size Preview" when "embedded preview loads
> full-sized images" is checked ? [Along with the properties frame open].
>
> Varun Herale
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=298265

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Gilles Caulier <[hidden email]> ---
If you can provide some test image files, it can help Varun to hack this entry.

Note: code to manage Preview loading is here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/threadimageio/previewtask.cpp#L195

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #5 from GPSanino <[hidden email]> ---
Hi Varun,

Here are two attachments with the "properties frame opened". Again, some
are previewed in full size while others in blurry-reduced-size, despite
the embedded preview load settings (full size).

regards,
gps

G. Paolo Sanino
OrcaTech
Mobil: [phone]
E-mail: [hidden email]
CP: 7640392


On 04/17/2012 11:25 AM, Varun Herale wrote:

> https://bugs.kde.org/show_bug.cgi?id=298265
>
> Varun Herale <[hidden email]> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |[hidden email]
>
> --- Comment #1 from Varun Herale <[hidden email]> ---
> Hello,
>
> I am not really able to replicate this bug.
>
> Could you attach a couple of screenshots of two photos being shown in "Full
> Size Preview" and "Reduced Size Preview" when "embedded preview loads
> full-sized images" is checked ? [Along with the properties frame open].
>
> Varun Herale
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #6 from GPSanino <[hidden email]> ---
Created attachment 70460
  --> https://bugs.kde.org/attachment.cgi?id=70460&action=edit
preview-reduced.jpg

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Varun,

Take a look into source code, Preview size loading depend of screen size and
the preview image size taken from file (delegate to libkexiv2/Exiv2)

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #8 from GPSanino <[hidden email]> ---
Hi Gilles and Varum,

Here you can find attached the same files used for the previous screen
shots.

gps


On 04/17/2012 02:47 PM, Gilles Caulier wrote:

> https://bugs.kde.org/show_bug.cgi?id=298265
>
> --- Comment #7 from Gilles Caulier <[hidden email]> ---
> Varun,
>
> Take a look into source code, Preview size loading depend of screen size and
> the preview image size taken from file (delegate to libkexiv2/Exiv2)
>
> Gilles Caulier
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #10 from Varun Herale <[hidden email]> ---
Hi Paolo,

Thanks for the images. I have one more question - Is the problem of "Reduced
Size Preview" only occurring in edited images or unedited also ?

Also, thanks Gilles for the link. I am looking into the code right now.

Varun Herale

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #11 from GPSanino <[hidden email]> ---
Hi Varum,

Exactly that is the case. I just confirmed that the original files (not
edited) are always previewed properly. However, the contrary is not
always true.
Only some of the edited images present the switching to blurry reduced
size preview problem.

Using the versioning tool, I was able to undo the changes of a file with
problems, reverting it to the original status. Then the image started to
be previewed properly. Then I edited cropping it, and saving it. That
edited frame presented again the preview problem. So, it is something
related to the changes that the file experiences when edited and saved.
But not in all cases.

One more detail is that I have some files presenting the problem, that
were edited as well (mainly crop and/or gamma adjusts), but the
versioning tool does not show the previous versions. However, the
preview shows a blurry reduced size of the original photo. Like the
attached screenshot.  The original file had two dolphins. Then I cropped
the image to one individual and saved it. Gwenview shows it properly, as
well as Showphoto and Digikam's image Editor. However, Digikam's
preview, slideshow and light table still shows the image with the two
original dolphins...

gps


On 04/17/2012 03:42 PM, Varun Herale wrote:

> https://bugs.kde.org/show_bug.cgi?id=298265
>
> --- Comment #10 from Varun Herale <[hidden email]> ---
> Hi Paolo,
>
> Thanks for the images. I have one more question - Is the problem of "Reduced
> Size Preview" only occurring in edited images or unedited also ?
>
> Also, thanks Gilles for the link. I am looking into the code right now.
>
> Varun Herale
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #12 from Varun Herale <[hidden email]> ---
Hi Paolo,

Could you untick the "embedded preview loads full-sized images" option and
check all the problem files again ?

I think the problem is only with "Full Size Preview" option, so unticking must
display expected results.

Varun Herale

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #13 from GPSanino <[hidden email]> ---
Hi Varum,
sure.  I just did it and with the untick of "loads full-sized..."  the
preview rolls back to full-sized preview.
The images that were shown blurry and reduced-scale, became properly
previewed. I am not getting the "autonomous" switch between the preview
modes.

Slideshow testing: now it looks normal.

Now testing this on the light-table, the images still are shown in
blurry reduced-size...  checking the settings of light-table I fount
selected the option "loads full-sized image".
By unticking this option, the light-table recovers the full-size preview.

So, the full-size preview feature is lost only when the setting options
to load the images in full-size are selected (for light-table as well as
album preview).

gps


On 04/17/2012 04:17 PM, Varun Herale wrote:

> https://bugs.kde.org/show_bug.cgi?id=298265
>
> --- Comment #12 from Varun Herale <[hidden email]> ---
> Hi Paolo,
>
> Could you untick the "embedded preview loads full-sized images" option and
> check all the problem files again ?
>
> I think the problem is only with "Full Size Preview" option, so unticking must
> display expected results.
>
> Varun Herale
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=298265

Varun Herale <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #14 from Varun Herale <[hidden email]> ---
Okay :)

So the problem is with displaying when "embedded preview loads full-sized
images" is ticked. I will start working on the code now. I will get back to you
if I have any more questions.

Also, the captions saying "Full Size Preview" and "Reduced Size Preview" are
not based on whether the checkbox is ticked or not.. so it might be misleading
sometimes!

Varun Herale

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #15 from GPSanino <[hidden email]> ---
Varun, that is the case.  When the option for full-size image loading
is selected on Album Preview's settings, some of the edited images are
previewed in "reduced-size" mode, but presenting really a very blurry
pre-edition version of the image. The captions are indeed showing the
"autonomous" switching between the preview modes, being based on the
resulting size preview rather than the loading settings.
Same case with the captions for the Light-table.
gps


On 04/17/2012 04:46 PM, Varun Herale wrote:

> https://bugs.kde.org/show_bug.cgi?id=298265
>
> Varun Herale <[hidden email]> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|UNCONFIRMED                 |NEW
>      Ever confirmed|0                           |1
>
> --- Comment #14 from Varun Herale <[hidden email]> ---
> Okay :)
>
> So the problem is with displaying when "embedded preview loads full-sized
> images" is ticked. I will start working on the code now. I will get back to you
> if I have any more questions.
>
> Also, the captions saying "Full Size Preview" and "Reduced Size Preview" are
> not based on whether the checkbox is ticked or not.. so it might be misleading
> sometimes!
>
> Varun Herale
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #16 from Gilles Caulier <[hidden email]> ---
Varun,

Another links in source code :

Likexiv2 preview extraction interface :

https://projects.kde.org/projects/kde/kdegraphics/libs/libkexiv2/repository/revisions/master/entry/libkexiv2/kexiv2previews.h

digiKam preview widget :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/views/imagepreviewview.cpp

digiKam preview item :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/graphicsview/dimgpreviewitem.cpp#L67

The last one is very important. Look like size of preview is passed in this
method to preview load thread, accordingly to screen size.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[GPSanino]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #17 from GPSanino <[hidden email]> ---
Hi Varun and Gilles,
Not so good news... I just found an image with the same problem of blurry
reduced-size preview, despite unclicking the full-size preview options... So,
the changes on the settings almost got all the images previewed properly, but
there is still something relying on the back.

it looks just like the screenshot "preview-reduced-no versioning.jpg" but
despite of the deselected preview options.

gps

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #18 from Varun Herale <[hidden email]> ---
Hello,

It appears that the preview is loaded correctly if the line 157 to 173 in -

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dimg/dimg.cpp#L157

are commented out.

Marcel, Does this block of code copy the original image instead of the present
copy ?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #19 from Gilles Caulier <[hidden email]> ---
Varun,

Can you print if allocateData() return true or false ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=298265

--- Comment #20 from Varun Herale <[hidden email]> ---
(In reply to comment #19)
> Varun,
>
> Can you print if allocateData() return true or false ?
>
> Gilles Caulier

allocateData() returns True.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel