[Bug 298178] New: Move photos dialog default button is Cancel, not Ok

https://bugs.kde.org/show_bug.cgi?id=298178

            Bug ID: 298178
          Severity: normal
           Version: unspecified
          Priority: NOR
          Assignee: [hidden email]
           Summary: Move photos dialog default button is Cancel, not Ok
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Other
            Status: NEW
         Component: Usability
           Product: digikam

User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/536.4 (KHTML,
like Gecko) Chrome/19.0.1074.0 Safari/536.4 SUSE/19.0.1074.0
Build Identifier:

The "Move photos dialog" default button is Cancel, not Ok.  Compare with the
default button on the Delete Album or Move photo to Wastebin dialogs - here it
is Cancel.  This inconsistency is dangerous - I just hit Enter in Move Photos,
which cancelled the move, then deleted the album thinking they had been moved,
using Enter again.

Reproducible: Always

Actual Results:  
Inconsistent default buttons lead to hard to learn and risky UI.

Expected Results:  
Same default button on all similar dialogs

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=298178

--- Comment #1 from Will Stephenson <[hidden email]> ---
I just noticed that the inconsistency is shown best if you try to move photos
to the album that is selected by default in the Move Photos dialog, for
example, the album moved to the last time the dialog was used.  Then Cancel is
focused.

On the other hand, if you have to select an album in the treeview with the
cursor keys, pressing Enter with the treeview focussed Ok's the dialog.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=298178

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|unspecified                 |2.5.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=298178

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Smit Mehta <[hidden email]> ---
Hi

Gilles, what do you suggest? Should I change it?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=298178

--- Comment #3 from Gilles Caulier <[hidden email]> ---
I'm not sure to understand the problem. Someone can take some screenshot of GUI
in action please ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=298178

--- Comment #4 from Smit Mehta <[hidden email]> ---
Created attachment 70397
  --> https://bugs.kde.org/attachment.cgi?id=70397&action=edit
screenshot

Steps to reproduce ->
(i) right click on any image
(ii) click on 'move to album...'

the default button is 'cancel' here, while the user wants it to be 'okay'
because of uniformity issues.

smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=298178

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Yes, it's fine to patch dialog...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=298178

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Smit Mehta <[hidden email]> ---
Git commit 3d55be27b7893945cc6f158cf0613e8c8cda62c0 by smit mehta.
Committed on 15/04/2012 at 19:37.
Pushed by smitmehta into branch 'master'.

Default button 'Ok' for maintaining uniformity

M  +2    -1    NEWS
M  +0    -1    digikam/album/albumselectdialog.cpp

http://commits.kde.org/digikam/3d55be27b7893945cc6f158cf0613e8c8cda62c0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=298178

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=298178

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Usability-Ergonomy

--
You are receiving this mail because:
You are the assignee for the bug.