[Bug 297970] New: Wrong image deleted

https://bugs.kde.org/show_bug.cgi?id=297970

            Bug ID: 297970
          Severity: critical
           Version: unspecified
          Priority: NOR
          Assignee: [hidden email]
           Summary: Wrong image deleted
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Mageia RPMs
            Status: UNCONFIRMED
         Component: Image Editor
           Product: digikam

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20100101
Firefox/10.0.3
Build Identifier:

In image editor, when I click on "Mettre à la corbeille" (move to trash ?),
it's not the current image ("image A") that is delete but the next in the album
("image B").  Then the image editor show me the next-next image ("image C").
With the action "supprimer un fichier définitivement" (erase permanently ?),
it's the same bug. So, no image to restore in the trash.

Reproducible: Always

Steps to Reproduce:
1. click on "Mettre à la corbeille"
2.
3.
Actual Results:  
The wrong image is deleted

Expected Results:  
the current must be deleted

Tested on :
digiKam
Version 2.6.0-beta3
Utilisation de la plate-forme de développement de KDE 4.8.2 (4.8.2)

From Mageia 2 beta 2

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=297970

Axone <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=297970

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--- Comment #1 from Gilles Caulier <[hidden email]> ---
i can reproduce here...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=297970

--- Comment #2 from Varun Herale <[hidden email]> ---
Created attachment 70506
  --> https://bugs.kde.org/attachment.cgi?id=70506&action=edit
Patch for Wrong Image Deleted.

Hello,

The problem is that the image is being deleted after the next image is loaded.
Hence the next image is being deleted.

Attaching the proposed patch for this bug.

Varun Herale

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=297970

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Wrong image deleted         |Wrong image deleted [patch]

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Excelent.

Smit, can you test the patch please ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=297970

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Smit,

If patch work fine, let's go to apply it to git/master

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=297970

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Smit Mehta <[hidden email]> ---
Git commit 43722b6fcf3a16cfe5663d5aede2207d5255603b by smit mehta.
Committed on 19/04/2012 at 19:26.
Pushed by smitmehta into branch 'master'.

Wrong image deleted

M  +3    -3    NEWS
M  +2    -2    utilities/imageeditor/editor/imagewindow.cpp

http://commits.kde.org/digikam/43722b6fcf3a16cfe5663d5aede2207d5255603b

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=297970

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel