|
https://bugs.kde.org/show_bug.cgi?id=295423
--- Comment #19 from Kevin Kofler <[hidden email]> --- I'd say the same, just Eigen should be enough. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=295423
--- Comment #20 from Kevin Kofler <[hidden email]> --- And by the way, I'd personally not bother making it optional. In fact, as a distro packager, I don't like optional dependencies at all, I want my build to fail hard if I'm missing a BuildRequires, not silently build a crippled package. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=295423
--- Comment #21 from Kevin Kofler <[hidden email]> --- PS (and sorry for the 3 posts in sequence): (and for us, even printing a warning to stdout or stderr at build time is still "silent", we rarely look at build logs for successful builds) -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=295423
--- Comment #22 from Francesco Riosa <[hidden email]> --- (In reply to comment #20) > And by the way, I'd personally not bother making it optional. In fact, as a > distro packager, I don't like optional dependencies at all, I want my build > to fail hard if I'm missing a BuildRequires, not silently build a crippled > package. Kevin what you want is a package that fail hard if a *requested* option miss a dependancy. If for whatever reason someone don't need that function it could still be a good thing being able to remove it. However if unwanted the function (and dep.) should NOT magically being added That said in this case depend unconditionally upon eigen seem a good thing since it already work on all digikam supported platforms, it's a build time dependancy and what use it is almost universally useful. just 2c -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=295423
--- Comment #23 from Kevin Kofler <[hidden email]> --- > Kevin what you want is a package that fail hard if a *requested* option miss a dependancy. Unfortunately, that's not good enough (and it's a common mistake made by developers, and in fact the whole optional dependency system in KDE gets that wrong). The package should fail hard if I did NOT explicitly request that I DON'T want the dependency. Everything not explicitly disabled should be required. Otherwise, when you add some new functionality, it is still likely to be missing in packages, because if we don't know to add the BuildRequires, we also won't know about the -D switch to add to explicitly request the feature. Opt-in requesting is entirely useless for packaging, we already opt in by adding a BuildRequires to our packages, it needs to be opt-out! I think we should probably have some "packager mode" in CMake (a -D flag we could add to our %cmake RPM macro) where all the optional dependencies are required unless explicitly disabled. But this is getting way out of the scope of this bug. ;-) -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=295423
--- Comment #24 from Francesco Riosa <[hidden email]> --- (In reply to comment #23) Fair enough, only thing yet uncovered are mutually exclusive options. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=295423
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Version Fixed In| |3.2.0 Resolution|--- |FIXED Latest Commit| |http://commits.kde.org/digi | |kam/84d745a59bd0f9d9697b50b | |9f8558d368d956faf -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
| Free forum by Nabble | Edit this page |
