[Bug 295104] New: ambiguity in core/libs/dimg/filters/fx/blurfilter.cpp

https://bugs.kde.org/show_bug.cgi?id=295104

           Summary: ambiguity in core/libs/dimg/filters/fx/blurfilter.cpp
           Product: digikam
           Version: 2.5.0
          Platform: Compiled Sources
        OS/Version: Solaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Filters
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=69196)
 --> (http://bugs.kde.org/attachment.cgi?id=69196)
patch

Version:           2.5.0 (using KDE 4.8.0)
OS:                Solaris

building digikam 2.5 fails with the below error

Reproducible: Always

Steps to Reproduce:
try to build digikam

Actual Results:  
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/core/libs/dimg/filters/fx/blurfilter.cpp",
line 213: Error: Overloading ambiguity between "std::sqrt(double)" and
"std::sqrt(float)".


Expected Results:  
builds fine

Solaris 11, Solaris Studio 12.3, amd64

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=295104


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|ambiguity in                |sdt namespace ambiguity in
                   |core/libs/dimg/filters/fx/b |BlurFilter [patch]
                   |lurfilter.cpp               |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=295104


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2012-02-29 23:12:53 ---
Git commit 5f28bbb8fcf32a3f2914414928c3c0493667d4cd by Gilles Caulier.
Committed on 01/03/2012 at 00:11.
Pushed by cgilles into branch 'master'.

apply patch #69196 to compile fine under Solaris

M  +9    -5    libs/dimg/filters/fx/blurfilter.cpp
M  +12   -7    libs/dimg/filters/fx/blurfilter.h

http://commits.kde.org/digikam/5f28bbb8fcf32a3f2914414928c3c0493667d4cd

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=295104


tropikhajma <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69196|0                           |1
        is obsolete|                            |




--- Comment #2 from tropikhajma <tropikhajma gmail com>  2012-02-29 23:17:22 ---
Created an attachment (id=69197)
 --> (http://bugs.kde.org/attachment.cgi?id=69197)
patch

actually there's more of such issues in nearby files.
Also on e occurence of
...
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/core/libs/dimg/filters/lc/localcontrastcontainer.cpp",
line 68: Error: The function "pow" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/core/libs/dimg/filters/lc/localcontrastcontainer.cpp",
line 80: Error: The function "pow" must have a prototype

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=295104





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2012-03-01 08:21:03 ---
Git commit e5742da0aefce01ab6d05757fe3a4ac4688c8da7 by Gilles Caulier.
Committed on 01/03/2012 at 09:19.
Pushed by cgilles into branch 'master'.

apply patch #69197 to compile fine under Solaris

M  +11   -9    libs/dimg/filters/fx/blurfilter.cpp
M  +14   -16   libs/dimg/filters/fx/blurfxfilter.cpp
M  +11   -6    libs/dimg/filters/fx/blurfxfilter.h
M  +13   -15   libs/dimg/filters/fx/colorfxfilter.cpp
M  +9    -4    libs/dimg/filters/fx/colorfxfilter.h
M  +58   -87   libs/dimg/filters/fx/distortionfxfilter.cpp
M  +12   -20   libs/dimg/filters/fx/distortionfxfilter.h
M  +37   -39   libs/dimg/filters/fx/raindropfilter.cpp
M  +17   -12   libs/dimg/filters/fx/raindropfilter.h
M  +8    -5    libs/dimg/filters/lc/localcontrastcontainer.cpp
M  +2    -4    libs/dimg/filters/lc/localcontrastcontainer.h
M  +43   -40   libs/dimg/filters/lc/localcontrastfilter.cpp
M  +11   -7    libs/dimg/filters/lc/localcontrastfilter.h

http://commits.kde.org/digikam/e5742da0aefce01ab6d05757fe3a4ac4688c8da7

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=295104





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2012-03-01 08:27:36 ---
tropikhajm,

It's safe to remplace all supported match.h function into qmath.h from Qt4 :

pow => qPow
log => qLn
exp => qExp
sin => qSin
cos => qCos
tan => qTan
floor => qFloor
ceil => qCeil
asin => qAsin
acos => qAcos
fabs => qFabs
atan => qAtan
atan2 => qAtan2
sqrt => qSqrt

Removing cmath.h from file is safe too, because it's included to qmath.h.

If you have more similar patches to apply about this math functions, please
follow this way.

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=295104

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel