[Bug 291110] New: Watermark size original/unchanged/pixels/points

[DrSlony-3]

https://bugs.kde.org/show_bug.cgi?id=291110

           Summary: Watermark size original/unchanged/pixels/points
           Product: digikam
           Version: 2.5.0
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.5.0 (using KDE 4.7.4)
OS:                Linux

I would like to be able to set the Batch Queue Manager to create a watermark:
1- using a font size in pixels or points,
2- or when using a PNG, to have the PNG untouched, its original size.

Reproducible: Always



Expected Results:  
1- px and pt font size
2- original PNG dimension

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=291110


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Batch Queue Manager




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=291110

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Watermark size              |BQM Watermark tool : size
                   |original/unchanged/pixels/p |original/unchanged/pixels/p
                   |oints                       |oints

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=291110

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|2.5.0                       |4.2.0

--- Comment #1 from DrSlony <[hidden email]> ---
Still valid in 4.2.0.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Tool-Inse
                   |                            |rtText

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

Ahmed Fathi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmed.fathi.abdelmageed@gma
                   |                            |il.com

--- Comment #2 from Ahmed Fathi <[hidden email]> ---
Created attachment 103721
  --> https://bugs.kde.org/attachment.cgi?id=103721&action=edit
absolute fonts and images

I created a patch for this problem. now you have a new checkbox called "use
absolute size". if you check the box , the size percentage slider is disabled
for both image and text watermarks. furthermore , in the text mode , when you
activate this checkbox , A column of font sizes to choose from gets enabled ,
otherwise it is disabled. Note : This patch assumes the user knows what he is
doing. so if the user selects a font size so large that the water mark text
typed is beyond the image boundaries , no automatic scaling is done. As it is
assumed that if the user wants automatic scaling, he would have used the size
slider instead

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

--- Comment #3 from DrSlony <[hidden email]> ---
Sounds good. I don't compile my own digiKam so I won't be able to test until
its released.

Scaling should absolutely not be done if setting font size manually, otherwise
it would be misleading.

Why "a column of font sizes"? A spin box would be ideal.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

--- Comment #4 from Ahmed Fathi <[hidden email]> ---
Created attachment 103722
  --> https://bugs.kde.org/attachment.cgi?id=103722&action=edit
Photo To indicate current look

It is to be said that I modified the way the user chooses text in another
bugzilla entry to enable different font styles and the current configuration is
just like the photo I am uploading here, just without the rightmost size
column. So I thought a size column would be bette in this configuration .  I
thought adding this column is better looking than just a  spin box or text box
,  as the (vertical) space is already occupied by the other two columns for
font and style. What do you think ?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

--- Comment #5 from [hidden email] ---
Ahmed,

Do you add a tooltip to checkbox to explain to end user the option effect ?

DrSlony,

The other bugzilla entry that Ahmed said in comment #4 is bug #339460.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

--- Comment #6 from DrSlony <[hidden email]> ---
@Ahmed that looks good. The "Size" column includes a spin button, so it's all
good.

@Caulier well I haven't been able to test this yet, but Ahmed's description
sounds simple enough, so there's probably no need for a tooltip.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/f9121cd5122be78cb01714
                   |                            |19b150634f9b215791
   Version Fixed In|                            |5.5.0
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from [hidden email] ---
Git commit f9121cd5122be78cb0171419b150634f9b215791 by Gilles Caulier.
Committed on 31/01/2017 at 08:15.
Pushed by cgilles into branch 'master'.

apply patch #103721 from Ahmed Fathi to use absolute fonts with images.
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +74   -35   utilities/queuemanager/tools/decorate/watermark.cpp
M  +2    -1    utilities/queuemanager/tools/decorate/watermark.h

https://commits.kde.org/digikam/f9121cd5122be78cb0171419b150634f9b215791

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

--- Comment #8 from [hidden email] ---
DrSlony,

I applied the patch. This evening, i will rebuild the AppImage 5.5.0 to test
and available at usual place from GDrive repository.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

--- Comment #9 from Ahmed Fathi <[hidden email]> ---
@Guilles It is a little late but  I yes made a "what's this"  discription for
the checkbox for help
@DrSlony yes it is all good thank you :)

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

--- Comment #10 from [hidden email] ---
DrSlony,

The new pre-version of 64 bits AppImage bundle 5.5.0 will be uploaded to GDrive
in few minutes, including the last patch committed in this report.

https://docs.google.com/document/d/1YOFkqIcoopQGZVWa3wioKz5Ue22Mi68dLYsG_YB2XSo/edit?usp=sharing

You can test with it.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=291110

--- Comment #11 from [hidden email] ---
Youps sorry wrong url. right one :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

--
You are receiving this mail because:
You are the assignee for the bug.