[Bug 291080] New: In settings, arrange ALL export options at ONE place

classic Classic list List threaded Threaded
31 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 291080] In settings, arrange ALL export options at ONE place

Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #19 from Axel Krebs <[hidden email]> ---
Am 09.01.2012 21:28, schrieb Gilles Caulier:

> https://bugs.kde.org/show_bug.cgi?id=291080
>
>
> Gilles Caulier <[hidden email]> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |[hidden email]
>           Component|Export                      |libkipi
>
>
>
>
Thanks for your information Gilles!

...looks great... thank you for your efforts!

Axel

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 291080] In settings, arrange ALL export options at ONE place

Victor Dodon
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #20 from Victor Dodon <[hidden email]> ---
Gilles, look at my commit
http://commits.kde.org/libkipi/7fda90dd9ea659b96eed892cb5ff83bf0c88a4d2 . This
is the solution I propose with getting the category of the action. The code
needs polish and it's not finished, but you need to look at and to tell what
you think. Use kxmlkipicmd to test that plugin actions are added right in the
"Configure shortcuts dialog".

By the way, do we realy need to store more widgets in a map in Plugin class?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 291080] In settings, arrange ALL export options at ONE place

Gilles Caulier-4
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #21 from Gilles Caulier <[hidden email]> ---
Victor,

1/ Instead to use a dedicated method to group KAction + Category :

 void addAction(KAction* const action, Category cat);

... why not to store Category in Kaction Container as extra data :

http://qt-project.org/doc/qt-4.8/qaction.html#setData
http://qt-project.org/doc/qt-4.8/qaction.html#data

This will simplify code a lots...

2/ Your last changes include to change both code + desktop files to describe
Categories used in a plugin. Do you need that ?

3/ Instead to use code or/and desktop file to assign Categories in plugin,
what's about to use XML file as well to add extra data in XML Action definition
? It's possible ? If yes, no code need to be changed and recompiled to assign
or change Category, if libkipi is able to manage it...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 291080] In settings, arrange ALL export options at ONE place

Victor Dodon
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #22 from Victor Dodon <[hidden email]> ---
Gilles,

> 1/ Instead to use a dedicated method to group KAction + Category :
>
>  void addAction(KAction* const action, Category cat);
>
> ... why not to store Category in Kaction Container as extra data :
>
> http://qt-project.org/doc/qt-4.8/qaction.html#setData
> http://qt-project.org/doc/qt-4.8/qaction.html#data
>
> This will simplify code a lots...

I think that is more intuitive to use addAction(KAction* const, Category), and
in this way, plugins will no longer need the category method as it is
implemented in the Plugin class. This will also simplify the code a lot.

> 2/ Your last changes include to change both code + desktop files to describe
> Categories used in a plugin. Do you need that ?

Changes in the desktop files were necessary to know the plugin category even
when a plugin is not loaded. In the previous implementation we could not now
the plugin category if the plugin is not loaded. This is how it looked when
plugin were not loaded: http://img52.imageshack.us/img52/7243/shot50.png , and
this is how it looks now: http://img19.imageshack.us/img19/1152/shot49.png

> 3/ Instead to use code or/and desktop file to assign Categories in plugin,
> what's about to use XML file as well to add extra data in XML Action
> definition ? It's possible ? If yes, no code need to be changed and
> recompiled to assign or change Category, if libkipi is able to manage it...

As I can see from xmlgui standard
http://www.kde.org/standards/kxmlgui/1.0/kxmlgui.xsd accepted atributes for
Action are only: name, group, append, text, whatsThis, tooltip, iconText,
shortcut, icon, priority. And I don't think is a good idea to add non-standard
attributes.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 291080] In settings, arrange ALL export options at ONE place

Gilles Caulier-4
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #23 from Gilles Caulier <[hidden email]> ---
1/ But internally, storing Category to KAction as extra data will simplify map
container :

you can use old map :
    QMap<QWidget*, QList<KAction*> >   actions;

instead new one :

    QMap<QWidget*, QMap<KAction*, Category> > actionsCat;

2/ ok
3/ ok

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 291080] In settings, arrange ALL export options at ONE place

Victor Dodon
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #24 from Victor Dodon <[hidden email]> ---
Gilles.
1. But then setData will not be available to programmers for use.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 291080] In settings, arrange ALL export options at ONE place

Gilles Caulier-4
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #25 from Gilles Caulier <[hidden email]> ---
1/ Right. Note that it's not common to use extra data with QAction. At least in
kipi-plugins.
But as we let's action managed by KDELibs, we don't know if extra data are not
add to action for rules purpose...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 291080] In settings, arrange ALL export options at ONE place

Gilles Caulier-4
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #26 from Gilles Caulier <[hidden email]> ---
Git commit f7082c74e87c0861f7829eae70a0a7cb1f6145c7 by Gilles Caulier.
Committed on 08/08/2012 at 13:12.
Pushed by cgilles into branch 'development/2.0.0'.

add new method to extract kipi-plugins version from common kipiplugins.desktop
file
Print libkipi and kipi-plugins version on plugins config widget

M  +11   -1    libkipi/configwidget.cpp
M  +20   -0    libkipi/pluginloader.cpp
M  +2    -0    libkipi/pluginloader.h

http://commits.kde.org/libkipi/f7082c74e87c0861f7829eae70a0a7cb1f6145c7

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[libkipi] [Bug 291080] In settings, arrange ALL export options at ONE place

bugzilla_noreply
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikam                     |libkipi
            Version|2.5.0                       |unspecified
           Assignee|[hidden email]       |[hidden email]
          Component|libkipi                     |General

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 291080] In settings, arrange ALL export options at ONE place

bugzilla_noreply
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|libkipi                     |digikam
           Assignee|[hidden email]         |[hidden email]
          Component|General                     |Kipiinterface

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[libkipi] [Bug 291080] In settings, arrange ALL export options at ONE place

bugzilla_noreply
In reply to this post by Axel Krebs
https://bugs.kde.org/show_bug.cgi?id=291080

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]       |[hidden email]
          Component|Kipiinterface               |General
            Product|digikam                     |libkipi

--
You are receiving this mail because:
You are the assignee for the bug.
12