[Bug 290930] New: Cannot resize gamut diagram vertically, only horizontally

[DrSlony-3]

https://bugs.kde.org/show_bug.cgi?id=290930

           Summary: Cannot resize gamut diagram vertically, only
                    horizontally
           Product: digikam
           Version: 2.5.0
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.5.0 (using KDE 4.7.4)
OS:                Linux

The gamut diagram can be resized horizontally by resizing the right panel.
However, you cannot resize it vertically.

Reproducible: Didn't try



Expected Results:  
We should be able to resize it vertically by dragging the top of the box up.

http://i.imgur.com/QIuIe.png

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-3]

https://bugs.kde.org/show_bug.cgi?id=290930





--- Comment #1 from DrSlony <bugs seeitmyway org>  2012-01-08 03:27:57 ---
http://i.imgur.com/QIuIe.png

I tried to make it bigger so I can take a nice screenshot of it (until the
feature request for saving it to disk gets implemented) but I cannot resize it
vertically, so it's very disproportionate.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-3]

https://bugs.kde.org/show_bug.cgi?id=290930





--- Comment #2 from DrSlony <bugs seeitmyway org>  2012-01-08 03:28:54 ---
Oops, wrong url for previous comment #1, here's the correct one:
http://i.imgur.com/ZEtqD.png

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290930


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Color Management




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=290930

--- Comment #3 from DrSlony <[hidden email]> ---
Still cannot resize vertically in 3.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=290930

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.5.0                       |4.2.0

--- Comment #4 from DrSlony <[hidden email]> ---
Still valid for 4.2.0.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290930

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Maik,

Current implementation of CIETongueWidget is voluntary limited to resize
content horizontally.

It's a limitation in rules from preview widget plug in image properties
sidebar. It's not a limitation of widget as well. Widget can be re-sized
vertically of course.

I propose to use QScrollArea to host this widget and to permit to zoom in/out
and pan over ICC profile content.

What do you think about ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=290930

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Gilles,

I find the best representation for the CIETongueWidget is square. What do you
think?

diff --git a/libs/widgets/iccprofiles/cietonguewidget.cpp
b/libs/widgets/iccprofiles/cietonguewidget.cpp
index 6c87e59..f309f4f 100644
--- a/libs/widgets/iccprofiles/cietonguewidget.cpp
+++ b/libs/widgets/iccprofiles/cietonguewidget.cpp
@@ -811,6 +811,8 @@ void CIETongueWidget::paintEvent(QPaintEvent*)
 void CIETongueWidget::resizeEvent(QResizeEvent* event)
 {
     Q_UNUSED(event);
+
+    setMinimumHeight(width());
     d->needUpdatePixmap = true;
 }

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=290930

--- Comment #7 from DrSlony <[hidden email]> ---
The best representation depends on the shape of the gamut and on the needs of
the user.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290930

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Maik,

The square aspect ratio can be a good compromise as touch in code is very
small...

At least it's better than previous solution which is not very elegant...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=290930

--- Comment #9 from DrSlony <[hidden email]> ---
I agree that it's an improvement and probably good enough.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=290930

--- Comment #10 from Maik Qualmann <[hidden email]> ---
Created attachment 92561
  --> https://bugs.kde.org/attachment.cgi?id=92561&action=edit
splitter.png

Or insert a splitter and the user can change the size? The state of the
splitter would be probably saved.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290930

--- Comment #11 from Gilles Caulier <[hidden email]> ---
I tried square auto resize, and it's perfect and enough.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=290930

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.11.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/3ccf141ec47ffca4fd7f7a1
                   |                            |b2d3929c74ac6ec3a
         Resolution|---                         |FIXED

--- Comment #12 from Maik Qualmann <[hidden email]> ---
Git commit 3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a by Maik Qualmann.
Committed on 13/05/2015 at 10:35.
Pushed by mqualmann into branch 'master'.

set CIETongueWidget to square view
FIXED-IN: 4.11.0

M  +2    -1    NEWS
M  +1    -0    libs/widgets/iccprofiles/cietonguewidget.cpp

http://commits.kde.org/digikam/3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290930

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Git commit fedad652d305032959a45f626f5bd49c031a9e50 by Gilles Caulier.
Committed on 13/05/2015 at 11:47.
Pushed by cgilles into branch 'frameworks'.

backport commit #3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a from git/master to
frameworks branch

M  +1    -0    libs/widgets/iccprofiles/cietonguewidget.cpp
M  +1    -1    libs/widgets/iccprofiles/cietonguewidget.h

http://commits.kde.org/digikam/fedad652d305032959a45f626f5bd49c031a9e50

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel