|
https://bugs.kde.org/show_bug.cgi?id=290196
Summary: PATCH: Improvements for Levels adjust tool Product: digikam Version: unspecified Platform: Compiled Sources OS/Version: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: Image Editor AssignedTo: [hidden email] ReportedBy: [hidden email] Created an attachment (id=67257) --> (http://bugs.kde.org/attachment.cgi?id=67257) Patch implementing the described improvement Version: unspecified (using KDE 4.7.3) OS: Linux Enable Color Channels histogram type in Levels tool This patch enables the "Color Channels" histogram type in the Levels tool. It is helpful when adjusting luminosity to observe if any of the color channels clip, which leads to false highlight colors. The patch also implements a second function: if Color Channels is selected, Black and White tone pickers work on all of the color channels simultaneously instead of having to iterate over R, G and B. It is very helpful for removing the color mask of a scanned film negative. Reproducible: Didn't try Expected Results: Vastly improved functionality of Levels adjustment tool after applying the patch :-) The patch applies to the master branch of digigkam-sc core.git. It was created with "git format-patch" and can simply be applied with "git am 0001-Enable-Color-Channels-histogram-type-in-Levels-tool.patch" -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
https://bugs.kde.org/show_bug.cgi?id=290196
Matthias Welwarsky <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67257|0 |1 is obsolete| | --- Comment #1 from Matthias Welwarsky <matze welwarsky de> 2011-12-30 18:16:42 --- Created an attachment (id=67258) --> (http://bugs.kde.org/attachment.cgi?id=67258) Updated patch Updated patch, removing the change to adjustlevelstool.h, which is superfluous. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Matthias Welwarsky
https://bugs.kde.org/show_bug.cgi?id=290196
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] Version|unspecified |2.5.0 --- Comment #2 from Gilles Caulier <caulier gilles gmail com> 2011-12-30 21:18:39 --- Matthias, I tested your patch and it work fine for me. Let's go to commit your patch in git /master... Gilles Caulier -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Matthias Welwarsky
https://bugs.kde.org/show_bug.cgi?id=290196
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Gilles Caulier <caulier gilles gmail com> 2011-12-31 13:57:33 --- Git commit 654ad777755c8e70c5702a257f26b7d602109e8f by Gilles Caulier. Committed on 31/12/2011 at 14:56. Pushed by cgilles into branch 'master'. polish patch for Matthias Welwarsky and close relevant file in bugzilla M +45 -38 imageplugins/color/adjustlevelstool.cpp M +1 -1 imageplugins/color/adjustlevelstool.h http://commits.kde.org/digikam/654ad777755c8e70c5702a257f26b7d602109e8f -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Matthias Welwarsky
https://bugs.kde.org/show_bug.cgi?id=290196
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |2.5.0 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
| Free forum by Nabble | Edit this page |
