[Bug 290157] New: libkdcraw should support LCMS2

https://bugs.kde.org/show_bug.cgi?id=290157

           Summary: libkdcraw should support LCMS2
           Product: digikam
           Version: 2.5.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: libkdcraw
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.5.0 (using Devel)
OS:                Linux

the underlying libraw can use LCMS2, but libkdcraw does not check for it

/var/git/kde-graphics/libkdcraw$ git grep lcms
CMakeLists.txt:macro_log_feature(LCMS_FOUND "lcms" "A small-footprint color
management engine" "http://ww
ChangeLog:        Make it to find the lcms from nonstandard places provided by
user
ChangeLog:        --with-extra-* flags. Fixes detecting lcms installed from
pkgsrc
ChangeLog:        no need to link with lcms. Only dcraw.c require it
README:liblcms    >= 1.14.x (used by libraw)  http://www.littlecms.com
libraw/libraw/libraw_types.h:#include <lcms.h>
libraw/libraw/libraw_types.h:#include <lcms2.h>


Reproducible: Always


Actual Results:  
only uses lcms1

Expected Results:  
builds with lcms2

improve CMakeLists.txt to check for and use LCMS2 which is more stable and
thread safe.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290157


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-30 10:41:59 ---
patch is welcome to support lcms2.

note: i already tried to port all code from digiKAm from lcms to lcms2, and API
are changed indeep without any guide and help to do it quickly.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=290157





--- Comment #2 from Treeve Jelbert <treeve scarlet be>  2011-12-30 11:17:10 ---
Created an attachment (id=67240)
 --> (http://bugs.kde.org/attachment.cgi?id=67240)
lcms2 patch

patch to use lcms2 instead of lcms1

the FindLCMS2.cmake file comes from the Calligra project, who have dropped
support for lcms1 completely.

everything builds and links ok for me using lcms2-2.3

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290157


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|libkdcraw should support    |libkdcraw should support
                   |LCMS2                       |LCMS2 [patch]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290157





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-12-30 11:25:38 ---
Treeve,

Thanks for you patch.

On my systems (Mandriva and Mageia), LCMS2 is not yet available by default.

So, LCMS must be checked first and after LCMS2, at least for transition time.
Please fix your patch accordingly. Do not drop LCMS as well.

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=290157


Treeve Jelbert <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67240|0                           |1
        is obsolete|                            |




--- Comment #4 from Treeve Jelbert <treeve scarlet be>  2011-12-30 12:12:22 ---
Created an attachment (id=67245)
 --> (http://bugs.kde.org/attachment.cgi?id=67245)
alllow either lcms1 or lcms2

revised patch, now checks for either of lcms1/2
tested with all combinations installed or missing

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290157


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2011-12-30 19:12:04 ---
Git commit d0e61353aeff0ec89cfa4a2de0c767286784c239 by Gilles Caulier.
Committed on 30/12/2011 at 20:10.
Pushed by cgilles into branch 'master'.

apply patch #67240 from Treeve Jelbert to support LCMS or LCMS2 as Color
Management shared lib.

M  +19   -7    CMakeLists.txt
A  +72   -0    cmake/modules/FindLCMS2.cmake

http://commits.kde.org/libkdcraw/d0e61353aeff0ec89cfa4a2de0c767286784c239

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=290157


Philip Muskovac <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Philip Muskovac <yofel gmx net>  2012-02-14 19:45:51 ---
Ubuntu plans to depcrecate lcms1 for 12.04 which will ship with KDE 4.8. Can
this be safely cherry-picked for 4.8? I've confirmed that it builds, now the
question is whether it'll work.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=290157

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.5.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel