[Bug 289262] New: Hitting ESC in "fullscreen picture preview" messes up thumbbar-state in "thumbnail view"

[Peter Albrecht-2]

https://bugs.kde.org/show_bug.cgi?id=289262

           Summary: Hitting ESC in "fullscreen picture preview" messes up
                    thumbbar-state in "thumbnail view"
           Product: digikam
           Version: 2.4.0
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Albums GUI
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.4.0 (using KDE 4.7.3)
OS:                Linux

Switching through a few picture view modes, you can and up in "thumbnail view
with a thumbbar enabled".

Reproducible: Always

Steps to Reproduce:
1. start digikam
2. select album with picture
 -> thumbnail-view (no thumbnail-bar on top)

3. doubleclick/ENTER
 -> switch from "thumbnail view" to "image preview"
    (thumbnail-bar visible on top)

4. CTRL + SHIFT + F
 -> full screen view, but no thumbnail-bar visible on top

5. Hit ESC
 -> switches from "full-screen preview mode" to "full-screen thumbnail view"
(no thumbbar on top)

6. leave "full-screen mode" with CTRL + SHIFT + F

Actual Results:  
Non-full-screen thumbnail with __with thumbbar enabled__. This is funny, but
not very useful. It only fills up unnecessary space on the screen.

Also the toolbar-button "Show Thumbbar" (if added manually) is disabled, so you
can't turn the thumbbar off. Same applies to Shortcut: CTRL + T

Expected Results:  
In thumbnail-view, the thumbbar should be disabled.

You can fix this state by switching to "preview mode" (doubleclick / ENTER) and
back (ESC). So it is no extreme workflow blocker, but it is annoying and
confusing.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=289262


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-18 10:28:11 ---
*** Bug 278346 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Peter Albrecht-2]

https://bugs.kde.org/show_bug.cgi?id=289262





--- Comment #2 from Peter Albrecht <px79 crazymonkeys de>  2011-12-18 10:45:44 ---
See also wish at Bug #289264

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #3 from [hidden email] ---
I'm not sure that "Bug 278346 - status bar is not preserved in full screen
mode"" is a duplicate.
The problem is still valid in 2.5 (will test when upgraded to 2.6) and affects
also menubar in full screen.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #4 from [hidden email] ---
See also Bug Bug 214107. status bar still not preserved in full screen mode in
2.6

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #5 from [hidden email] ---
still valid in 2.8.0 (kde 4.8.5, lubuntu 12.04 ppa). worse, even if the status
bar is not displayed, progress manager still pop up with some kind of screen
artifacts.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #6 from [hidden email] ---
I tested recently behavior of menubar and toolbar on 2.8.0 and they are
preserved between full screen/non full mode so what's the difference between
status bar ?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Peter Albrecht-2]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #7 from Peter Albrecht <[hidden email]> ---
Still valid in digikam 2.9.0 with KDE 4.8.5.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=289262

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|2.4.0                       |2.9.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=289262

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Smit Mehta <[hidden email]> ---
Hi Peter, julien.t43+kde,

Could you please provide a couple of screenshots?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #9 from [hidden email] ---
Created attachment 74762
  --> https://bugs.kde.org/attachment.cgi?id=74762&action=edit
screenshot with normal window

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #10 from [hidden email] ---
Created attachment 74763
  --> https://bugs.kde.org/attachment.cgi?id=74763&action=edit
screenshot in full screen mode

Here screenshots from normal to fullscreen mode, toolbar disabled and status
preserved (if enabled, kept visible), menubar enabled and disappeared (but if
disabled in normal mode, it will still be invisible in fullscreen mode and when
back in normal mode), statusbar disabled and disappear (to make appear, need
either the toolbar, either to have attributed a shortcut)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Peter Albrecht-2]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #11 from Peter Albrecht <[hidden email]> ---
Created attachment 74766
  --> https://bugs.kde.org/attachment.cgi?id=74766&action=edit
Screenshot of digikam after step 6 (in the "Steps to Reproduce" list)

This is, what digikam looks like, after replaying the "steps to reproduce"
list. In the upper rectangle you see thumbnails in the thumbbar and in the
lower rectangle, you see thumbnails in "main client area" (how do you call
this?).
Displaying two thumbnail lists of the same fotos does not make very much sense.
;)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[julien.t43+kde]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #12 from [hidden email] ---
Don't know about the steps to reproduce, have not written them and not using
the thumbnail bar (no space for it ...)
My bug (Bug 278346 - status bar is not preserved in full screen mode) was more
about status bar than thumbnail bar.

I don't even find where to enable thumbnail bar be it with menu or with
toolbar. seems only in config file
$ grep -i thumb ~/.kde/share/config/digikamrc |grep -i bar
Show Thumbbar=false
FullScreenHideThumbBar=true
Show Thumbbar=false

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Peter Albrecht-2]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #13 from Peter Albrecht <[hidden email]> ---
To enable the thumbbar (in digikam 2.9.0):

In the main menu:
1. View -> Preview Image (F3)
2. View -> Show Thumbbar (CTRL + T)      (10th entry in the View menu)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=289262

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
            Version|2.9.0                       |3.0.0
     Ever confirmed|0                           |1

--- Comment #14 from Marcel Wiesweg <[hidden email]> ---
Confirmed, easy to reproduce with the steps provided in the initial post. The
code which restores the thumbbar is probably fooled by the switch in full
screen mode back to the thumbnail view.
Normal behavior is restored when switch to preview view and back.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #15 from Gilles Caulier <[hidden email]> ---
Git commit 73502cc716f1940375d7d805e299d8f93fa58adc by Gilles Caulier.
Committed on 30/04/2013 at 06:02.
Pushed by cgilles into branch 'master'.

Add new FullScreenMngr class dedicated manage full-screen action to digiKam
KXMLGuiWindow instances.
This class factorize a lots of code when window is turned on/off to full-screen
mode.
This fix problem about visibility restoring with status-bar, menu-bar, and
thumb-bar.
First managed digiKam main window is Image Editor.
TODO :
- manage full-screen mode of main windows AlbumGUI, BQM, ImportUI, and LT,
through FullScreenMngr.
- manage visibility of side-bars.
- provide a common settings widget to control visibility management in
Configuration dialog.
- patch Configuration dialog to provide a fine control of visibility management
in full-screen mode for each digiKam main window.
Related: bug 214107, bug 220739, bug 236234, bug 258180, bug 293676

M  +1    -0    CMakeLists.txt
A  +231  -0    libs/widgets/common/fullscreenmngr.cpp     [License: GPL (v2+)]
A  +89   -0    libs/widgets/common/fullscreenmngr.h     [License: GPL (v2+)]
M  +19   -109  utilities/imageeditor/editor/editorwindow.cpp
M  +0    -5    utilities/imageeditor/editor/editorwindow.h
M  +5    -13   utilities/imageeditor/editor/editorwindow_p.h
M  +12   -8    utilities/setup/setupeditor.cpp

http://commits.kde.org/digikam/73502cc716f1940375d7d805e299d8f93fa58adc

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #16 from Gilles Caulier <[hidden email]> ---
Git commit cde52bd90737bd8fe2b7dfdb94eba09578549239 by Gilles Caulier.
Committed on 01/05/2013 at 14:19.
Pushed by cgilles into branch 'master'.

Port fullscreen mode from Light Table to FullScreenMngr.
Related: bug 214107, bug 220739, bug 236234, bug 258180, bug 293676

M  +23   -87   utilities/lighttable/lighttablewindow.cpp
M  +1    -3    utilities/lighttable/lighttablewindow.h
M  +3    -8    utilities/lighttable/lighttablewindow_p.h
M  +13   -10   utilities/setup/setuplighttable.cpp
M  +1    -1    utilities/setup/setuplighttable.h

http://commits.kde.org/digikam/cde52bd90737bd8fe2b7dfdb94eba09578549239

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #17 from Gilles Caulier <[hidden email]> ---
Git commit 4b034a235c07758d97b1fe763791abe1bc3c81db by Gilles Caulier.
Committed on 01/05/2013 at 15:10.
Pushed by cgilles into branch 'master'.

Port fullscreen mode from Batch Queue Manager to FullScreenMngr.
Related: bug 214107, bug 220739, bug 236234, bug 258180, bug 293676

M  +3    -0    libs/widgets/common/fullscreenmngr.h
M  +23   -79   utilities/queuemanager/main/queuemgrwindow.cpp
M  +1    -1    utilities/queuemanager/main/queuemgrwindow.h
M  +4    -8    utilities/queuemanager/main/queuemgrwindow_p.h

http://commits.kde.org/digikam/4b034a235c07758d97b1fe763791abe1bc3c81db

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=289262

--- Comment #18 from Gilles Caulier <[hidden email]> ---
Git commit b8a7f5ceddc5c112906e94eaedeb42cbb0917638 by Gilles Caulier.
Committed on 02/05/2013 at 16:10.
Pushed by cgilles into branch 'master'.

As under OSX, if toolbar is hidden during fullscreen mode, we display
fullscreen switch button on top-right corner of active sceen when mouse is
moved on this corner by end user.
Mouse move envent is handle by an event filter plug over managed window.
FullScreenMngr is now a QObject class based.
Related: bug 214107, bug 220739, bug 236234, bug 258180, bug 293676

M  +63   -1    libs/widgets/common/fullscreenmngr.cpp
M  +9    -1    libs/widgets/common/fullscreenmngr.h
M  +0    -1    utilities/imageeditor/editor/editorwindow.cpp
M  +0    -1    utilities/lighttable/lighttablewindow.cpp
M  +0    -1    utilities/queuemanager/main/queuemgrwindow.cpp

http://commits.kde.org/digikam/b8a7f5ceddc5c112906e94eaedeb42cbb0917638

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel